Re: [PATCH v4] ARM: imx: Fix suspend/resume crash with Clang CFI

[Frank Li <Frank.li@oss.nxp.com>]

On Tue, Sep 01, 2026 at 01:36:15PM -0700, Nick Desaulniers wrote:
> On Tue, Sep 1, 2026 at 12:46 PM Sami Tolvanen <samitolvanen@google.com> wrote:
> >
> > On Sun, Aug 30, 2026 at 9:24 AM Yo'av Moshe <linux@yoavmoshe.com> wrote:
> > >
> > > The sashiko-bot's comment on v5 indeed pointed out that imx5, at91 and
> > > omap1 might suffer from the same bug: their suspend routines are also
> > > fncpy()'d into SRAM without a type hash and called indirectly. They're
> > > all ARM, so asm/linkage.h still seems like the right place for the
> > > macro.
> > >
> > > Do you think these need to be fixed as part of this patch, or as
> > > follow-ups? I only have my one imx6 device (a Kobo Clara HD), so I'm not
> > > sure how to test the fixes for the others.
> >
> > I think separate patches for the others should be fine.
>
> Without devices in hand to test on, I'd be hesitant to claim 100%
> confidence. Maybe reach out to the MAINTAINERS of those, and see if
> they have cycles to help test potential patches, before
> writing/sending patches that potentially don't get tested?

Nick Desaulniers:

	Is this patch good to pickup?

Frank

>
> --
> Thanks,
> ~Nick Desaulniers
>