From: Yo'av Moshe <linux@yoavmoshe.com>
To: Nick Desaulniers <ndesaulniers@google.com>,
Sami Tolvanen <samitolvanen@google.com>,
Yo'av Moshe <linux@yoavmoshe.com>
Cc: Nathan Chancellor <nathan@kernel.org>,
Frank Li <Frank.Li@nxp.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Russell King <linux@armlinux.org.uk>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
Bill Wendling <morbo@google.com>,
Justin Stitt <justinstitt@google.com>,
imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
llvm@lists.linux.dev, stable@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] ARM: imx: Fix suspend/resume crash with Clang CFI
Date: Sun, 26 Jul 2026 17:36:37 +0200 [thread overview]
Message-ID: <91cb0f21-e78a-4931-b123-937c6a01592c@yoavmoshe.com> (raw)
In-Reply-To: <CAKwvOdnaOy-nyZ=8oLw4N-_hA9JZVdP2BhR8cweCAOhsy4VG6w@mail.gmail.com>
On 2026-07-24 10:49 PM, Nick Desaulniers wrote:
> Yeah, Yo'av did you test further modifications that explicitly copy
> the hash prefix? I assumed Nathan's change _plus some additional tweak
> to copy not just imx6_suspend to OCRAM which I assume the code already
> does, but I would imagine you need another change to copy
> __kcfi_typeid_imx6_suspend into OCRAM just before the function. Was
> that tested?
Yes, I tried that as well and it unfortunately didn't work.
I tested Nathan's change along with explicitly copying the 4-byte
prefix from before imx6_suspend into OCRAM right before calling fncpy().
However, when checking the compiled binary, "&imx6_suspend - 4" just
contained padding rather than the hash, so the copied 4-byte value
didn't match what the call site expected.
Yo'av
next prev parent reply other threads:[~2026-07-26 15:37 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-18 11:13 [PATCH v3] ARM: imx: Fix suspend/resume crash with Clang CFI Yo'av Moshe
2026-07-18 11:29 ` sashiko-bot
2026-07-20 16:53 ` Nick Desaulniers
2026-07-21 5:20 ` Yo'av Moshe
2026-07-20 19:29 ` Sami Tolvanen
2026-07-21 5:29 ` Yo'av Moshe
2026-07-21 18:09 ` Nathan Chancellor
2026-07-22 12:53 ` Yo'av Moshe
2026-07-22 15:00 ` Sami Tolvanen
2026-07-22 17:46 ` Yo'av Moshe
2026-07-22 18:03 ` Sami Tolvanen
2026-07-23 13:30 ` Yo'av Moshe
2026-07-23 19:21 ` Sami Tolvanen
2026-07-23 19:55 ` Yo'av Moshe
2026-07-24 15:53 ` Sami Tolvanen
2026-07-24 20:49 ` Nick Desaulniers
2026-07-26 15:36 ` Yo'av Moshe [this message]
2026-08-17 17:45 ` Yo'av Moshe
2026-08-17 21:31 ` Frank Li
2026-08-17 21:58 ` Nick Desaulniers
2026-08-24 14:09 ` Yo'av Moshe
2026-08-25 17:33 ` Nick Desaulniers
2026-08-27 16:55 ` Yo'av Moshe
2026-08-27 19:45 ` [PATCH v4] " Yo'av Moshe
2026-08-28 18:29 ` Nick Desaulniers
2026-08-28 18:45 ` Sami Tolvanen
2026-08-28 20:19 ` Nick Desaulniers
2026-08-28 20:50 ` Sami Tolvanen
2026-08-30 16:24 ` Yo'av Moshe
2026-09-01 19:45 ` Sami Tolvanen
2026-09-01 20:36 ` Nick Desaulniers
2026-09-02 16:44 ` Frank Li
2026-09-02 17:10 ` Nick Desaulniers
2026-09-02 17:11 ` Nick Desaulniers
2026-09-02 18:38 ` Nathan Chancellor
2026-08-30 15:51 ` [PATCH v5] " Yo'av Moshe
2026-08-30 16:05 ` sashiko-bot
2026-09-01 19:39 ` Sami Tolvanen
2026-09-02 19:37 ` Frank.Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=91cb0f21-e78a-4931-b123-937c6a01592c@yoavmoshe.com \
--to=linux@yoavmoshe.com \
--cc=Frank.Li@nxp.com \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=justinstitt@google.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=llvm@lists.linux.dev \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=s.hauer@pengutronix.de \
--cc=samitolvanen@google.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.