All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zorro Lang <zlang@kernel.org>
To: Prabhakar Pujeri <prabhakar.pujeri@dell.com>
Cc: fstests@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net,
	 Jaegeuk Kim <jaegeuk@kernel.org>
Subject: Re: [PATCH] f2fs/015,016: add missing _require_scratch checks
Date: Thu, 3 Sep 2026 01:05:49 +0800	[thread overview]
Message-ID: <aphWZOOQLPoN6L1K@zlang-mailbox> (raw)
In-Reply-To: <20260902050133.2413-1-prabhakar.pujeri@dell.com>

Oh, there's one more "add _require_scratch" related patch :)

On Wed, Sep 02, 2026 at 05:01:33AM +0000, Prabhakar Pujeri wrote:
> Both tests run _scratch_mkfs in a loop without first requiring a scratch device, so they fail messily instead of skipping when no scratch device is configured.

This line is too long. I can help to change that when I merge it.
Or *if you have more* similar patches, I can wait for your next
combined patch or patchset.

Reviewed-by: Zorro Lang <zlang@kernel.org>

> 
> Signed-off-by: Prabhakar Pujeri <prabhakar.pujeri@dell.com>
> ---
>  tests/f2fs/015 | 1 +
>  tests/f2fs/016 | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/tests/f2fs/015 b/tests/f2fs/015
> index 54cada4a..75ae91f2 100755
> --- a/tests/f2fs/015
> +++ b/tests/f2fs/015
> @@ -12,6 +12,7 @@ _begin_fstest auto quick mount
>  _require_kernel_config CONFIG_F2FS_FS_XATTR
>  _require_kernel_config CONFIG_F2FS_FS_POSIX_ACL
>  _require_kernel_config CONFIG_F2FS_FAULT_INJECTION
> +_require_scratch
>  
>  options=(
>  #	mount_option			mkfs_option
> diff --git a/tests/f2fs/016 b/tests/f2fs/016
> index a6df827d..e0857e0a 100755
> --- a/tests/f2fs/016
> +++ b/tests/f2fs/016
> @@ -15,6 +15,7 @@ _require_kernel_config CONFIG_F2FS_FS_LZORLE
>  _require_kernel_config CONFIG_F2FS_FS_LZ4
>  _require_kernel_config CONFIG_F2FS_FS_LZ4HC
>  _require_kernel_config CONFIG_F2FS_FS_ZSTD
> +_require_scratch
>  
>  options=(
>  #	mount_option			mkfs_option
> -- 
> 2.55.0
> 

WARNING: multiple messages have this Message-ID (diff)
From: Zorro Lang via Linux-f2fs-devel <linux-f2fs-devel@lists.sourceforge.net>
To: Prabhakar Pujeri <prabhakar.pujeri@dell.com>
Cc: Jaegeuk Kim <jaegeuk@kernel.org>,
	fstests@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH] f2fs/015, 016: add missing _require_scratch checks
Date: Thu, 3 Sep 2026 01:05:49 +0800	[thread overview]
Message-ID: <aphWZOOQLPoN6L1K@zlang-mailbox> (raw)
In-Reply-To: <20260902050133.2413-1-prabhakar.pujeri@dell.com>

Oh, there's one more "add _require_scratch" related patch :)

On Wed, Sep 02, 2026 at 05:01:33AM +0000, Prabhakar Pujeri wrote:
> Both tests run _scratch_mkfs in a loop without first requiring a scratch device, so they fail messily instead of skipping when no scratch device is configured.

This line is too long. I can help to change that when I merge it.
Or *if you have more* similar patches, I can wait for your next
combined patch or patchset.

Reviewed-by: Zorro Lang <zlang@kernel.org>

> 
> Signed-off-by: Prabhakar Pujeri <prabhakar.pujeri@dell.com>
> ---
>  tests/f2fs/015 | 1 +
>  tests/f2fs/016 | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/tests/f2fs/015 b/tests/f2fs/015
> index 54cada4a..75ae91f2 100755
> --- a/tests/f2fs/015
> +++ b/tests/f2fs/015
> @@ -12,6 +12,7 @@ _begin_fstest auto quick mount
>  _require_kernel_config CONFIG_F2FS_FS_XATTR
>  _require_kernel_config CONFIG_F2FS_FS_POSIX_ACL
>  _require_kernel_config CONFIG_F2FS_FAULT_INJECTION
> +_require_scratch
>  
>  options=(
>  #	mount_option			mkfs_option
> diff --git a/tests/f2fs/016 b/tests/f2fs/016
> index a6df827d..e0857e0a 100755
> --- a/tests/f2fs/016
> +++ b/tests/f2fs/016
> @@ -15,6 +15,7 @@ _require_kernel_config CONFIG_F2FS_FS_LZORLE
>  _require_kernel_config CONFIG_F2FS_FS_LZ4
>  _require_kernel_config CONFIG_F2FS_FS_LZ4HC
>  _require_kernel_config CONFIG_F2FS_FS_ZSTD
> +_require_scratch
>  
>  options=(
>  #	mount_option			mkfs_option
> -- 
> 2.55.0
> 


_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

  reply	other threads:[~2026-09-02 17:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-02  5:01 [f2fs-dev] [PATCH] f2fs/015, 016: add missing _require_scratch checks Prabhakar Pujeri via Linux-f2fs-devel
2026-09-02  5:01 ` [PATCH] f2fs/015,016: " Prabhakar Pujeri
2026-09-02 17:05 ` Zorro Lang [this message]
2026-09-02 17:05   ` [f2fs-dev] [PATCH] f2fs/015, 016: " Zorro Lang via Linux-f2fs-devel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aphWZOOQLPoN6L1K@zlang-mailbox \
    --to=zlang@kernel.org \
    --cc=fstests@vger.kernel.org \
    --cc=jaegeuk@kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=prabhakar.pujeri@dell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.