Re: RFC: Enable Sashiko code reviews for

[Mike Rapoport <rppt@kernel.org>]

On Wed, Sep 02, 2026 at 09:29:55AM -0700, David Matlack wrote:
> On Wed, Sep 2, 2026 at 1:04 AM Mike Rapoport <rppt@kernel.org> wrote:
> >
> > Hi Baoquan,
> >
> > On Wed, Sep 02, 2026 at 01:52:51PM +0800, Baoquan He wrote:
> > > On 09/02/26 at 07:34am, Mike Rapoport wrote:
> > > > On Tue, Sep 01, 2026 at 01:27:34PM -0700, David Matlack wrote:
> > > > > Hi kexec@ mailing list and maintainers,
> > > > >
> > > > > I would like to enable Sashiko code reviews for patches sent to the
> > > > > kexec mailing list. I have found it useful for patches I have sent and
> > > > > reviewed on the kvm and linux-pci mailing lists, which have Sashiko
> > > > > enabled.
> > > > >
> > > > > I sent a pull request to Sashiko to add kexec here:
> > > > >
> > > > >   https://github.com/sashiko-dev/sashiko/pull/474
> > > >
> > > > diff --git a/sashiko.dev/email_policy.toml b/sashiko.dev/email_policy.toml
> > > > index e6e4fb57f..e9ad97708 100644
> > > > --- a/sashiko.dev/email_policy.toml
> > > > +++ b/sashiko.dev/email_policy.toml
> > > > @@ -175,6 +175,12 @@ reply_to_author = false
> > > >  cc_individuals = false
> > > >  cc = ["Chuck Lever <cel@kernel.org>", "Jeff Layton <jlayton@kernel.org>", "Anna Schumaker <anna@kernel.org>"]
> > > >
> > > > +[subsystems.kexec]
> > > > +lists = ["kexec@lists.infradead.org"]
> > > > +reply_to_author = true
> > > > +send_positive_review = true
> > > >
> > > > Do we really want those?
> > >
> > > Some components don't want to CC list, then other people are welcome to
> > > drop any comment during reviewing, while cc to maintainer and author
> > > looks good to me. Just an input, no objection to any move.
> >
> > Sorry, I wasn't clear, I meant do we really want extra emails saying
> > sashiko is happy?
> 
> This is currently enabled on the PCI mailing list and I have found it
> useful there. It makes it trivial to distinguish between "Sashiko
> reviewed the patch and found no issues" and "Sashiko did not review
> the patch" (could not apply it, backend bugs, whatever) without having
> to go to the Sashiko web UI to confirm. I can stay entirely on the
> mailing list.
> 
> But I am ok with dropping it if you feel strongly. It is a small thing.

Nah, no strong feelings. I can always /dev/null some emails on my side :)

-- 
Sincerely yours,
Mike.