From: Bjorn Andersson <andersson@kernel.org>
To: Avaneesh Kumar Dwivedi <avaneesh.dwivedi@oss.qualcomm.com>
Cc: Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Akash Kumar <akakum@qti.qualcomm.com>,
Khalid Faisal Ansari <khalid.ansari@oss.qualcomm.com>,
Vishnu Santhosh <vishnu.santhosh@oss.qualcomm.com>,
Nirmesh Kumar Singh <nirmesh.singh@oss.qualcomm.com>
Subject: Re: [PATCH 3/3] arm64: dts: qcom: Add Talos Lyra EVK board
Date: Thu, 3 Sep 2026 09:58:14 -0500 [thread overview]
Message-ID: <apmK3AKEcEo5AUqI@baldur> (raw)
In-Reply-To: <20260901-lyra_upstreaming-v1-3-e3a76dc9e21c@oss.qualcomm.com>
On Tue, Sep 01, 2026 at 07:14:03PM +0530, Avaneesh Kumar Dwivedi wrote:
> Add the device tree for the Talos Lyra EVK platform which combines
> the Talos Lyra EVK SoM and Lyra carrier board.
>
> This device tree adds board-specific peripheral configuration on top
> of the SoM, including:
>
> - Native DisplayPort output
> - GPIO expanders on i2c5
> - SPI-attached TPM (ST33)
> - USB host and peripheral controllers
> - Power and reset keys
>
> Co-developed-by: Akash Kumar <akakum@qti.qualcomm.com>
> Signed-off-by: Akash Kumar <akakum@qti.qualcomm.com>
> Co-developed-by: Khalid Faisal Ansari <khalid.ansari@oss.qualcomm.com>
> Signed-off-by: Khalid Faisal Ansari <khalid.ansari@oss.qualcomm.com>
> Co-developed-by: Vishnu Santhosh <vishnu.santhosh@oss.qualcomm.com>
> Signed-off-by: Vishnu Santhosh <vishnu.santhosh@oss.qualcomm.com>
> Signed-off-by: Nirmesh Kumar Singh <nirmesh.singh@oss.qualcomm.com>
> Signed-off-by: Avaneesh Kumar Dwivedi <avaneesh.dwivedi@oss.qualcomm.com>
Please fix authorship, subject prefix and the top-level compatible. Rest
looks good.
Regards,
Bjorn
> ---
> arch/arm64/boot/dts/qcom/Makefile | 1 +
> arch/arm64/boot/dts/qcom/talos-lyra-evk.dts | 137 ++++++++++++++++++++++++++++
> 2 files changed, 138 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
> index 1c86e7e98f55..9818568912fd 100644
> --- a/arch/arm64/boot/dts/qcom/Makefile
> +++ b/arch/arm64/boot/dts/qcom/Makefile
> @@ -409,6 +409,7 @@ dtb-$(CONFIG_ARCH_QCOM) += sm8650-qrd.dtb
> dtb-$(CONFIG_ARCH_QCOM) += sm8750-mtp.dtb
> dtb-$(CONFIG_ARCH_QCOM) += sm8750-qrd.dtb
> dtb-$(CONFIG_ARCH_QCOM) += talos-evk.dtb
> +dtb-$(CONFIG_ARCH_QCOM) += talos-lyra-evk.dtb
>
> talos-evk-el2-dtbs := talos-evk.dtb talos-el2.dtbo
>
> diff --git a/arch/arm64/boot/dts/qcom/talos-lyra-evk.dts b/arch/arm64/boot/dts/qcom/talos-lyra-evk.dts
> new file mode 100644
> index 000000000000..7974e5bad24c
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/talos-lyra-evk.dts
> @@ -0,0 +1,137 @@
> +// SPDX-License-Identifier: BSD-3-Clause
> +/*
> + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
> + */
> +/dts-v1/;
> +
> +#include "talos-lyra-evk-som.dtsi"
> +
> +/ {
> + model = "Qualcomm QCS615 Talos Lyra EVK";
> + compatible = "qcom,talos-lyra-evk", "qcom,talos-lyra-evk-som", "qcom,qcs615",
> + "qcom,sm6150";
> + chassis-type = "embedded";
> +
> + dp0-connector {
> + compatible = "dp-connector";
> + label = "DP0";
> + type = "full-size";
> +
> + hpd-gpios = <&tlmm 104 GPIO_ACTIVE_HIGH>;
> +
> + port {
> + dp0_connector_in: endpoint {
> + remote-endpoint = <&mdss_dp0_out>;
> + };
> + };
> + };
> +
> +};
> +
> +&i2c5 {
> + clock-frequency = <100000>;
> + status = "okay";
> +
> + expander0: gpio@20 {
> + compatible = "kinetic,kts1622", "ti,tcal6416";
> + reg = <0x20>;
> + #gpio-cells = <2>;
> + gpio-controller;
> + };
> +
> + expander1: gpio@21 {
> + compatible = "kinetic,kts1622", "ti,tcal6416";
> + reg = <0x21>;
> + #gpio-cells = <2>;
> + gpio-controller;
> + };
> +
> + expander2: gpio@38 {
> + compatible = "ti,tca9538";
> + reg = <0x38>;
> + #gpio-cells = <2>;
> + gpio-controller;
> + };
> +
> + expander3: gpio@3c {
> + compatible = "ti,tca9538";
> + reg = <0x3c>;
> + #gpio-cells = <2>;
> + gpio-controller;
> + };
> +};
> +
> +&mdss {
> + status = "okay";
> +};
> +
> +&mdss_dp0 {
> + status = "okay";
> +};
> +
> +&mdss_dp0_out {
> + link-frequencies = /bits/ 64 <1620000000 2700000000 5400000000>;
> + remote-endpoint = <&dp0_connector_in>;
> +};
> +
> +&pon_pwrkey {
> + status = "okay";
> +};
> +
> +&pon_resin {
> + linux,code = <KEY_VOLUMEDOWN>;
> +
> + status = "okay";
> +};
> +
> +&spi6 {
> + status = "okay";
> +
> + tpm@0 {
> + compatible = "st,st33htpm-spi", "tcg,tpm_tis-spi";
> + reg = <0>;
> + spi-max-frequency = <20000000>;
> + };
> +};
> +
> +&usb_1 {
> + dr_mode = "peripheral";
> +
> + status = "okay";
> +};
> +
> +&usb_1_hsphy {
> + vdd-supply = <&vreg_l5a>;
> + vdda-pll-supply = <&vreg_l12a>;
> + vdda-phy-dpdm-supply = <&vreg_l13a>;
> +
> + status = "okay";
> +};
> +
> +&usb_2 {
> + dr_mode = "host";
> +
> + status = "okay";
> +};
> +
> +&usb_2_hsphy {
> + vdd-supply = <&vreg_l5a>;
> + vdda-pll-supply = <&vreg_l12a>;
> + vdda-phy-dpdm-supply = <&vreg_l13a>;
> +
> + status = "okay";
> +};
> +
> +&usb_qmpphy {
> + vdda-phy-supply = <&vreg_l5a>;
> + vdda-pll-supply = <&vreg_l12a>;
> +
> + status = "okay";
> +};
> +
> +&usb_qmpphy_2 {
> + vdda-phy-supply = <&vreg_l5a>;
> + vdda-pll-supply = <&vreg_l12a>;
> +
> + status = "okay";
> +};
>
> --
> 2.34.1
>
prev parent reply other threads:[~2026-09-03 14:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-01 13:44 [PATCH 0/3] Add support for Talos Lyra EVK board Avaneesh Kumar Dwivedi
2026-09-01 13:44 ` [PATCH 1/3] dt-bindings: arm: qcom: Add " Avaneesh Kumar Dwivedi
2026-09-03 12:55 ` Krzysztof Kozlowski
2026-09-03 14:56 ` Bjorn Andersson
2026-09-01 13:44 ` [PATCH 2/3] arm64: dts: qcom: Add Talos Lyra EVK SoM platform Avaneesh Kumar Dwivedi
2026-09-02 10:18 ` Konrad Dybcio
2026-09-03 14:54 ` Bjorn Andersson
2026-09-01 13:44 ` [PATCH 3/3] arm64: dts: qcom: Add Talos Lyra EVK board Avaneesh Kumar Dwivedi
2026-09-02 10:20 ` Konrad Dybcio
2026-09-03 14:58 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=apmK3AKEcEo5AUqI@baldur \
--to=andersson@kernel.org \
--cc=akakum@qti.qualcomm.com \
--cc=avaneesh.dwivedi@oss.qualcomm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=khalid.ansari@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nirmesh.singh@oss.qualcomm.com \
--cc=robh@kernel.org \
--cc=vishnu.santhosh@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.