Re: [PATCH 1/8] ARM: tegra: Clean up AHUB on Tegra124

[Thierry Reding <thierry.reding@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1668 bytes --]

On Thu, Sep 17, 2026 at 09:01:54PM +0100, Jon Hunter wrote:
> Hi Thierry,
> 
> On 02/09/2026 11:17, Thierry Reding wrote:
> > From: Thierry Reding <treding@nvidia.com>
> > 
> > Use #address-cells = <1> and #size-cells = <1> because we don't need
> > 64-bit register addressing for this hardware. While at it, also adjust
> > the ranges property to encompass the entire AHUB range as per the TRM.
> > 
> > Signed-off-by: Thierry Reding <treding@nvidia.com>
> > ---
> >   arch/arm/boot/dts/nvidia/tegra124.dtsi | 16 ++++++++--------
> >   1 file changed, 8 insertions(+), 8 deletions(-)
> > 
> > diff --git a/arch/arm/boot/dts/nvidia/tegra124.dtsi b/arch/arm/boot/dts/nvidia/tegra124.dtsi
> > index ce4efa1de509..7a71dba42dc0 100644
> > --- a/arch/arm/boot/dts/nvidia/tegra124.dtsi
> > +++ b/arch/arm/boot/dts/nvidia/tegra124.dtsi
> > @@ -1114,13 +1114,13 @@ ahub@70300000 {
> >   			    "rx3", "tx3", "rx4", "tx4", "rx5", "tx5",
> >   			    "rx6", "tx6", "rx7", "tx7", "rx8", "tx8",
> >   			    "rx9", "tx9";
> > -		ranges;
> > -		#address-cells = <2>;
> > -		#size-cells = <2>;
> > +		ranges = <0x7030000 0x0 0x70300000 0x10000>;
> 
> 
> I noticed a regression on Tegra124 Jetson TK1 today and I am seeing ...
> 
>  tegra30-i2s 70300000.ahub:i2s@70301100: error -EINVAL: invalid resource (null)
>  tegra30-i2s 70300000.ahub:i2s@70301100: probe with driver tegra30-i2s failed with error -22
> 
> Looks like the first address in the above is missing a 0 and we
> should have 0x70300000 and not 0x7030000.
> 
> Let me know if you want to fix up or what a patch to fix.

Should be fixed now, thanks for reporting this.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]