* [PATCH] EFI: don't use alias attribute for compat hypercall stubs
@ 2026-09-07 15:14 Jan Beulich
2026-09-07 15:15 ` Andrew Cooper
0 siblings, 1 reply; 3+ messages in thread
From: Jan Beulich @ 2026-09-07 15:14 UTC (permalink / raw)
To: xen-devel@lists.xenproject.org; +Cc: Marek Marczykowski, Daniel Smith
Recent Clang objects to types differing between alias and aliasee. Accept
the unnecessary overhead and make the two compat stubs real functions.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/xen/common/efi/common-stub.c
+++ b/xen/common/efi/common-stub.c
@@ -27,10 +27,14 @@ int efi_runtime_call(struct xenpf_efi_ru
#ifdef CONFIG_COMPAT
-int efi_compat_get_info(uint32_t idx, union compat_pf_efi_info *)
- __attribute__((__alias__("efi_get_info")));
+int efi_compat_get_info(uint32_t idx, union compat_pf_efi_info *info)
+{
+ return -ENOSYS;
+}
-int efi_compat_runtime_call(struct compat_pf_efi_runtime_call *)
- __attribute__((__alias__("efi_runtime_call")));
+int efi_compat_runtime_call(struct compat_pf_efi_runtime_call *op)
+{
+ return -ENOSYS;
+}
#endif
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] EFI: don't use alias attribute for compat hypercall stubs
2026-09-07 15:14 [PATCH] EFI: don't use alias attribute for compat hypercall stubs Jan Beulich
@ 2026-09-07 15:15 ` Andrew Cooper
2026-09-09 11:54 ` Marek Marczykowski
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Cooper @ 2026-09-07 15:15 UTC (permalink / raw)
To: Jan Beulich, xen-devel@lists.xenproject.org
Cc: Andrew Cooper, Marek Marczykowski, Daniel Smith
On 07/09/2026 4:14 pm, Jan Beulich wrote:
> Recent Clang objects to types differing between alias and aliasee. Accept
> the unnecessary overhead and make the two compat stubs real functions.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] EFI: don't use alias attribute for compat hypercall stubs
2026-09-07 15:15 ` Andrew Cooper
@ 2026-09-09 11:54 ` Marek Marczykowski
0 siblings, 0 replies; 3+ messages in thread
From: Marek Marczykowski @ 2026-09-09 11:54 UTC (permalink / raw)
To: Andrew Cooper; +Cc: Jan Beulich, xen-devel@lists.xenproject.org, Daniel Smith
[-- Attachment #1: Type: text/plain, Size: 528 bytes --]
On Mon, Sep 07, 2026 at 04:15:54PM +0100, Andrew Cooper wrote:
> On 07/09/2026 4:14 pm, Jan Beulich wrote:
> > Recent Clang objects to types differing between alias and aliasee. Accept
> > the unnecessary overhead and make the two compat stubs real functions.
> >
> > Signed-off-by: Jan Beulich <jbeulich@suse.com>
>
> Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
--
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-09-09 11:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-07 15:14 [PATCH] EFI: don't use alias attribute for compat hypercall stubs Jan Beulich
2026-09-07 15:15 ` Andrew Cooper
2026-09-09 11:54 ` Marek Marczykowski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.