From: Dan Carpenter <error27@gmail.com>
To: Lijo Lazar <lijo.lazar@amd.com>
Cc: amd-gfx@lists.freedesktop.org, "SHANMUGAM,
SRINIVASAN" <SRINIVASAN.SHANMUGAM@amd.com>
Subject: [bug report] drm/amdgpu: Improve ualink state transitions
Date: Mon, 14 Sep 2026 13:18:51 +0300 [thread overview]
Message-ID: <aqfKCyOnoxf0oxIX@stanley.mountain> (raw)
Hello Lijo Lazar,
Commit 0a6da5dcfe42 ("drm/amdgpu: Improve ualink state transitions")
from Jun 9, 2026, leads to the following Smatch complaint:
drivers/gpu/drm/amd/amdgpu/amdgpu_ualink.c:169 amdgpu_ualink_info_set_accel_state()
warn: variable dereferenced before check 'info' (see line 164)
drivers/gpu/drm/amd/amdgpu/amdgpu_ualink.c
163 {
164 enum amdgpu_ualink_accel_state cur = info->accel_state;
^^^^^^^^^^^^^^^^^
The patch adds a new dereference
165 enum amdgpu_ualink_accel_state target;
166 bool ppod_validated;
167 bool vpod_validated;
168
169 if (!info)
^^^^^
The old code assumed info could be NULL.
170 return;
171
This email is a free service from the Smatch-CI project [smatch.sf.net].
regards,
dan carpenter
reply other threads:[~2026-09-14 12:47 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aqfKCyOnoxf0oxIX@stanley.mountain \
--to=error27@gmail.com \
--cc=SRINIVASAN.SHANMUGAM@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=lijo.lazar@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.