* [bug report] drm/amdgpu: Improve ualink state transitions
@ 2026-09-14 10:18 Dan Carpenter
0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2026-09-14 10:18 UTC (permalink / raw)
To: Lijo Lazar; +Cc: amd-gfx, SHANMUGAM, SRINIVASAN
Hello Lijo Lazar,
Commit 0a6da5dcfe42 ("drm/amdgpu: Improve ualink state transitions")
from Jun 9, 2026, leads to the following Smatch complaint:
drivers/gpu/drm/amd/amdgpu/amdgpu_ualink.c:169 amdgpu_ualink_info_set_accel_state()
warn: variable dereferenced before check 'info' (see line 164)
drivers/gpu/drm/amd/amdgpu/amdgpu_ualink.c
163 {
164 enum amdgpu_ualink_accel_state cur = info->accel_state;
^^^^^^^^^^^^^^^^^
The patch adds a new dereference
165 enum amdgpu_ualink_accel_state target;
166 bool ppod_validated;
167 bool vpod_validated;
168
169 if (!info)
^^^^^
The old code assumed info could be NULL.
170 return;
171
This email is a free service from the Smatch-CI project [smatch.sf.net].
regards,
dan carpenter
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2026-09-14 12:47 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-14 10:18 [bug report] drm/amdgpu: Improve ualink state transitions Dan Carpenter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.