Re: [PATCH] gitlab: update the @user id mapping file

["Daniel P. Berrangé" <berrange@redhat.com>]

On Mon, Sep 14, 2026 at 07:45:34PM +0100, Alex Bennée wrote:
> I needed to fix a POSIX-ism in the script as well.
> 
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
>  .gitlab-map-auto          | 8 +++++---
>  scripts/gitlab-map-update | 2 +-
>  2 files changed, 6 insertions(+), 4 deletions(-)

> diff --git a/scripts/gitlab-map-update b/scripts/gitlab-map-update
> index c134c226aa2..743ad11900d 100755
> --- a/scripts/gitlab-map-update
> +++ b/scripts/gitlab-map-update
> @@ -33,7 +33,7 @@ glab api --paginate /projects/qemu-project%2fqemu/members | \
>      .gitlab-map-auto.tmp
>  test $? != 0 && fail=1
>  
> -if test $fail == 0
> +if test $fail -eq 0

Using '=' instead of 'eq' is more typical, and what I intended
to use originally.

>  then
>    grep '^#' .gitlab-map-auto > .gitlab-map-auto.new
>    LC_ALL=C sort .gitlab-map-auto.tmp | uniq >> .gitlab-map-auto.new


Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com       ~~        https://hachyderm.io/@berrange :|
|: https://libvirt.org          ~~          https://entangle-photo.org :|
|: https://pixelfed.art/berrange   ~~    https://fstop138.berrange.com :|