[PATCH] gitlab: update the @user id mapping file

[PATCH] gitlab: update the @user id mapping file

[Alex Bennée]

I needed to fix a POSIX-ism in the script as well.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
 .gitlab-map-auto          | 8 +++++---
 scripts/gitlab-map-update | 2 +-
 2 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/.gitlab-map-auto b/.gitlab-map-auto
index 28ce448f1bf..3f717a15d4e 100644
--- a/.gitlab-map-auto
+++ b/.gitlab-map-auto
@@ -12,11 +12,12 @@ a1xndr	Alexander Bulekov
 adi-g15-ibm	Aditya Gupta
 agraf	Alexander Graf
 alex.williamson	Alex Williamson
-aliang1	Aihua Liang
 alistair23	Alistair Francis
+amachhiw	Amit Machhiwal
 anisinha	Ani Sinha
 anthony-linaro	Anthony Roberts
 anthonyper	Anthony PERARD
+aroxell	Anders Roxell
 berrange	Daniel P. Berrangé
 birkelund	Klaus Jensen
 bonzini	Paolo Bonzini
@@ -36,10 +37,10 @@ dwmw2	David Woodhouse
 eauger1	Eric Auger
 ebblake	Eric Blake
 edgar.iglesias	Edgar E. Iglesias
+efarman	Eric Farman
 ehabkost	Eduardo Habkost
 eldondev	Eldon
 epilys	Manos Pitsidianakis
-famzheng	Fam Zheng
 farosas	Fabiano Rosas
 gautammenghani	Gautam Menghani
 gkurz	Greg Kurz
@@ -51,7 +52,6 @@ imammedo	Igor Mammedov
 jasowang	Jason Wang
 jmacarthur	Jim MacArthur
 jsnow	John Snow
-juan.quintela	Juan Quintela
 kbastian-qemu	Bastian Koppelmann
 kmwolf	Kevin Wolf
 kostyanf14	Kostiantyn Kostiuk
@@ -67,6 +67,7 @@ mauromatteo.cascella	Mauro Matteo Cascella
 mcayland	Mark Cave-Ayland
 mdroth	Michael Roth
 mediouni-m	M. Mediouni
+mjrosato	Matthew Rosato
 mjt0k	Michael Tokarev
 mstredhat	MST
 npiggin	npiggin
@@ -79,6 +80,7 @@ pipo.sk	Peter Krempa
 pkrempa	Peter Krempa (work)
 pm215	Peter Maydell
 qemu-janitor	Qemu Janitor
+raphael.s.norwitz	Raphael Norwitz
 rathc	Chinmay Rath
 rth7680	Richard Henderson
 schoenebeck	Christian Schoenebeck
diff --git a/scripts/gitlab-map-update b/scripts/gitlab-map-update
index c134c226aa2..743ad11900d 100755
--- a/scripts/gitlab-map-update
+++ b/scripts/gitlab-map-update
@@ -33,7 +33,7 @@ glab api --paginate /projects/qemu-project%2fqemu/members | \
     .gitlab-map-auto.tmp
 test $? != 0 && fail=1
 
-if test $fail == 0
+if test $fail -eq 0
 then
   grep '^#' .gitlab-map-auto > .gitlab-map-auto.new
   LC_ALL=C sort .gitlab-map-auto.tmp | uniq >> .gitlab-map-auto.new
-- 
2.47.3

Re: [PATCH] gitlab: update the @user id mapping file

[Daniel P. Berrangé]

On Mon, Sep 14, 2026 at 07:45:34PM +0100, Alex Bennée wrote:
> I needed to fix a POSIX-ism in the script as well.
> 
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
>  .gitlab-map-auto          | 8 +++++---
>  scripts/gitlab-map-update | 2 +-
>  2 files changed, 6 insertions(+), 4 deletions(-)

> diff --git a/scripts/gitlab-map-update b/scripts/gitlab-map-update
> index c134c226aa2..743ad11900d 100755
> --- a/scripts/gitlab-map-update
> +++ b/scripts/gitlab-map-update
> @@ -33,7 +33,7 @@ glab api --paginate /projects/qemu-project%2fqemu/members | \
>      .gitlab-map-auto.tmp
>  test $? != 0 && fail=1
>  
> -if test $fail == 0
> +if test $fail -eq 0

Using '=' instead of 'eq' is more typical, and what I intended
to use originally.

>  then
>    grep '^#' .gitlab-map-auto > .gitlab-map-auto.new
>    LC_ALL=C sort .gitlab-map-auto.tmp | uniq >> .gitlab-map-auto.new


Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com       ~~        https://hachyderm.io/@berrange :|
|: https://libvirt.org          ~~          https://entangle-photo.org :|
|: https://pixelfed.art/berrange   ~~    https://fstop138.berrange.com :|

Re: [PATCH] gitlab: update the @user id mapping file

[Alex Bennée]

Daniel P. Berrangé <berrange@redhat.com> writes:

> On Mon, Sep 14, 2026 at 07:45:34PM +0100, Alex Bennée wrote:
>> I needed to fix a POSIX-ism in the script as well.
>> 
>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>> ---
>>  .gitlab-map-auto          | 8 +++++---
>>  scripts/gitlab-map-update | 2 +-
>>  2 files changed, 6 insertions(+), 4 deletions(-)
>
>> diff --git a/scripts/gitlab-map-update b/scripts/gitlab-map-update
>> index c134c226aa2..743ad11900d 100755
>> --- a/scripts/gitlab-map-update
>> +++ b/scripts/gitlab-map-update
>> @@ -33,7 +33,7 @@ glab api --paginate /projects/qemu-project%2fqemu/members | \
>>      .gitlab-map-auto.tmp
>>  test $? != 0 && fail=1
>>  
>> -if test $fail == 0
>> +if test $fail -eq 0
>
> Using '=' instead of 'eq' is more typical, and what I intended
> to use originally.

I did consider it (and originally used =) but I went to -eq as that is
explicitly a numerical rather than a string compare.

>
>>  then
>>    grep '^#' .gitlab-map-auto > .gitlab-map-auto.new
>>    LC_ALL=C sort .gitlab-map-auto.tmp | uniq >> .gitlab-map-auto.new
>
>
> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
>
>
> With regards,
> Daniel

-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro