From: Fabio Baltieri <fabiobaltieri@chromium.org>
To: "Benjamin Cabé" <kartben@gmail.com>, linux-i2c@vger.kernel.org
Cc: Till Harbaum <till@harbaum.org>,
Andi Shyti <andi.shyti@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i2c: tiny-usb: add Zephyr Project VID/PID pair
Date: Wed, 16 Sep 2026 11:11:10 +0100 [thread overview]
Message-ID: <aqprPlSgpqkMmWJf@google.com> (raw)
In-Reply-To: <20260820213958.41276-1-kartben@gmail.com>
Heya,
On Thu, Aug 20, 2026 at 11:39:46PM +0200, Benjamin Cabé wrote:
> The Zephyr Project ships an i2c-tiny-usb sample with its USB device
> stack, which turns any supported board into a USB-to-I2C bridge. The
> sample implements the same vendor request protocol as the original
> i2c-tiny-usb firmware, exposing a single vendor-specific interface
> with no endpoints, so it can be driven by this driver as-is.
>
> Zephyr in-tree samples must use the project's own USB vendor ID
> (0x2fe3) rather than a donated or third-party one, and product ID
> 0x0013 is reserved for this sample in the project's VID/PID list.
> Without an entry here, users have to bind the device by hand through
> the driver's dynamic ID sysfs attribute.
>
> Link: https://github.com/zephyrproject-rtos/zephyr/commit/281b5743d183
> Assisted-by: Claude:claude-opus-5
> Signed-off-by: Benjamin Cabé <kartben@gmail.com>
> ---
> drivers/i2c/busses/i2c-tiny-usb.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-tiny-usb.c b/drivers/i2c/busses/i2c-tiny-usb.c
> index 73355a56aabf..113af96728dd 100644
> --- a/drivers/i2c/busses/i2c-tiny-usb.c
> +++ b/drivers/i2c/busses/i2c-tiny-usb.c
> @@ -157,11 +157,13 @@ static const struct i2c_algorithm usb_algorithm = {
> /*
> * Initially the usb i2c interface uses a vid/pid pair donated by
> * Future Technology Devices International Ltd., later a pair was
> - * bought from EZPrototypes
> + * bought from EZPrototypes. The Zephyr Project reserved a pid from
> + * its own vid for the i2c-tiny-usb sample of its USB device stack.
> */
> static const struct usb_device_id i2c_tiny_usb_table[] = {
> { USB_DEVICE(0x0403, 0xc631) }, /* FTDI */
> { USB_DEVICE(0x1c40, 0x0534) }, /* EZPrototypes */
> + { USB_DEVICE(0x2fe3, 0x0013) }, /* Zephyr Project */
> { } /* Terminating entry */
> };
Thanks this makes the Zephyr side sample way easier to use.
Reviewed-by: Fabio Baltieri <fabiobaltieri@chromium.org>
Cheers,
Fabio
prev parent reply other threads:[~2026-09-16 10:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-20 21:39 [PATCH] i2c: tiny-usb: add Zephyr Project VID/PID pair Benjamin Cabé
2026-09-16 10:11 ` Fabio Baltieri [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aqprPlSgpqkMmWJf@google.com \
--to=fabiobaltieri@chromium.org \
--cc=andi.shyti@kernel.org \
--cc=kartben@gmail.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=till@harbaum.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.