All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jarkko Sakkinen <jarkko@kernel.org>
To: Kuldeep Singh <kuldeep.singh@oss.qualcomm.com>
Cc: Amirreza Zarrabi <amirreza.zarrabi@oss.qualcomm.com>,
	Jens Wiklander <jenswi@kernel.org>,
	Sumit Garg <sumit.garg@kernel.org>,
	Peter Huewe <peterhuewe@gmx.de>, Jason Gunthorpe <jgg@ziepe.ca>,
	linux-arm-msm@vger.kernel.org, op-tee@lists.trustedfirmware.org,
	linux-kernel@vger.kernel.org, linux-integrity@vger.kernel.org
Subject: Re: [PATCH v2 1/3] tee: qcomtee: Register qcom.tz.tpm service for discovery
Date: Fri, 18 Sep 2026 04:46:06 +0300	[thread overview]
Message-ID: <aqyX3lJ1eNBmzbSP@kernel.org> (raw)
In-Reply-To: <20260907-tpm_qcom_driver-v2-1-71a6b1752da8@oss.qualcomm.com>

On Mon, Sep 07, 2026 at 02:58:41PM +0530, Kuldeep Singh wrote:
> Add "qcom.tz.tpm" (QCOMTEE_TPM_UID) to qtee_services[] so the TPM TA
> is enumerated as a TEE-bus device, allowing a client driver to bind to
> it via its generated UUID.
> 
> Signed-off-by: Kuldeep Singh <kuldeep.singh@oss.qualcomm.com>
> ---
>  drivers/tee/qcomtee/call.c        | 4 +++-
>  drivers/tee/qcomtee/qcomtee_msg.h | 2 ++
>  2 files changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/tee/qcomtee/call.c b/drivers/tee/qcomtee/call.c
> index 4212572ff54b..aca4e8c6e37b 100644
> --- a/drivers/tee/qcomtee/call.c
> +++ b/drivers/tee/qcomtee/call.c
> @@ -753,7 +753,9 @@ static const uuid_t qtee_service_uuid_ns = UUID_INIT(0xe1b48857, 0x6154, 0x49f9,
>  
>  static const struct qtee_service qtee_services[] = {
>  	{ "qcom.tz.uefisecapp",
> -	   QCOMTEE_UEFI_SEC_UID }
> +	   QCOMTEE_UEFI_SEC_UID },
> +	{ "qcom.tz.tpm",
> +	   QCOMTEE_TPM_UID }
>  };
>  
>  static void qtee_release_service(struct device *dev)
> diff --git a/drivers/tee/qcomtee/qcomtee_msg.h b/drivers/tee/qcomtee/qcomtee_msg.h
> index ecaf8db67d45..87f1c257a877 100644
> --- a/drivers/tee/qcomtee/qcomtee_msg.h
> +++ b/drivers/tee/qcomtee/qcomtee_msg.h
> @@ -106,6 +106,8 @@ union qcomtee_msg_arg {
>  #define QTEE_VERSION_GET_PATCH(x) ((x) >> 0 & 0xfffU)
>  
>  #define QCOMTEE_UEFI_SEC_UID            413
> +#define QCOMTEE_TPM_UID			81
> +
>  /* Response types as returned from qcomtee_object_invoke_ctx_invoke(). */
>  
>  /* The message contains a callback request. */
> 
> -- 
> 2.34.1
> 

Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>

BR, Jarkko

WARNING: multiple messages have this Message-ID (diff)
From: Jarkko Sakkinen via OP-TEE <op-tee@lists.trustedfirmware.org>
To: Kuldeep Singh <kuldeep.singh@oss.qualcomm.com>
Cc: Amirreza Zarrabi <amirreza.zarrabi@oss.qualcomm.com>,
	Jens Wiklander <jenswi@kernel.org>,
	Sumit Garg <sumit.garg@kernel.org>,
	Peter Huewe <peterhuewe@gmx.de>, Jason Gunthorpe <jgg@ziepe.ca>,
	linux-arm-msm@vger.kernel.org, op-tee@lists.trustedfirmware.org,
	linux-kernel@vger.kernel.org, linux-integrity@vger.kernel.org
Subject: Re: [PATCH v2 1/3] tee: qcomtee: Register qcom.tz.tpm service for discovery
Date: Fri, 18 Sep 2026 04:46:06 +0300	[thread overview]
Message-ID: <aqyX3lJ1eNBmzbSP@kernel.org> (raw)
In-Reply-To: <20260907-tpm_qcom_driver-v2-1-71a6b1752da8@oss.qualcomm.com>

On Mon, Sep 07, 2026 at 02:58:41PM +0530, Kuldeep Singh wrote:
> Add "qcom.tz.tpm" (QCOMTEE_TPM_UID) to qtee_services[] so the TPM TA
> is enumerated as a TEE-bus device, allowing a client driver to bind to
> it via its generated UUID.
> 
> Signed-off-by: Kuldeep Singh <kuldeep.singh@oss.qualcomm.com>
> ---
>  drivers/tee/qcomtee/call.c        | 4 +++-
>  drivers/tee/qcomtee/qcomtee_msg.h | 2 ++
>  2 files changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/tee/qcomtee/call.c b/drivers/tee/qcomtee/call.c
> index 4212572ff54b..aca4e8c6e37b 100644
> --- a/drivers/tee/qcomtee/call.c
> +++ b/drivers/tee/qcomtee/call.c
> @@ -753,7 +753,9 @@ static const uuid_t qtee_service_uuid_ns = UUID_INIT(0xe1b48857, 0x6154, 0x49f9,
>  
>  static const struct qtee_service qtee_services[] = {
>  	{ "qcom.tz.uefisecapp",
> -	   QCOMTEE_UEFI_SEC_UID }
> +	   QCOMTEE_UEFI_SEC_UID },
> +	{ "qcom.tz.tpm",
> +	   QCOMTEE_TPM_UID }
>  };
>  
>  static void qtee_release_service(struct device *dev)
> diff --git a/drivers/tee/qcomtee/qcomtee_msg.h b/drivers/tee/qcomtee/qcomtee_msg.h
> index ecaf8db67d45..87f1c257a877 100644
> --- a/drivers/tee/qcomtee/qcomtee_msg.h
> +++ b/drivers/tee/qcomtee/qcomtee_msg.h
> @@ -106,6 +106,8 @@ union qcomtee_msg_arg {
>  #define QTEE_VERSION_GET_PATCH(x) ((x) >> 0 & 0xfffU)
>  
>  #define QCOMTEE_UEFI_SEC_UID            413
> +#define QCOMTEE_TPM_UID			81
> +
>  /* Response types as returned from qcomtee_object_invoke_ctx_invoke(). */
>  
>  /* The message contains a callback request. */
> 
> -- 
> 2.34.1
> 

Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>

BR, Jarkko

  reply	other threads:[~2026-09-18  1:46 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-07  9:28 [PATCH v2 0/3] Add TPM support via Qualcomm TEE TPM TA Kuldeep Singh
2026-09-07  9:28 ` Kuldeep Singh via OP-TEE
2026-09-07  9:28 ` [PATCH v2 1/3] tee: qcomtee: Register qcom.tz.tpm service for discovery Kuldeep Singh
2026-09-07  9:28   ` Kuldeep Singh via OP-TEE
2026-09-18  1:46   ` Jarkko Sakkinen [this message]
2026-09-18  1:46     ` Jarkko Sakkinen via OP-TEE
2026-09-21  8:10     ` Kuldeep Singh
2026-09-21  8:10       ` Kuldeep Singh via OP-TEE
2026-09-25  8:51       ` Jens Wiklander
2026-09-25  8:51         ` Jens Wiklander via OP-TEE
2026-09-28  8:58         ` Amirreza Zarrabi
2026-09-28  8:58           ` Amirreza Zarrabi via OP-TEE
2026-09-07  9:28 ` [PATCH v2 2/3] tpm: Introduce Qualcomm TPM driver Kuldeep Singh
2026-09-07  9:28   ` Kuldeep Singh via OP-TEE
2026-09-18  1:48   ` Jarkko Sakkinen
2026-09-18  1:48     ` Jarkko Sakkinen via OP-TEE
2026-09-28 23:29   ` Amirreza Zarrabi
2026-09-28 23:29     ` Amirreza Zarrabi via OP-TEE
2026-10-07  9:20     ` Kuldeep Singh
2026-10-07  9:20       ` Kuldeep Singh via OP-TEE
2026-09-07  9:28 ` [PATCH v2 3/3] MAINTAINERS: Add Qualcomm TPM driver entry Kuldeep Singh
2026-09-07  9:28   ` Kuldeep Singh via OP-TEE
2026-09-18  1:49   ` Jarkko Sakkinen
2026-09-18  1:49     ` Jarkko Sakkinen via OP-TEE
2026-09-16  9:02 ` [PATCH v2 0/3] Add TPM support via Qualcomm TEE TPM TA Kuldeep Singh
2026-09-16  9:02   ` Kuldeep Singh via OP-TEE
2026-09-18  1:53 ` Jarkko Sakkinen
2026-09-18  1:53   ` Jarkko Sakkinen via OP-TEE
2026-09-21  8:36   ` Kuldeep Singh
2026-09-21  8:36     ` Kuldeep Singh via OP-TEE
2026-09-25 14:46     ` Jarkko Sakkinen
2026-09-25 14:46       ` Jarkko Sakkinen via OP-TEE
2026-09-28  9:34       ` Kuldeep Singh
2026-09-28  9:34         ` Kuldeep Singh via OP-TEE

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aqyX3lJ1eNBmzbSP@kernel.org \
    --to=jarkko@kernel.org \
    --cc=amirreza.zarrabi@oss.qualcomm.com \
    --cc=jenswi@kernel.org \
    --cc=jgg@ziepe.ca \
    --cc=kuldeep.singh@oss.qualcomm.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=op-tee@lists.trustedfirmware.org \
    --cc=peterhuewe@gmx.de \
    --cc=sumit.garg@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.