Re: [PATCH 1/1] media: i2c: Add Omnivision ov05c10 sensor driver

[Mehdi Djait <mehdi.djait@linux.intel.com>]

Hi Sakari,

On Tue, Sep 29, 2026 at 03:18:02PM +0300, Sakari Ailus wrote:
> From: Hao Yao <hao.yao@intel.com>
> 
> Add a driver for the Omnivision ov05c10 camera sensor. This driver
> implements a single mode only.

[..]

> +/* This function tries to get power control resources */
> +static int ov05c10_get_pm_resources(struct device *dev)
> +{
> +	struct v4l2_subdev *sd = dev_get_drvdata(dev);
> +	struct ov05c10 *ov05c10 = to_ov05c10(sd);
> +
> +	ov05c10->img_clk = devm_clk_get_optional(dev, NULL);

Please use the v4l2 clk helper here.

> +	if (IS_ERR(ov05c10->img_clk))
> +		return dev_err_probe(dev, PTR_ERR(ov05c10->img_clk),
> +				     "failed to get imaging clock\n");

--
Kind Regards
Mehdi Djait