Re: [PATCH 1/1] media: i2c: Add Omnivision ov05c10 sensor driver

[Antti Laakso <antti.laakso@linux.intel.com>]

On Wed, Sep 30, 2026 at 03:32:39PM +0300, Sakari Ailus wrote:
> Hei Antti,
> 
> Thanks for the review.
> 
> On Wed, Sep 30, 2026 at 03:27:38PM +0300, Antti Laakso wrote:
> ...
> > > +static int ov05c10_parse_fwnode(struct ov05c10 *ov05c10, struct device *dev)
> > > +{
> > > +	struct fwnode_handle *endpoint;
> > > +	struct v4l2_fwnode_endpoint bus_cfg = {
> > > +		.bus_type = V4L2_MBUS_CSI2_DPHY,
> > > +	};
> > > +	int ret;
> > > +
> > > +	endpoint = fwnode_graph_get_endpoint_by_id(dev_fwnode(dev), 0, 0,
> > > +						   FWNODE_GRAPH_ENDPOINT_NEXT);
> > 
> > Should this return -EPROBE_DEFER in case endpoint is not found?
> 
> v4l2_fwnode_endpoint_alloc_parse() will return that if endpoint is NULL.
> 

Ah, indeed.

Reviewed-by: Antti Laakso <antti.laakso@linux.intel.com>

> > 
> > > +	ret = v4l2_fwnode_endpoint_alloc_parse(endpoint, &bus_cfg);
> > > +	fwnode_handle_put(endpoint);
> > > +	if (ret) {
> > > +		dev_err(dev, "parsing endpoint node failed\n");
> > > +		goto out_err;
> > > +	}
> 
> -- 
> Regards,
> 
> Sakari Ailus