From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Eric Sandeen <sandeen@redhat.com>,
linux-xfs@vger.kernel.org, cem@kernel.org
Subject: Re: [PATCH 0/2] xfs: dedupe realtime rmap btree code
Date: Mon, 21 Sep 2026 01:24:13 -0700 [thread overview]
Message-ID: <arDprUJAb7QP1EVx@infradead.org> (raw)
In-Reply-To: <20260921034003.GG2705364@frogsfrogsfrogs>
On Sun, Sep 20, 2026 at 08:40:03PM -0700, Darrick J. Wong wrote:
> In general this looks good to me, though I'll add that the same sort of
> code deduplication could likely be done to the refcount btree code too.
I thought the same while reading over the patches. Also the exported
in patch 1 threw me off, but it didn't actually export anything.
I'd be tempted to just merge the two patches as that's easier to follow,
but otherwise this looks good to me:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2026-09-21 8:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-18 18:01 [PATCH 0/2] xfs: dedupe realtime rmap btree code Eric Sandeen
2026-09-18 18:01 ` [PATCH 1/2] xfs: export several rmap btree key/record ops Eric Sandeen
2026-09-18 18:01 ` [PATCH 2/2] xfs: use the shared rmap btree ops for the rt rmap btree Eric Sandeen
2026-09-21 3:40 ` [PATCH 0/2] xfs: dedupe realtime rmap btree code Darrick J. Wong
2026-09-21 8:24 ` Christoph Hellwig [this message]
2026-09-21 17:56 ` Eric Sandeen
2026-09-21 18:17 ` Carlos Maiolino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=arDprUJAb7QP1EVx@infradead.org \
--to=hch@infradead.org \
--cc=cem@kernel.org \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.