Re: [PATCH 0/2] xfs: dedupe realtime rmap btree code

[Carlos Maiolino <cem@kernel.org>]

On Mon, Sep 21, 2026 at 12:56:58PM -0500, Eric Sandeen wrote:
> On 9/21/26 3:24 AM, Christoph Hellwig wrote:
> > On Sun, Sep 20, 2026 at 08:40:03PM -0700, Darrick J. Wong wrote:
> >> In general this looks good to me, though I'll add that the same sort of
> >> code deduplication could likely be done to the refcount btree code too.
> > 
> > I thought the same while reading over the patches.  Also the exported
> > in patch 1 threw me off, but it didn't actually export anything.
> > 
> > I'd be tempted to just merge the two patches as that's easier to follow,
> > but otherwise this looks good to me:
> > 
> > Reviewed-by: Christoph Hellwig <hch@lst.de>
> Oh, ok - I can merge them if folks prefer. (I kinda thought a prep patch
> / use patch was simpler to follow but I really don't care either way.)
> 
> And yeah, you're both right about the refcount code, I should have thought
> of that. It's much shorter functions and my duplicate code scan was looking
> for bigger chunks, but I didn't fully engage my brain.
> 
> Happy to send V2 with both, and merge each into a single patch if that's
> what people want.

This sounds like a good plan for me :)

For the code in these patches though:

Reviewed-by: Carlos Maiolino <cmaiolino@redhat.com>

> 
> -Eric
>