From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Yonggang Luo <luoyonggang@gmail.com>
Cc: qemu-devel@nongnu.org, "Xianglai Li" <lixianglai@loongson.cn>,
"Weiwei Li" <liwei1518@gmail.com>,
"Alistair Francis" <alistair.francis@wdc.com>,
"Stafford Horne" <shorne@gmail.com>,
qemu-riscv@nongnu.org, qemu-arm@nongnu.org,
"Jiaxun Yang" <jiaxun.yang@flygoat.com>,
"Zhao Liu" <zhao1.liu@intel.com>,
"Brian Cain" <brian.cain@oss.qualcomm.com>,
"Laurent Vivier" <laurent@vivier.eu>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Pierrick Bouvier" <pierrick.bouvier@oss.qualcomm.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Song Gao" <17746591750@163.com>,
"Daniel Henrique Barboza" <daniel.barboza@oss.qualcomm.com>,
"Bibo Mao" <maobibo@loongson.cn>,
"Chao Liu" <chao.liu@processmission.com>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Philippe Mathieu-Daude" <philmd@mailo.com>,
"Philippe Mathieu-Daudé" <philmd@oss.qualcomm.com>,
"Liu Zhiwei" <zhiwei_liu@linux.alibaba.com>,
"Max Filippov" <jcmvbkbc@gmail.com>
Subject: Re: [PATCH 1/8] machine: allow -M name to differ from QOM type
Date: Mon, 21 Sep 2026 15:19:16 +0100 [thread overview]
Message-ID: <arE85G8MqlxMQQ7B@redhat.com> (raw)
In-Reply-To: <20260918000640.1001-2-luoyonggang@gmail.com>
On Fri, Sep 18, 2026 at 08:06:32AM +0800, Yonggang Luo wrote:
> - Add machine_class_set_name() so boards can keep a stable -M name
> when the QOM type is uniquified. machine_class_base_init still
> defaults the name to the QOM type without -machine.
> - Document that MachineClass::name is the -M name, not the QOM type.
> - Sort -M help by MachineClass::name so order matches the printed names
> when QOM types are prefixed (arm-virt-11.1-machine vs virt-11.1).
>
> Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
> ---
> hw/core/machine.c | 6 ++++++
> include/hw/core/boards.h | 12 +++++++++++-
> system/vl.c | 8 +++-----
> 3 files changed, 20 insertions(+), 6 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com ~~ https://hachyderm.io/@berrange :|
|: https://libvirt.org ~~ https://entangle-photo.org :|
|: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|
next prev parent reply other threads:[~2026-09-21 14:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-18 0:06 [PATCH 0/8] machine: uniquify virt QOM names Yonggang Luo
2026-09-18 0:06 ` [PATCH 1/8] machine: allow -M name to differ from QOM type Yonggang Luo
2026-09-21 14:19 ` Daniel P. Berrangé [this message]
2026-09-21 14:50 ` Daniel P. Berrangé
2026-09-18 0:06 ` [PATCH 2/8] hw/riscv/virt: use unique QOM name Yonggang Luo
2026-09-18 0:06 ` [PATCH 3/8] hw/arm/virt: " Yonggang Luo
2026-09-18 0:06 ` [PATCH 4/8] hw/or1k/virt: " Yonggang Luo
2026-09-18 0:06 ` [PATCH 5/8] hw/hexagon/virt: " Yonggang Luo
2026-09-18 3:26 ` Brian Cain
2026-09-18 0:06 ` [PATCH 6/8] hw/loongarch/virt: " Yonggang Luo
2026-09-18 0:06 ` [PATCH 7/8] hw/m68k/virt: " Yonggang Luo
2026-09-18 0:06 ` [PATCH 8/8] hw/xtensa/virt: " Yonggang Luo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=arE85G8MqlxMQQ7B@redhat.com \
--to=berrange@redhat.com \
--cc=17746591750@163.com \
--cc=alistair.francis@wdc.com \
--cc=brian.cain@oss.qualcomm.com \
--cc=chao.liu@processmission.com \
--cc=daniel.barboza@oss.qualcomm.com \
--cc=jcmvbkbc@gmail.com \
--cc=jiaxun.yang@flygoat.com \
--cc=laurent@vivier.eu \
--cc=liwei1518@gmail.com \
--cc=lixianglai@loongson.cn \
--cc=luoyonggang@gmail.com \
--cc=maobibo@loongson.cn \
--cc=palmer@dabbelt.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@mailo.com \
--cc=philmd@oss.qualcomm.com \
--cc=pierrick.bouvier@oss.qualcomm.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=shorne@gmail.com \
--cc=zhao1.liu@intel.com \
--cc=zhiwei_liu@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.