All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Andrey Albershteyn <aalbersh@kernel.org>
Cc: djwong@kernel.org, ebiggers@kernel.org,
	Carlos Maiolino <cem@kernel.org>,
	fsverity@lists.linux.dev, linux-fsdevel@vger.kernel.org,
	linux-xfs@vger.kernel.org, linux-unionfs@vger.kernel.org,
	linux-ext4@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	linux-btrfs@vger.kernel.org, david@fromorbit.com
Subject: Re: [PATCH v16 11/21] xfs: handle fsverity I/O in write/read path
Date: Tue, 22 Sep 2026 00:15:41 -0700	[thread overview]
Message-ID: <arIrHUj9SMUW6WSD@infradead.org> (raw)
In-Reply-To: <20260918111539.1003439-12-aalbersh@kernel.org>

On Fri, Sep 18, 2026 at 01:15:23PM +0200, Andrey Albershteyn wrote:
> For write/writeback set IOMAP_F_FSVERITY flag telling iomap to not
> update inode size and to not skip folios beyond EOF.
> 
> Initiate fsverity writeback with IOMAP_F_FSVERITY set to tell iomap
> should not skip folio that is dirty beyond EOF.
> 
> In read path let iomap know that we are reading fsverity metadata. So,
> treat holes in the tree as request to synthesize tree blocks and hole
> after descriptor as end of the fsverity region.
> 
> Introduce a new inode flag meaning that merkle tree is being build on
> the inode.

Sashiko had some comments on this that did not sound entirely stupid
to me.


WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Andrey Albershteyn <aalbersh@kernel.org>
Cc: fsverity@lists.linux.dev, linux-xfs@vger.kernel.org,
	djwong@kernel.org, Carlos Maiolino <cem@kernel.org>,
	david@fromorbit.com, linux-unionfs@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net, ebiggers@kernel.org,
	linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
	linux-btrfs@vger.kernel.org
Subject: Re: [f2fs-dev] [PATCH v16 11/21] xfs: handle fsverity I/O in write/read path
Date: Tue, 22 Sep 2026 00:15:41 -0700	[thread overview]
Message-ID: <arIrHUj9SMUW6WSD@infradead.org> (raw)
In-Reply-To: <20260918111539.1003439-12-aalbersh@kernel.org>

On Fri, Sep 18, 2026 at 01:15:23PM +0200, Andrey Albershteyn wrote:
> For write/writeback set IOMAP_F_FSVERITY flag telling iomap to not
> update inode size and to not skip folios beyond EOF.
> 
> Initiate fsverity writeback with IOMAP_F_FSVERITY set to tell iomap
> should not skip folio that is dirty beyond EOF.
> 
> In read path let iomap know that we are reading fsverity metadata. So,
> treat holes in the tree as request to synthesize tree blocks and hole
> after descriptor as end of the fsverity region.
> 
> Introduce a new inode flag meaning that merkle tree is being build on
> the inode.

Sashiko had some comments on this that did not sound entirely stupid
to me.



_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

  parent reply	other threads:[~2026-09-22  7:15 UTC|newest]

Thread overview: 111+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-18 11:15 [PATCH v16 00/21] fs-verity support for XFS with post EOF merkle tree Andrey Albershteyn
2026-09-18 11:15 ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-09-18 11:15 ` [PATCH v16 01/21] fsverity: report validation errors through fserror to fsnotify Andrey Albershteyn
2026-09-18 11:15   ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-09-18 11:27   ` sashiko-bot
2026-09-18 11:15 ` [PATCH v16 02/21] fsverity: expose ensure_fsverity_info() Andrey Albershteyn
2026-09-18 11:15   ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-09-18 11:32   ` sashiko-bot
2026-09-18 11:15 ` [PATCH v16 03/21] fsverity: pass digest size and hash of the all-zeroes block to ->write Andrey Albershteyn
2026-09-18 11:15   ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-09-18 11:24   ` sashiko-bot
2026-09-18 11:15 ` [PATCH v16 04/21] fsverity: hoist pagecache_read from f2fs/ext4 to fsverity Andrey Albershteyn
2026-09-18 11:15   ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-09-18 11:26   ` sashiko-bot
2026-09-18 11:15 ` [PATCH v16 05/21] fsverity: don't allow setting DAX file attribute on fsverity files Andrey Albershteyn
2026-09-18 11:15   ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-09-18 11:28   ` sashiko-bot
2026-09-25  4:35   ` Eric Biggers
2026-09-25  4:35     ` [f2fs-dev] " Eric Biggers via Linux-f2fs-devel
2026-09-18 11:15 ` [PATCH v16 06/21] fsverity: hoist statx reporting of fs-verity flag Andrey Albershteyn
2026-09-18 11:15   ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-09-18 11:28   ` sashiko-bot
2026-09-18 11:15 ` [PATCH v16 07/21] xfs: introduce fsverity on-disk changes Andrey Albershteyn
2026-09-18 11:15   ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-09-18 11:34   ` sashiko-bot
2026-09-18 11:15 ` [PATCH v16 08/21] xfs: don't allow to enable DAX on fs-verity sealed inode Andrey Albershteyn
2026-09-18 11:15   ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-09-18 11:27   ` sashiko-bot
2026-09-18 11:15 ` [PATCH v16 09/21] xfs: disable direct read path for fs-verity files Andrey Albershteyn
2026-09-18 11:15   ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-09-18 11:26   ` sashiko-bot
2026-09-18 11:15 ` [PATCH v16 10/21] xfs: don't report dio_mem_align and dio_offset_align for fsverity files Andrey Albershteyn
2026-09-18 11:15   ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-09-18 11:26   ` sashiko-bot
2026-09-18 11:15 ` [PATCH v16 11/21] xfs: handle fsverity I/O in write/read path Andrey Albershteyn
2026-09-18 11:15   ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-09-18 11:38   ` sashiko-bot
2026-09-22  7:15   ` Christoph Hellwig [this message]
2026-09-22  7:15     ` [f2fs-dev] " Christoph Hellwig
2026-09-18 11:15 ` [PATCH v16 12/21] xfs: use read ioend for fsverity data verification Andrey Albershteyn
2026-09-18 11:15   ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-09-18 11:36   ` sashiko-bot
2026-09-22  4:29   ` Darrick J. Wong
2026-09-22  4:29     ` [f2fs-dev] " Darrick J. Wong via Linux-f2fs-devel
2026-09-22  7:18   ` Christoph Hellwig
2026-09-22  7:18     ` [f2fs-dev] " Christoph Hellwig
2026-09-22  9:13     ` Andrey Albershteyn
2026-09-22  9:13       ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-09-22 12:31       ` Christoph Hellwig
2026-09-22 12:31         ` [f2fs-dev] " Christoph Hellwig
2026-09-22 13:17         ` Andrey Albershteyn
2026-09-22 13:17           ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-09-18 11:15 ` [PATCH v16 13/21] xfs: add XFS_BMAPI_UNWRITTEN to unmap unwritten extents in __xfs_bunmapi() Andrey Albershteyn
2026-09-18 11:15   ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-09-18 11:32   ` sashiko-bot
2026-09-22  4:49     ` Darrick J. Wong
2026-09-22  4:34   ` Darrick J. Wong
2026-09-22  4:34     ` [f2fs-dev] " Darrick J. Wong via Linux-f2fs-devel
2026-09-22  7:20     ` Christoph Hellwig
2026-09-22  7:20       ` [f2fs-dev] " Christoph Hellwig
2026-09-22  8:32       ` Andrey Albershteyn
2026-09-22  8:32         ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-09-18 11:15 ` [PATCH v16 14/21] xfs: don't remove written extents past EOF on fsverity inodes Andrey Albershteyn
2026-09-18 11:15   ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-09-18 11:41   ` sashiko-bot
2026-09-22  4:37   ` Darrick J. Wong
2026-09-22  4:37     ` [f2fs-dev] " Darrick J. Wong via Linux-f2fs-devel
2026-09-22  8:33     ` Andrey Albershteyn
2026-09-22  8:33       ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-09-22 11:29       ` Andrey Albershteyn
2026-09-22 11:29         ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-09-18 11:15 ` [PATCH v16 15/21] xfs: add fs-verity support Andrey Albershteyn
2026-09-18 11:15   ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-09-18 11:43   ` sashiko-bot
2026-09-22  4:50     ` Darrick J. Wong
2026-09-22  4:45   ` Darrick J. Wong
2026-09-22  4:45     ` [f2fs-dev] " Darrick J. Wong via Linux-f2fs-devel
2026-09-22  9:27     ` Andrey Albershteyn
2026-09-22  9:27       ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-09-22  7:22   ` Christoph Hellwig
2026-09-22  7:22     ` [f2fs-dev] " Christoph Hellwig
2026-09-22  8:56     ` Andrey Albershteyn
2026-09-22  8:56       ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-09-22 12:32       ` Christoph Hellwig
2026-09-22 12:32         ` [f2fs-dev] " Christoph Hellwig
2026-09-22 13:27         ` Andrey Albershteyn
2026-09-22 13:27           ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-09-23  4:44           ` Christoph Hellwig
2026-09-23  4:44             ` [f2fs-dev] " Christoph Hellwig
2026-09-18 11:15 ` [PATCH v16 16/21] xfs: initialize fs-verity on file open Andrey Albershteyn
2026-09-18 11:15   ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-09-18 11:33   ` sashiko-bot
2026-09-18 11:15 ` [PATCH v16 17/21] xfs: add fs-verity ioctls Andrey Albershteyn
2026-09-18 11:15   ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-09-18 11:31   ` sashiko-bot
2026-09-18 11:15 ` [PATCH v16 18/21] xfs: advertise fs-verity being available on filesystem Andrey Albershteyn
2026-09-18 11:15   ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-09-18 11:30   ` sashiko-bot
2026-09-18 11:15 ` [PATCH v16 19/21] xfs: check and repair the verity inode flag state Andrey Albershteyn
2026-09-18 11:15   ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-09-18 11:40   ` sashiko-bot
2026-09-18 11:15 ` [PATCH v16 20/21] xfs: introduce health state for corrupted fsverity metadata Andrey Albershteyn
2026-09-18 11:15   ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-09-18 11:34   ` sashiko-bot
2026-09-18 11:15 ` [PATCH v16 21/21] xfs: enable ro-compat fs-verity flag Andrey Albershteyn
2026-09-18 11:15   ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-09-18 11:44   ` sashiko-bot
2026-09-22  4:51 ` [PATCH v16 00/21] fs-verity support for XFS with post EOF merkle tree Darrick J. Wong
2026-09-22  4:51   ` [f2fs-dev] " Darrick J. Wong via Linux-f2fs-devel
2026-09-22  9:00   ` Andrey Albershteyn
2026-09-22  9:00     ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=arIrHUj9SMUW6WSD@infradead.org \
    --to=hch@infradead.org \
    --cc=aalbersh@kernel.org \
    --cc=cem@kernel.org \
    --cc=david@fromorbit.com \
    --cc=djwong@kernel.org \
    --cc=ebiggers@kernel.org \
    --cc=fsverity@lists.linux.dev \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-unionfs@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.