[PATCH 0/2] spi: sh-msiof: Add support for R-Car X5H

[PATCH 0/2] spi: sh-msiof: Add support for R-Car X5H

[Geert Uytterhoeven]

	Hi all,

This patch series adds support for the Clock-Synchronized Serial
Interfaces with FIFO (MSIOF) in the Renesas R-Car X5H (R8A78000) SoC,
which is the first member of the R-Car Gen5 family.

It has been tested on the Ironhide development board.
Thanks for your comments!

Geert Uytterhoeven (1):
  spi: sh-msiof: Add support for R-Car Gen5

Thanh Quan (1):
  dt-bindings: spi: renesas,sh-msiof: Add support for R-Car X5H

 .../devicetree/bindings/spi/renesas,sh-msiof.yaml        | 9 +++++++--
 drivers/spi/spi-sh-msiof.c                               | 1 +
 2 files changed, 8 insertions(+), 2 deletions(-)

-- 
2.43.0

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

[PATCH 1/2] dt-bindings: spi: renesas,sh-msiof: Add support for R-Car X5H

[Geert Uytterhoeven]

From: Thanh Quan <thanh.quan.xn@renesas.com>

Document support for Clock-Synchronized Serial Interfaces with FIFO
(MSIOF) in the Renesas R-Car X5H (R8A78000) SoC, which is the first
member of the R-Car Gen5 family.

On R-Car X5H, MSIOF modules are wired to three DMACs, hence increase the
maximum number of DMA channels to six.

Signed-off-by: Thanh Quan <thanh.quan.xn@renesas.com>
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
Changes compared to the BSP:
  - Increase maximum number of DMA channels.
---
 .../devicetree/bindings/spi/renesas,sh-msiof.yaml        | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/spi/renesas,sh-msiof.yaml b/Documentation/devicetree/bindings/spi/renesas,sh-msiof.yaml
index e0c7047ae8adb6c3..41e423a42654d05e 100644
--- a/Documentation/devicetree/bindings/spi/renesas,sh-msiof.yaml
+++ b/Documentation/devicetree/bindings/spi/renesas,sh-msiof.yaml
@@ -54,6 +54,11 @@ properties:
               - renesas,msiof-r8a779h0      # R-Car V4M
           - const: renesas,rcar-gen4-msiof  # generic R-Car Gen4
                                             # compatible device
+      - items:
+          - enum:
+              - renesas,msiof-r8a78000      # R-Car X5H
+          - const: renesas,rcar-gen5-msiof  # generic R-Car Gen5
+                                            # compatible device
       - items:
           - const: renesas,sh-msiof  # deprecated
 
@@ -100,11 +105,11 @@ properties:
 
   dmas:
     minItems: 2
-    maxItems: 4
+    maxItems: 6
 
   dma-names:
     minItems: 2
-    maxItems: 4
+    maxItems: 6
     items:
       enum: [ tx, rx ]
 
-- 
2.43.0

Re: [PATCH 1/2] dt-bindings: spi: renesas,sh-msiof: Add support for R-Car X5H

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dt-bindings: weakened schema validation for older generations' dma counts
--

commit 339efeecd4721be8f1b5b945500191b6aa6436e7
Author: Thanh Quan <thanh.quan.xn@renesas.com>

dt-bindings: spi: renesas,sh-msiof: Add support for R-Car X5H

Document support for Clock-Synchronized Serial Interfaces with FIFO
(MSIOF) in the Renesas R-Car X5H (R8A78000) SoC, which is the first
member of the R-Car Gen5 family.

> diff --git a/Documentation/devicetree/bindings/spi/renesas,sh-msiof.yaml b/Documentation/devicetree/bindings/spi/renesas,sh-msiof.yaml
> index e0c7047ae8adb..41e423a42654d 100644
> --- a/Documentation/devicetree/bindings/spi/renesas,sh-msiof.yaml
> +++ b/Documentation/devicetree/bindings/spi/renesas,sh-msiof.yaml

[ ... ]

> @@ -100,11 +105,11 @@ properties:
>  
>    dmas:
>      minItems: 2
> -    maxItems: 4
> +    maxItems: 6

[Severity: Medium]
Does this unintentionally weaken schema validation for older generations?

By relaxing the global maximum to 6, a device tree for older hardware (which
only supports up to 4 DMAs) could now silently pass validation with an invalid
number of DMA channels.

Should this preserve maxItems: 4 globally and only override it to 6 inside an
allOf: if-then conditional block for the new Gen5 compatible?

>  
>    dma-names:
>      minItems: 2
> -    maxItems: 4
> +    maxItems: 6

[Severity: Medium]
Similarly, does relaxing this limit globally allow older generations to define
more dma-names than supported without generating a validation warning?

>      items:
>        enum: [ tx, rx ]
>

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1790065451.git.geert+renesas@glider.be?part=1

Re: [PATCH 1/2] dt-bindings: spi: renesas,sh-msiof: Add support for R-Car X5H

[Geert Uytterhoeven]

Hi Sashiko,

On Tue, 22 Sept 2026 at 10:33, <sashiko-bot@kernel.org> wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Medium] dt-bindings: weakened schema validation for older generations' dma counts
> --
>
> commit 339efeecd4721be8f1b5b945500191b6aa6436e7
> Author: Thanh Quan <thanh.quan.xn@renesas.com>
>
> dt-bindings: spi: renesas,sh-msiof: Add support for R-Car X5H
>
> Document support for Clock-Synchronized Serial Interfaces with FIFO
> (MSIOF) in the Renesas R-Car X5H (R8A78000) SoC, which is the first
> member of the R-Car Gen5 family.
>
> > diff --git a/Documentation/devicetree/bindings/spi/renesas,sh-msiof.yaml b/Documentation/devicetree/bindings/spi/renesas,sh-msiof.yaml
> > index e0c7047ae8adb..41e423a42654d 100644
> > --- a/Documentation/devicetree/bindings/spi/renesas,sh-msiof.yaml
> > +++ b/Documentation/devicetree/bindings/spi/renesas,sh-msiof.yaml
>
> [ ... ]
>
> > @@ -100,11 +105,11 @@ properties:
> >
> >    dmas:
> >      minItems: 2
> > -    maxItems: 4
> > +    maxItems: 6
>
> [Severity: Medium]
> Does this unintentionally weaken schema validation for older generations?
>
> By relaxing the global maximum to 6, a device tree for older hardware (which
> only supports up to 4 DMAs) could now silently pass validation with an invalid
> number of DMA channels.
>
> Should this preserve maxItems: 4 globally and only override it to 6 inside an
> allOf: if-then conditional block for the new Gen5 compatible?

I wouldn't bother adding further restrictions, as these are not related
to the actual MSIOF block, but to on-SoC wiring.  DMARQ is just a single
signal going from the MSIOF block to one or more DMAC instances.
The number also differs among MSIOF instances on an SoC.

See also my similar replies for rcar-i2c and serial:
https://lore.kernel.org/all/CAMuHMdXj04QoxituCF3wRcyzN7qZrVBn7-ukNkKDd0OfhB8zOQ@mail.gmail.com/
https://lore.kernel.org/all/CAMuHMdVgJkwkoF0-ptQ9g_8E5j1Oa8G41nBiiOfY+KF_p7XAxQ@mail.gmail.com/

Perhaps it would be a good idea to remember this?
Thanks!

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH 1/2] dt-bindings: spi: renesas,sh-msiof: Add support for R-Car X5H

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 611 bytes --]

On Tue, Sep 22, 2026 at 10:27:00AM +0200, Geert Uytterhoeven wrote:
> From: Thanh Quan <thanh.quan.xn@renesas.com>
> 
> Document support for Clock-Synchronized Serial Interfaces with FIFO
> (MSIOF) in the Renesas R-Car X5H (R8A78000) SoC, which is the first
> member of the R-Car Gen5 family.
> 
> On R-Car X5H, MSIOF modules are wired to three DMACs, hence increase the
> maximum number of DMA channels to six.
> 
> Signed-off-by: Thanh Quan <thanh.quan.xn@renesas.com>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH 1/2] dt-bindings: spi: renesas,sh-msiof: Add support for R-Car X5H

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 636 bytes --]

On Tue, Sep 22, 2026 at 10:27:00AM +0200, Geert Uytterhoeven wrote:
> From: Thanh Quan <thanh.quan.xn@renesas.com>
> 
> Document support for Clock-Synchronized Serial Interfaces with FIFO
> (MSIOF) in the Renesas R-Car X5H (R8A78000) SoC, which is the first
> member of the R-Car Gen5 family.

Please submit patches using subject lines reflecting the style for the
subsystem, this makes it easier for people to identify relevant patches.
Look at what existing commits in the area you're changing are doing and
make sure your subject lines visually resemble what they're doing.
There's no need to resubmit to fix this alone.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[PATCH 2/2] spi: sh-msiof: Add support for R-Car Gen5

[Geert Uytterhoeven]

The Clock-Synchronized Serial Interfaces with FIFO (MSIOF) on R-Car Gen5
have FIFOs with 256 entries, just like on R-Car Gen4.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 drivers/spi/spi-sh-msiof.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/spi/spi-sh-msiof.c b/drivers/spi/spi-sh-msiof.c
index 4c425ec627767a46..90a671e9de70ebbb 100644
--- a/drivers/spi/spi-sh-msiof.c
+++ b/drivers/spi/spi-sh-msiof.c
@@ -1016,6 +1016,7 @@ static const struct of_device_id sh_msiof_match[] __maybe_unused = {
 	{ .compatible = "renesas,msiof-r8a779a0",  .data = &rcar_gen3_data },
 	{ .compatible = "renesas,msiof-r8a779f0",  .data = &rcar_gen3_data },
 	{ .compatible = "renesas,rcar-gen4-msiof", .data = &rcar_gen4_data },
+	{ .compatible = "renesas,rcar-gen5-msiof", .data = &rcar_gen4_data },
 	{ .compatible = "renesas,sh-msiof",        .data = &sh_data }, /* Deprecated */
 	{ /* sentinel */ }
 };
-- 
2.43.0

Re: [PATCH 2/2] spi: sh-msiof: Add support for R-Car Gen5

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 335 bytes --]

On Tue, Sep 22, 2026 at 10:27:01AM +0200, Geert Uytterhoeven wrote:
> The Clock-Synchronized Serial Interfaces with FIFO (MSIOF) on R-Car Gen5
> have FIFOs with 256 entries, just like on R-Car Gen4.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH 0/2] spi: sh-msiof: Add support for R-Car X5H

[Mark Brown]

On Tue, 22 Sep 2026 10:26:59 +0200, Geert Uytterhoeven wrote:
> spi: sh-msiof: Add support for R-Car X5H
> 
> 	Hi all,
> 
> This patch series adds support for the Clock-Synchronized Serial
> Interfaces with FIFO (MSIOF) in the Renesas R-Car X5H (R8A78000) SoC,
> which is the first member of the R-Car Gen5 family.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-7.4

Thanks!

[1/2] dt-bindings: spi: renesas,sh-msiof: Add support for R-Car X5H
      https://git.kernel.org/broonie/spi/c/51e04054e299
[2/2] spi: sh-msiof: Add support for R-Car Gen5
      https://git.kernel.org/broonie/spi/c/8157bb8232a4

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark