From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Yonggang Luo <luoyonggang@gmail.com>
Cc: qemu-devel@nongnu.org,
"Philippe Mathieu-Daudé" <philmd@oss.qualcomm.com>,
"Bibo Mao" <maobibo@loongson.cn>,
"Xianglai Li" <lixianglai@loongson.cn>,
"Laurent Vivier" <laurent@vivier.eu>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Chao Liu" <chao.liu@processmission.com>,
qemu-arm@nongnu.org,
"Alistair Francis" <alistair.francis@wdc.com>,
"Laurent Vivier" <lvivier@redhat.com>,
"Pierrick Bouvier" <pierrick.bouvier@oss.qualcomm.com>,
"Weiwei Li" <liwei1518@gmail.com>,
"Daniel Henrique Barboza" <daniel.barboza@oss.qualcomm.com>,
"Zhao Liu" <zhao1.liu@intel.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Fabiano Rosas" <farosas@suse.de>,
"Song Gao" <17746591750@163.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Liu Zhiwei" <zhiwei_liu@linux.alibaba.com>,
qemu-riscv@nongnu.org, "Stafford Horne" <shorne@gmail.com>,
"Brian Cain" <brian.cain@oss.qualcomm.com>,
"Jiaxun Yang" <jiaxun.yang@flygoat.com>,
"Max Filippov" <jcmvbkbc@gmail.com>,
"Philippe Mathieu-Daude" <philmd@mailo.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Eric Blake" <eblake@redhat.com>
Subject: Re: [PATCH v2 9/9] qapi: return MachineInfo typename from query-machines
Date: Wed, 23 Sep 2026 09:33:41 +0100 [thread overview]
Message-ID: <arOO5Vg5wnk8LpcQ@redhat.com> (raw)
In-Reply-To: <20260922215533.641-10-luoyonggang@gmail.com>
On Wed, Sep 23, 2026 at 05:55:32AM +0800, Yonggang Luo wrote:
> query-machines returned only the -M name, so management apps inferred
> the QOM type as that name plus "-machine". A prefixed type such as
> arm-virt-11.1-machine no longer matches -M virt-11.1. Return the QOM
> type in MachineInfo typename from object_class_get_name() in
> qmp_query_machines(). test_query_machines_typename checks that
> qom-list-properties accepts it.
>
> Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
> ---
> hw/core/machine-qmp-cmds.c | 1 +
> qapi/machine.json | 6 +++-
> tests/qtest/qom-test.c | 65 ++++++++++++++++++++++++++++++++++----
> 3 files changed, 65 insertions(+), 7 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com ~~ https://hachyderm.io/@berrange :|
|: https://libvirt.org ~~ https://entangle-photo.org :|
|: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|
next prev parent reply other threads:[~2026-09-23 8:34 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-22 21:55 [PATCH v2 0/9] machine: uniquify virt QOM names Yonggang Luo
2026-09-22 21:55 ` [PATCH v2 1/9] machine: allow -M name to differ from QOM type Yonggang Luo
2026-09-23 5:01 ` Pierrick Bouvier
2026-09-23 5:56 ` Yonggang Luo
2026-09-23 10:56 ` marcandre.lureau
2026-09-22 21:55 ` [PATCH v2 2/9] hw/riscv/virt: use unique QOM name Yonggang Luo
2026-09-23 10:56 ` marcandre.lureau
2026-09-22 21:55 ` [PATCH v2 3/9] hw/arm/virt: " Yonggang Luo
2026-09-23 10:56 ` marcandre.lureau
2026-09-22 21:55 ` [PATCH v2 4/9] hw/or1k/virt: " Yonggang Luo
2026-09-23 10:56 ` marcandre.lureau
2026-09-22 21:55 ` [PATCH v2 5/9] hw/hexagon/virt: " Yonggang Luo
2026-09-23 10:56 ` marcandre.lureau
2026-09-22 21:55 ` [PATCH v2 6/9] hw/loongarch/virt: " Yonggang Luo
2026-09-23 10:56 ` marcandre.lureau
2026-09-22 21:55 ` [PATCH v2 7/9] hw/m68k/virt: " Yonggang Luo
2026-09-23 10:56 ` marcandre.lureau
2026-09-22 21:55 ` [PATCH v2 8/9] hw/xtensa/virt: " Yonggang Luo
2026-09-23 10:56 ` marcandre.lureau
2026-09-22 21:55 ` [PATCH v2 9/9] qapi: return MachineInfo typename from query-machines Yonggang Luo
2026-09-23 8:33 ` Daniel P. Berrangé [this message]
2026-09-23 10:56 ` marcandre.lureau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=arOO5Vg5wnk8LpcQ@redhat.com \
--to=berrange@redhat.com \
--cc=17746591750@163.com \
--cc=alistair.francis@wdc.com \
--cc=armbru@redhat.com \
--cc=brian.cain@oss.qualcomm.com \
--cc=chao.liu@processmission.com \
--cc=daniel.barboza@oss.qualcomm.com \
--cc=eblake@redhat.com \
--cc=farosas@suse.de \
--cc=jcmvbkbc@gmail.com \
--cc=jiaxun.yang@flygoat.com \
--cc=laurent@vivier.eu \
--cc=liwei1518@gmail.com \
--cc=lixianglai@loongson.cn \
--cc=luoyonggang@gmail.com \
--cc=lvivier@redhat.com \
--cc=maobibo@loongson.cn \
--cc=palmer@dabbelt.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@mailo.com \
--cc=philmd@oss.qualcomm.com \
--cc=pierrick.bouvier@oss.qualcomm.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=shorne@gmail.com \
--cc=zhao1.liu@intel.com \
--cc=zhiwei_liu@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.