From: Mehdi Djait <mehdi.djait@linux.intel.com>
To: Amin Gattout <amin.gattout@gmail.com>
Cc: Michael Riesch <michael.riesch@collabora.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Heiko Stuebner <heiko@sntech.de>,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/5] media: rockchip: rkcif: add a register index for the MIPI capture size
Date: Wed, 23 Sep 2026 16:52:29 +0200 [thread overview]
Message-ID: <arPnhGHzFiWOtzfi@mdjait-mobl> (raw)
In-Reply-To: <20260921-vicap-rk3576-v2-2-0a4582e20c72@gmail.com>
Hello Amin,
Thank you for the patch!
On Mon, Sep 21, 2026 at 05:29:58PM +0200, Amin Gattout wrote:
> The RK3568 and RK3588 variants configure the MIPI capture size in the
> ID_CTRL1 register. The RK3576 has a dedicated ID_SET_SIZE register
> instead.
>
> Add a register index for the capture size and write it through that
> index, in preparation for the RK3576 support. The RK3568 and RK3588
> mark the index as unsupported, so the write is a no operation for them
> and their behavior is unchanged.
>
Reviewed-by: Mehdi Djait <mehdi.djait@linux.intel.com>
> Signed-off-by: Amin Gattout <amin.gattout@gmail.com>
--
Kind Regards
Mehdi Djait
WARNING: multiple messages have this Message-ID (diff)
From: Mehdi Djait <mehdi.djait@linux.intel.com>
To: Amin Gattout <amin.gattout@gmail.com>
Cc: Michael Riesch <michael.riesch@collabora.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Heiko Stuebner <heiko@sntech.de>,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/5] media: rockchip: rkcif: add a register index for the MIPI capture size
Date: Wed, 23 Sep 2026 16:52:29 +0200 [thread overview]
Message-ID: <arPnhGHzFiWOtzfi@mdjait-mobl> (raw)
In-Reply-To: <20260921-vicap-rk3576-v2-2-0a4582e20c72@gmail.com>
Hello Amin,
Thank you for the patch!
On Mon, Sep 21, 2026 at 05:29:58PM +0200, Amin Gattout wrote:
> The RK3568 and RK3588 variants configure the MIPI capture size in the
> ID_CTRL1 register. The RK3576 has a dedicated ID_SET_SIZE register
> instead.
>
> Add a register index for the capture size and write it through that
> index, in preparation for the RK3576 support. The RK3568 and RK3588
> mark the index as unsupported, so the write is a no operation for them
> and their behavior is unchanged.
>
Reviewed-by: Mehdi Djait <mehdi.djait@linux.intel.com>
> Signed-off-by: Amin Gattout <amin.gattout@gmail.com>
--
Kind Regards
Mehdi Djait
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2026-09-23 14:52 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-21 15:29 [PATCH v2 0/5] media: rockchip: add support for the RK3576 Video Capture unit Amin Gattout
2026-09-21 15:29 ` Amin Gattout
2026-09-21 15:29 ` [PATCH v2 1/5] media: dt-bindings: add rockchip rk3576 vicap Amin Gattout
2026-09-21 15:29 ` Amin Gattout
2026-09-23 14:51 ` Mehdi Djait
2026-09-23 14:51 ` Mehdi Djait
2026-09-21 15:29 ` [PATCH v2 2/5] media: rockchip: rkcif: add a register index for the MIPI capture size Amin Gattout
2026-09-21 15:29 ` Amin Gattout
2026-09-23 14:52 ` Mehdi Djait [this message]
2026-09-23 14:52 ` Mehdi Djait
2026-10-01 15:24 ` Michael Riesch
2026-10-01 15:24 ` Michael Riesch
2026-09-21 15:29 ` [PATCH v2 3/5] media: rockchip: rkcif: add a callback for the MIPI ID_CTRL1 register Amin Gattout
2026-09-21 15:29 ` Amin Gattout
2026-09-23 14:53 ` Mehdi Djait
2026-09-23 14:53 ` Mehdi Djait
2026-10-01 15:27 ` Michael Riesch
2026-10-01 15:27 ` Michael Riesch
2026-09-21 15:30 ` [PATCH v2 4/5] media: rockchip: rkcif: add support for rk3576 vicap mipi capture Amin Gattout
2026-09-21 15:30 ` Amin Gattout
2026-09-23 14:55 ` Mehdi Djait
2026-09-23 14:55 ` Mehdi Djait
2026-10-01 15:30 ` Michael Riesch
2026-10-01 15:30 ` Michael Riesch
2026-09-21 15:30 ` [PATCH v2 5/5] arm64: dts: rockchip: add vicap node to rk3576 Amin Gattout
2026-09-21 15:30 ` Amin Gattout
2026-09-23 14:56 ` Mehdi Djait
2026-09-23 14:56 ` Mehdi Djait
2026-09-23 14:35 ` [PATCH v2 0/5] media: rockchip: add support for the RK3576 Video Capture unit Mehdi Djait
2026-09-23 14:35 ` Mehdi Djait
2026-10-05 19:06 ` (subset) " Heiko Stuebner
2026-10-05 19:06 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=arPnhGHzFiWOtzfi@mdjait-mobl \
--to=mehdi.djait@linux.intel.com \
--cc=amin.gattout@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mchehab@kernel.org \
--cc=michael.riesch@collabora.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.