[PATCH] rust: fix typo in bindings

[PATCH] rust: fix typo in bindings

[Lorenzo Stoakes]

Commit 2b6a3f061f11 ("mm: declare VMA flags by bit") added a number of
overrides to the rust bindings helper as the change performed in the commit
caused the rust binder to not be able to automatically determine values of
VMA flags.

However a typo was introduced leaving VM_MAYSHARE to be incorrectly
interpreted as VM_MAYEXEC in rust code. This patch fixes the typo.

Fixes: 2b6a3f061f11 ("mm: declare VMA flags by bit")
Reported-by: Chris Mason <clm@meta.com>
Closes: https://lore.kernel.org/all/20260113185142.254821-1-clm@meta.com/
Cc: <stable@vger.kernel.org>
Signed-off-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
---
 rust/bindings/bindings_helper.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/rust/bindings/bindings_helper.h b/rust/bindings/bindings_helper.h
index a067038b4b42..25a8f24f292a 100644
--- a/rust/bindings/bindings_helper.h
+++ b/rust/bindings/bindings_helper.h
@@ -126,7 +126,7 @@ const vm_flags_t RUST_CONST_HELPER_VM_SHARED = VM_SHARED;
 const vm_flags_t RUST_CONST_HELPER_VM_MAYREAD = VM_MAYREAD;
 const vm_flags_t RUST_CONST_HELPER_VM_MAYWRITE = VM_MAYWRITE;
 const vm_flags_t RUST_CONST_HELPER_VM_MAYEXEC = VM_MAYEXEC;
-const vm_flags_t RUST_CONST_HELPER_VM_MAYSHARE = VM_MAYEXEC;
+const vm_flags_t RUST_CONST_HELPER_VM_MAYSHARE = VM_MAYSHARE;
 const vm_flags_t RUST_CONST_HELPER_VM_PFNMAP = VM_PFNMAP;
 const vm_flags_t RUST_CONST_HELPER_VM_IO = VM_IO;
 const vm_flags_t RUST_CONST_HELPER_VM_DONTCOPY = VM_DONTCOPY;
--
2.52.0

Re: [PATCH] rust: fix typo in bindings

[Alice Ryhl]

On Tue, Jan 13, 2026 at 8:30 PM Lorenzo Stoakes
<lorenzo.stoakes@oracle.com> wrote:
>
> Commit 2b6a3f061f11 ("mm: declare VMA flags by bit") added a number of
> overrides to the rust bindings helper as the change performed in the commit
> caused the rust binder to not be able to automatically determine values of
> VMA flags.
>
> However a typo was introduced leaving VM_MAYSHARE to be incorrectly
> interpreted as VM_MAYEXEC in rust code. This patch fixes the typo.
>
> Fixes: 2b6a3f061f11 ("mm: declare VMA flags by bit")
> Reported-by: Chris Mason <clm@meta.com>
> Closes: https://lore.kernel.org/all/20260113185142.254821-1-clm@meta.com/
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>

Reviewed-by: Alice Ryhl <aliceryhl@google.com>

Re: [PATCH] rust: fix typo in bindings

[wang lian]

>
> Commit 2b6a3f061f11 ("mm: declare VMA flags by bit") added a number of
> overrides to the rust bindings helper as the change performed in the commit
> caused the rust binder to not be able to automatically determine values of
> VMA flags.
>
> However a typo was introduced leaving VM_MAYSHARE to be incorrectly
> interpreted as VM_MAYEXEC in rust code. This patch fixes the typo.
>
> Fixes: 2b6a3f061f11 ("mm: declare VMA flags by bit")
> Reported-by: Chris Mason <clm@meta.com>
> Closes: https://lore.kernel.org/all/20260113185142.254821-1-clm@meta.com/
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>

LGTM.

Reviewed-by: wang lian <lianux.mm@gmail.com>

--
Best Regards,
wang lian

Re: [PATCH] rust: fix typo in bindings

[Gary Guo]

On Tue Jan 13, 2026 at 7:29 PM GMT, Lorenzo Stoakes wrote:
> Commit 2b6a3f061f11 ("mm: declare VMA flags by bit") added a number of
> overrides to the rust bindings helper as the change performed in the commit
> caused the rust binder to not be able to automatically determine values of
> VMA flags.
> 
> However a typo was introduced leaving VM_MAYSHARE to be incorrectly
> interpreted as VM_MAYEXEC in rust code. This patch fixes the typo.
> 
> Fixes: 2b6a3f061f11 ("mm: declare VMA flags by bit")
> Reported-by: Chris Mason <clm@meta.com>
> Closes: https://lore.kernel.org/all/20260113185142.254821-1-clm@meta.com/
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>

Reviewed-by: Gary Guo <gary@garyguo.net>

> ---
>  rust/bindings/bindings_helper.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH] rust: fix typo in bindings

[Chunfeng Song]

Hi Lorenzo,

This does not appear to have been picked up -- torvalds/master still carries
the typo as of 238650ef6c7c.

I ran into it while auditing a Rust driver port, and can add a couple of data
points that may help judge whether it is worth taking:

  - rust/bindings/bindings_helper.h is architecture independent, so this is
    not specific to one configuration or architecture: both the arm64 and the
    x86 bindings publish the wrong value.

  - It is observable end to end. bindings_generated.rs contains

        pub const VM_MAYSHARE: vm_flags_t = 64;

    which is VM_MAYEXEC (bit 6), while include/linux/mm.h has
    DECLARE_VMA_BIT(MAYSHARE, 7), i.e. 128. Asking the C compiler directly,
    with a driver's own flags, returns VM_MAYSHARE == 128 as well. So any Rust
    code reading bindings::VM_MAYSHARE silently gets VM_MAYEXEC instead.

Since the fix already has three Reviewed-by tags, I assume it just fell
through the cracks. Would a resend help? I am happy to send one -- I just did
not want to post a duplicate of your patch without checking with you first.

Thanks,
Chunfeng

Re: [PATCH] rust: fix typo in bindings

[Miguel Ojeda]

On Thu, Sep 17, 2026 at 6:15 AM Chunfeng Song
<springbreeze@stu.pku.edu.cn> wrote:
>
> Since the fix already has three Reviewed-by tags, I assume it just fell
> through the cracks. Would a resend help? I am happy to send one -- I just did
> not want to post a duplicate of your patch without checking with you first.

I am happy to pick it up as well.

Cheers,
Miguel

Re: [PATCH] rust: fix typo in bindings

[Miguel Ojeda]

On Sun, Sep 20, 2026 at 10:54 PM Miguel Ojeda
<miguel.ojeda.sandonis@gmail.com> wrote:
>
> On Thu, Sep 17, 2026 at 6:15 AM Chunfeng Song
> <springbreeze@stu.pku.edu.cn> wrote:
> >
> > Since the fix already has three Reviewed-by tags, I assume it just fell
> > through the cracks. Would a resend help? I am happy to send one -- I just did
> > not want to post a duplicate of your patch without checking with you first.
>
> I am happy to pick it up as well.

Cc'ing new addresses for you since I got some bounces -- hopefully that helps :)

Cheers,
Miguel

Re: [PATCH] rust: fix typo in bindings

[Alice Ryhl]

On Sun, Sep 20, 2026 at 10:13:41PM +0100, Miguel Ojeda wrote:
> On Sun, Sep 20, 2026 at 10:54 PM Miguel Ojeda
> <miguel.ojeda.sandonis@gmail.com> wrote:
> >
> > On Thu, Sep 17, 2026 at 6:15 AM Chunfeng Song
> > <springbreeze@stu.pku.edu.cn> wrote:
> > >
> > > Since the fix already has three Reviewed-by tags, I assume it just fell
> > > through the cracks. Would a resend help? I am happy to send one -- I just did
> > > not want to post a duplicate of your patch without checking with you first.
> >
> > I am happy to pick it up as well.
> 
> Cc'ing new addresses for you since I got some bounces -- hopefully that helps :)

It'd be fine if you took it, thanks.

Alice

Re: [PATCH] rust: fix typo in bindings

[Miguel Ojeda]

On Tue, Jan 13, 2026 at 8:30 PM Lorenzo Stoakes
<lorenzo.stoakes@oracle.com> wrote:
>
> Commit 2b6a3f061f11 ("mm: declare VMA flags by bit") added a number of
> overrides to the rust bindings helper as the change performed in the commit
> caused the rust binder to not be able to automatically determine values of
> VMA flags.
>
> However a typo was introduced leaving VM_MAYSHARE to be incorrectly
> interpreted as VM_MAYEXEC in rust code. This patch fixes the typo.
>
> Fixes: 2b6a3f061f11 ("mm: declare VMA flags by bit")
> Reported-by: Chris Mason <clm@meta.com>
> Closes: https://lore.kernel.org/all/20260113185142.254821-1-clm@meta.com/
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>

Applied to `rust-next` since it doesn't seem urgent, thanks.

    [ Reworded to improve title and to fix typo. - Miguel ]

We also have a similar typo in the `bindgen` flags -- just sent a
patch to go on top of this one:

  https://lore.kernel.org/rust-for-linux/20260930123645.302318-1-ojeda@kernel.org/

Cheers,
Miguel

Re: [PATCH] rust: fix typo in bindings

[Miguel Ojeda]

On Wed, Sep 30, 2026 at 2:39 PM Miguel Ojeda
<miguel.ojeda.sandonis@gmail.com> wrote:
>
> On Tue, Jan 13, 2026 at 8:30 PM Lorenzo Stoakes
> <lorenzo.stoakes@oracle.com> wrote:
> >
> > Commit 2b6a3f061f11 ("mm: declare VMA flags by bit") added a number of
> > overrides to the rust bindings helper as the change performed in the commit
> > caused the rust binder to not be able to automatically determine values of
> > VMA flags.
> >
> > However a typo was introduced leaving VM_MAYSHARE to be incorrectly
> > interpreted as VM_MAYEXEC in rust code. This patch fixes the typo.
> >
> > Fixes: 2b6a3f061f11 ("mm: declare VMA flags by bit")
> > Reported-by: Chris Mason <clm@meta.com>
> > Closes: https://lore.kernel.org/all/20260113185142.254821-1-clm@meta.com/
> > Cc: <stable@vger.kernel.org>
> > Signed-off-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
>
> Applied to `rust-next` since it doesn't seem urgent, thanks.
>
>     [ Reworded to improve title and to fix typo. - Miguel ]
>
> We also have a similar typo in the `bindgen` flags -- just sent a
> patch to go on top of this one:
>
>   https://lore.kernel.org/rust-for-linux/20260930123645.302318-1-ojeda@kernel.org/

Cc'ing the new (kernel.org) addresses of Chris and Lorenzo since I got a bounce.

Cheers,
Miguel