* [PATCH v1] tools include: Add missing stdarg.h include
@ 2026-09-17 4:04 Ian Rogers
2026-09-17 4:06 ` sashiko-bot
2026-09-19 6:42 ` Namhyung Kim
0 siblings, 2 replies; 4+ messages in thread
From: Ian Rogers @ 2026-09-17 4:04 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo, Namhyung Kim, Jiri Olsa, Ian Rogers,
Adrian Hunter, James Clark, linux-perf-users, linux-kernel
Cc: sashiko-bot
Header file makes use of varargs but doesn't directly include stdarg.h.
Reported-by: sashiko-bot@kernel.org
Closes: https://lore.kernel.org/linux-perf-users/20260916062233.192271F000FF@smtp.kernel.org/
Signed-off-by: Ian Rogers <irogers@google.com>
---
tools/include/tools/dis-asm-compat.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/include/tools/dis-asm-compat.h b/tools/include/tools/dis-asm-compat.h
index 70f331e23ed3..1e0586d8451b 100644
--- a/tools/include/tools/dis-asm-compat.h
+++ b/tools/include/tools/dis-asm-compat.h
@@ -2,6 +2,7 @@
#ifndef _TOOLS_DIS_ASM_COMPAT_H
#define _TOOLS_DIS_ASM_COMPAT_H
+#include <stdarg.h>
#include <stdio.h>
#include <dis-asm.h>
--
2.55.0.1082.g2b9226bbc0-goog
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v1] tools include: Add missing stdarg.h include
2026-09-17 4:04 [PATCH v1] tools include: Add missing stdarg.h include Ian Rogers
@ 2026-09-17 4:06 ` sashiko-bot
2026-09-19 6:42 ` Namhyung Kim
1 sibling, 0 replies; 4+ messages in thread
From: sashiko-bot @ 2026-09-17 4:06 UTC (permalink / raw)
To: Ian Rogers; +Cc: linux-perf-users
> Header file makes use of varargs but doesn't directly include stdarg.h.
>
> Reported-by: sashiko-bot@kernel.org
> Closes: https://lore.kernel.org/linux-perf-users/20260916062233.192271F000FF@smtp.kernel.org/
> Signed-off-by: Ian Rogers <irogers@google.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260917040454.32916-1-irogers@google.com?part=1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1] tools include: Add missing stdarg.h include
2026-09-17 4:04 [PATCH v1] tools include: Add missing stdarg.h include Ian Rogers
2026-09-17 4:06 ` sashiko-bot
@ 2026-09-19 6:42 ` Namhyung Kim
2026-09-25 13:05 ` Arnaldo Carvalho de Melo
1 sibling, 1 reply; 4+ messages in thread
From: Namhyung Kim @ 2026-09-19 6:42 UTC (permalink / raw)
To: Ian Rogers
Cc: Arnaldo Carvalho de Melo, Jiri Olsa, Adrian Hunter, James Clark,
linux-perf-users, linux-kernel, sashiko-bot
On Wed, Sep 16, 2026 at 09:04:54PM -0700, Ian Rogers wrote:
> Header file makes use of varargs but doesn't directly include stdarg.h.
>
> Reported-by: sashiko-bot@kernel.org
> Closes: https://lore.kernel.org/linux-perf-users/20260916062233.192271F000FF@smtp.kernel.org/
> Signed-off-by: Ian Rogers <irogers@google.com>
Acked-by: Namhyung Kim <namhyung@kernel.org>
Thanks,
Namhyung
> ---
> tools/include/tools/dis-asm-compat.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/include/tools/dis-asm-compat.h b/tools/include/tools/dis-asm-compat.h
> index 70f331e23ed3..1e0586d8451b 100644
> --- a/tools/include/tools/dis-asm-compat.h
> +++ b/tools/include/tools/dis-asm-compat.h
> @@ -2,6 +2,7 @@
> #ifndef _TOOLS_DIS_ASM_COMPAT_H
> #define _TOOLS_DIS_ASM_COMPAT_H
>
> +#include <stdarg.h>
> #include <stdio.h>
> #include <dis-asm.h>
>
> --
> 2.55.0.1082.g2b9226bbc0-goog
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1] tools include: Add missing stdarg.h include
2026-09-19 6:42 ` Namhyung Kim
@ 2026-09-25 13:05 ` Arnaldo Carvalho de Melo
0 siblings, 0 replies; 4+ messages in thread
From: Arnaldo Carvalho de Melo @ 2026-09-25 13:05 UTC (permalink / raw)
To: Namhyung Kim
Cc: Ian Rogers, Jiri Olsa, Adrian Hunter, James Clark,
linux-perf-users, linux-kernel, sashiko-bot
On Fri, Sep 18, 2026 at 11:42:30PM -0700, Namhyung Kim wrote:
> On Wed, Sep 16, 2026 at 09:04:54PM -0700, Ian Rogers wrote:
> > Header file makes use of varargs but doesn't directly include stdarg.h.
> >
> > Reported-by: sashiko-bot@kernel.org
> > Closes: https://lore.kernel.org/linux-perf-users/20260916062233.192271F000FF@smtp.kernel.org/
> > Signed-off-by: Ian Rogers <irogers@google.com>
>
> Acked-by: Namhyung Kim <namhyung@kernel.org>
Thanks, applied to perf-tools-next, for v7.4.
- Arnaldo
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-09-25 13:05 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-17 4:04 [PATCH v1] tools include: Add missing stdarg.h include Ian Rogers
2026-09-17 4:06 ` sashiko-bot
2026-09-19 6:42 ` Namhyung Kim
2026-09-25 13:05 ` Arnaldo Carvalho de Melo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.