All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: longlong yan <yanlonglong@kylinos.cn>
Cc: namhyung@kernel.org, mark.rutland@arm.com,
	alexander.shishkin@linux.intel.com, jolsa@kernel.org,
	irogers@google.com, adrian.hunter@intel.com,
	james.clark@linaro.org, linux-perf-users@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf bench numa: add NULL check after calloc()
Date: Fri, 25 Sep 2026 16:27:59 +0200	[thread overview]
Message-ID: <araE77-hIcOcWLdq@x2> (raw)
In-Reply-To: <20260902070913.1424-1-yanlonglong@kylinos.cn>

On Wed, Sep 02, 2026 at 03:09:13PM +0800, longlong yan wrote:
> Two calloc() calls in the numa benchmark lack NULL return checks,
> leading to potential NULL pointer dereferences on allocation failure:
> 
> 1. worker_process(): the allocated `pthreads` array is used in the
>    following for-loop via pthreads[t] without checking for NULL.
> 
> 2. __bench_numa(): the allocated `pids` array is used in the following
>    for-loop via pids[i] without checking for NULL.
> 
> Add BUG_ON() checks after each calloc(), consistent with the existing
> NULL check style used elsewhere in the same file (e.g., node_present
> and nodes allocations).

Thanks, applied to perf-tools-next, for v7.4.

- Arnaldo

      parent reply	other threads:[~2026-09-25 14:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-02  7:09 [PATCH] perf bench numa: add NULL check after calloc() longlong yan
2026-09-02  7:15 ` sashiko-bot
2026-09-25 14:27 ` Arnaldo Carvalho de Melo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=araE77-hIcOcWLdq@x2 \
    --to=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=irogers@google.com \
    --cc=james.clark@linaro.org \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=namhyung@kernel.org \
    --cc=yanlonglong@kylinos.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.