From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Pierrick Bouvier <pierrick.bouvier@oss.qualcomm.com>
Cc: qemu-devel@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@oss.qualcomm.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Alex Bennée" <alex.bennee@linaro.org>
Subject: Re: [PATCH 1/4] tests/tcg/meson.build: report correct cc in summary
Date: Fri, 25 Sep 2026 17:02:09 +0100 [thread overview]
Message-ID: <arabAT_nldBmIODk@redhat.com> (raw)
In-Reply-To: <20260924213942.26491-2-pierrick.bouvier@oss.qualcomm.com>
On Thu, Sep 24, 2026 at 09:39:39PM +0000, Pierrick Bouvier wrote:
> Summary didn't consider that cc could have been set using --cross-cc*
> options, and was wrongly reporting default cc declared in test suite.
> Fix that by reporting path of compiler found.
>
> Signed-off-by: Pierrick Bouvier <pierrick.bouvier@oss.qualcomm.com>
> ---
> tests/tcg/meson.build | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/tests/tcg/meson.build b/tests/tcg/meson.build
> index 474e4d8f6e3..0006d192cab 100644
> --- a/tests/tcg/meson.build
> +++ b/tests/tcg/meson.build
> @@ -292,9 +292,10 @@ foreach target, plan: tcg_tests
>
> summary_cc = false
> if has_cc
> - summary_cc = plan['cc']
> - if not cc_from_system
> - summary_cc += ' (from \'qemu/' + plan['cc_dockerfile'] + '\' container)'
> + if cc_from_system
> + summary_cc = cc.full_path()
> + else
> + summary_cc = plan['cc'] + ' (from \'qemu/' + plan['cc_dockerfile'] + '\' container)'
> endif
> endif
> tcg_tests_summary += {'cc for ' + target: summary_cc}
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com ~~ https://hachyderm.io/@berrange :|
|: https://libvirt.org ~~ https://entangle-photo.org :|
|: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|
next prev parent reply other threads:[~2026-09-25 16:03 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-24 21:39 [PATCH 0/4] tests/tcg/meson.build: detect additional cross compilers Pierrick Bouvier
2026-09-24 21:39 ` [PATCH 1/4] tests/tcg/meson.build: report correct cc in summary Pierrick Bouvier
2026-09-25 16:02 ` Daniel P. Berrangé [this message]
2026-09-24 21:39 ` [PATCH 2/4] tests/tcg/meson.build: introduce cc_alt (alternative cross compiler) Pierrick Bouvier
2026-09-25 9:38 ` Daniel P. Berrangé
2026-09-25 15:17 ` Pierrick Bouvier
2026-09-25 15:52 ` Daniel P. Berrangé
2026-09-25 16:03 ` Daniel P. Berrangé
2026-09-24 21:39 ` [PATCH 3/4] tests/tcg: add alternative cross-compilers for fedora Pierrick Bouvier
2026-09-25 9:40 ` Daniel P. Berrangé
2026-09-25 15:20 ` Pierrick Bouvier
2026-09-25 15:54 ` Daniel P. Berrangé
2026-09-25 15:57 ` Pierrick Bouvier
2026-09-25 16:00 ` Daniel P. Berrangé
2026-09-25 16:03 ` Daniel P. Berrangé
2026-09-24 21:39 ` [PATCH 4/4] tests/tcg: add alternative cross-compilers for macos (homebrew) Pierrick Bouvier
2026-09-25 16:04 ` Daniel P. Berrangé
2026-09-25 22:17 ` [PATCH 0/4] tests/tcg/meson.build: detect additional cross compilers Pierrick Bouvier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=arabAT_nldBmIODk@redhat.com \
--to=berrange@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=pbonzini@redhat.com \
--cc=philmd@oss.qualcomm.com \
--cc=pierrick.bouvier@oss.qualcomm.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.