All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] package/wireshark: fix support for lua
@ 2026-09-28  7:42 Francois Perrad
  2026-09-28  8:42 ` Thomas Petazzoni via buildroot
  0 siblings, 1 reply; 3+ messages in thread
From: Francois Perrad @ 2026-09-28  7:42 UTC (permalink / raw)
  To: buildroot; +Cc: Francois Perrad

since 4.4.0, support for Lua 5.3 and 5.4 has been added,
and support for Lua 5.1 and 5.2 has been removed.
see https://www.wireshark.org/docs/relnotes/wireshark-4.4.0.html

Signed-off-by: Francois Perrad <francois.perrad.86@gmail.com>
---
 package/wireshark/wireshark.mk | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/package/wireshark/wireshark.mk b/package/wireshark/wireshark.mk
index c500a4933..ecf9429a5 100644
--- a/package/wireshark/wireshark.mk
+++ b/package/wireshark/wireshark.mk
@@ -109,8 +109,7 @@ else
 WIRESHARK_CONF_OPTS += -DENABLE_LIBXML2=OFF
 endif
 
-# no support for lua53 yet
-ifeq ($(BR2_PACKAGE_LUA_5_1),y)
+ifeq ($(BR2_PACKAGE_LUA_5_3)$(BR2_PACKAGE_LUA_5_4),y)
 WIRESHARK_CONF_OPTS += -DENABLE_LUA=ON
 WIRESHARK_DEPENDENCIES += lua
 else
-- 
2.43.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [Buildroot] [PATCH] package/wireshark: fix support for lua
  2026-09-28  7:42 [Buildroot] [PATCH] package/wireshark: fix support for lua Francois Perrad
@ 2026-09-28  8:42 ` Thomas Petazzoni via buildroot
  2026-09-28 11:23   ` François PERRAD
  0 siblings, 1 reply; 3+ messages in thread
From: Thomas Petazzoni via buildroot @ 2026-09-28  8:42 UTC (permalink / raw)
  To: Francois Perrad; +Cc: buildroot

On Mon, Sep 28, 2026 at 09:42:38AM +0200, Francois Perrad wrote:
> since 4.4.0, support for Lua 5.3 and 5.4 has been added,
> and support for Lua 5.1 and 5.2 has been removed.
> see https://www.wireshark.org/docs/relnotes/wireshark-4.4.0.html

Is this fixing a build issue?

I did a build locally, and I see cmake taking 100% CPU time at the
step:

-- Considering the following Lua versions: 5.4;5.3

is this what you are seeing as well?

Since this is a fix, please add a reference to the Buildroot commit
being fixed:

Fixes: 49fa20e6678ee32e4b26979f5cb4d149876fbedd ("package/wireshark: bump to latest upstream stable v4.4.9")

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Buildroot] [PATCH] package/wireshark: fix support for lua
  2026-09-28  8:42 ` Thomas Petazzoni via buildroot
@ 2026-09-28 11:23   ` François PERRAD
  0 siblings, 0 replies; 3+ messages in thread
From: François PERRAD @ 2026-09-28 11:23 UTC (permalink / raw)
  To: Thomas Petazzoni; +Cc: buildroot


[-- Attachment #1.1: Type: text/plain, Size: 1125 bytes --]

Le lun. 28 sept. 2026 à 10:42, Thomas Petazzoni <
thomas.petazzoni@bootlin.com> a écrit :

> On Mon, Sep 28, 2026 at 09:42:38AM +0200, Francois Perrad wrote:
> > since 4.4.0, support for Lua 5.3 and 5.4 has been added,
> > and support for Lua 5.1 and 5.2 has been removed.
> > see https://www.wireshark.org/docs/relnotes/wireshark-4.4.0.html
>
> Is this fixing a build issue?
>
> I did a build locally, and I see cmake taking 100% CPU time at the
> step:
>
> -- Considering the following Lua versions: 5.4;5.3
>
> is this what you are seeing as well?
>
>
I see the same problem.
But, I found nothing in autobuilder outputs.
If the autobuilder uses only the default version for Lua (ie. 5.4), it
cannot show this issue.

François


> Since this is a fix, please add a reference to the Buildroot commit
> being fixed:
>
> Fixes: 49fa20e6678ee32e4b26979f5cb4d149876fbedd ("package/wireshark: bump
> to latest upstream stable v4.4.9")
>
> Thanks!
>
> Thomas
> --
> Thomas Petazzoni, co-owner and CEO, Bootlin
> Embedded Linux and Kernel engineering and training
> https://bootlin.com
>

[-- Attachment #1.2: Type: text/html, Size: 1913 bytes --]

[-- Attachment #2: Type: text/plain, Size: 150 bytes --]

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-09-28 11:23 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-28  7:42 [Buildroot] [PATCH] package/wireshark: fix support for lua Francois Perrad
2026-09-28  8:42 ` Thomas Petazzoni via buildroot
2026-09-28 11:23   ` François PERRAD

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.