All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anders Roxell <anders.roxell@linaro.org>
To: Siddharth Vadapalli <s-vadapalli@ti.com>
Cc: Anshul Dalal <anshuld@ti.com>,
	u-boot@lists.u-boot-project.org, marek.vasut@mailbox.org,
	trini@konsulko.com, ilias.apalodimas@linaro.org,
	michal.simek@amd.com, lukma@denx.de, alchark@flipper.net,
	jerome.forissier@arm.com, dlechner@baylibre.com,
	sjg@chromium.org, Thinh.Nguyen@synopsys.com,
	mkorpershoek@kernel.org, love.kumar@amd.com, c-vankar@ti.com
Subject: Re: [PATCH v9 00/26] usb: dwc3: part 2, make the resynced code work
Date: Tue, 29 Sep 2026 12:07:20 +0200	[thread overview]
Message-ID: <aruN2OLSSnntkyrn@monster> (raw)
In-Reply-To: <4ca2f00c-9083-4d0e-be76-1465042849ae@ti.com>

On 2026-09-25 16:09, Siddharth Vadapalli wrote:

[...]

> I didn't see "unknown endpoint event 0" at that point, so this series seems
> to introduce a regression.

Hi Siddharth,

Thanks for looking. But that line can not show up on mainline.
dwc3_ep0_interrupt() has no default case there, so an event 0 on ep0
is dropped and nothing is printed. The dev_err() came with the resync
from Linux. So your logs do not tell us if the event is new.

To know if it is a regression we need the same print on both. Can you
run ums on AM62p twice, once on plain master and once with my series,
and send me what it prints?

On plain master:

  --- a/drivers/usb/dwc3/ep0.c
  +++ b/drivers/usb/dwc3/ep0.c
  @@ void dwc3_ep0_interrupt(struct dwc3 *dwc,
   	case DWC3_DEPEVT_EPCMDCMPLT:
   		break;
  +	default:
  +		printf("unknown ep0 event %d raw %08x\n",
  +		       event->endpoint_event, *(const u32 *)event);
  +		break;
   	}
   }

With my series:

  --- a/drivers/usb/dwc3/ep0.c
  +++ b/drivers/usb/dwc3/ep0.c
  @@ void dwc3_ep0_interrupt(struct dwc3 *dwc,
   	default:
   		dev_err(dwc->dev, "unknown endpoint event %d\n", event->endpoint_event);
  +		printf("unknown ep0 event %d raw %08x\n",
  +		       event->endpoint_event, *(const u32 *)event);
   		break;
   	}

If it shows up on master too then it is older than the series, and I can
look at it separately. If master is clean, then I broke it and it has
to be fixed in this series.

If it is easier for you, I can also do it myself with remote access
to an AM62p. Then I need the serial console and a way to power cycle
the board and load my own U-Boot. I also need the host that the USB
port is connected to, so I can run ums.

Cheers,
Anders

  reply	other threads:[~2026-09-29 12:52 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-16 12:38 [PATCH v9 00/26] usb: dwc3: part 2, make the resynced code work Anders Roxell
2026-09-16 12:38 ` [PATCH v9 01/26] x86: asm: io.h: add rmb() and wmb() Anders Roxell
2026-09-16 12:38 ` [PATCH v9 02/26] dm: add helpers needed by the resynced DWC3 code Anders Roxell
2026-09-16 12:38 ` [PATCH v9 03/26] usb: phy: add the usb_phy " Anders Roxell
2026-09-16 12:38 ` [PATCH v9 04/26] usb: gadget: adapt the gadget API after the resync Anders Roxell
2026-09-16 12:38 ` [PATCH v9 05/26] usb: gadget: udc: make udc-core build in U-Boot Anders Roxell
2026-09-16 12:38 ` [PATCH v9 06/26] usb: dwc3: make the core driver " Anders Roxell
2026-09-16 12:38 ` [PATCH v9 07/26] usb: dwc3: bring back the samsung usb phy driver Anders Roxell
2026-09-16 12:38 ` [PATCH v9 08/26] usb: dwc3: make gadget and ep0 build in U-Boot Anders Roxell
2026-09-16 12:38 ` [PATCH v9 09/26] usb: gadget: udc: enable async callbacks on bind Anders Roxell
2026-09-16 12:38 ` [PATCH v9 10/26] usb: dwc3: ep0: flush and invalidate cache around ep0 transfers Anders Roxell
2026-09-16 12:38 ` [PATCH v9 11/26] usb: dwc3: gadget: flush and invalidate cache around transfers Anders Roxell
2026-09-16 12:38 ` [PATCH v9 12/26] usb: dwc3: make the am62 glue build in U-Boot Anders Roxell
2026-09-16 12:38 ` [PATCH v9 13/26] usb: gadget: ci_udc: move to the udc-core registration Anders Roxell
2026-09-16 12:38 ` [PATCH v9 14/26] usb: gadget: ci_udc: set endpoint capabilities Anders Roxell
2026-09-16 12:38 ` [PATCH v9 15/26] usb: gadget: dwc2_udc_otg: fix up after the resync Anders Roxell
2026-09-16 12:38 ` [PATCH v9 16/26] usb: gadget: fix up the function drivers " Anders Roxell
2026-09-16 12:38 ` [PATCH v9 17/26] usb: gadget: fix up the last UDC " Anders Roxell
2026-09-16 12:38 ` [PATCH v9 18/26] usb: gadget: atmel_usba_udc: set endpoint capabilities Anders Roxell
2026-09-16 12:38 ` [PATCH v9 19/26] usb: gadget: at91_udc: register with udc-core Anders Roxell
2026-09-16 12:38 ` [PATCH v9 20/26] usb: gadget: at91_udc: set endpoint capabilities Anders Roxell
2026-09-16 12:38 ` [PATCH v9 21/26] usb: musb-new: fix up after the resync Anders Roxell
2026-09-16 12:38 ` [PATCH v9 22/26] usb: musb-new: set endpoint capabilities Anders Roxell
2026-09-16 12:38 ` [PATCH v9 23/26] usb: mtu3: fix up after the resync Anders Roxell
2026-09-16 12:38 ` [PATCH v9 24/26] usb: mtu3: set endpoint capabilities Anders Roxell
2026-09-16 12:38 ` [PATCH v9 25/26] usb: host: xhci: fix up after the resync Anders Roxell
2026-09-16 12:38 ` [PATCH v9 26/26] usb: cdns3: " Anders Roxell
2026-09-17 12:43 ` [PATCH v9 00/26] usb: dwc3: part 2, make the resynced code work Anshul Dalal
2026-09-25  9:59   ` Anders Roxell
2026-09-25 10:39     ` Siddharth Vadapalli
2026-09-29 10:07       ` Anders Roxell [this message]
2026-09-29 13:05         ` Siddharth Vadapalli
2026-09-30 12:10           ` Anders Roxell
2026-10-02 14:17 ` Quentin Schulz
2026-10-13 13:02   ` Anders Roxell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aruN2OLSSnntkyrn@monster \
    --to=anders.roxell@linaro.org \
    --cc=Thinh.Nguyen@synopsys.com \
    --cc=alchark@flipper.net \
    --cc=anshuld@ti.com \
    --cc=c-vankar@ti.com \
    --cc=dlechner@baylibre.com \
    --cc=ilias.apalodimas@linaro.org \
    --cc=jerome.forissier@arm.com \
    --cc=love.kumar@amd.com \
    --cc=lukma@denx.de \
    --cc=marek.vasut@mailbox.org \
    --cc=michal.simek@amd.com \
    --cc=mkorpershoek@kernel.org \
    --cc=s-vadapalli@ti.com \
    --cc=sjg@chromium.org \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.u-boot-project.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.