Re: [PATCH] iotests: remove unused 'owner=' variable assignment

[Kevin Wolf <kwolf@redhat.com>]

Am 10.08.2026 um 16:12 hat Daniel P. Berrangé geschrieben:
> Most, but not all, of the shell I/O tests assign an email address to
> the 'owner' shell variable. This variable is never used for anything
> so gets reported as a dead assignment by shellcheck. The same is also
> not done for the python I/O tests, though some include owner= in a
> comment.
> 
> Mostly the 'owner=' variable seems to be an alternative to expressing
> an "Author: NAME <EMAIL>" comment, but without the NAME. While they
> could be converted to Author comments, this does not have a benefit
> over using Git history and are not widely used in QEMU source code.
> Git records activity over time so is more representative than the
> initial author. Meanwhile the MAINTAINERS file, also expresses a
> notion of ownership over the maint of files.
> 
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

Ok, why not. I don't think I ever looked at the line to figure out who
to contact.

> diff --git a/tests/qemu-iotests/001 b/tests/qemu-iotests/001
> index 6f980fd34d..d26c13ea03 100755
> --- a/tests/qemu-iotests/001
> +++ b/tests/qemu-iotests/001
> @@ -19,8 +19,6 @@
>  # along with this program.  If not, see <http://www.gnu.org/licenses/>.
>  #
>  
> -# creator
> -owner=hch@lst.de
>  
>  seq=`basename $0`
>  echo "QA output created by $seq"

But can you remove one of the now two empty lines after the comment
block, too, please? (Same for every hunk.)

Kevin