Re: [PATCH] iotests: remove unused 'owner=' variable assignment

[Kevin Wolf <kwolf@redhat.com>]

Am 29.09.2026 um 17:10 hat Philippe Mathieu-Daudé geschrieben:
> On 29/9/26 16:38, Kevin Wolf wrote:
> > Am 10.08.2026 um 16:12 hat Daniel P. Berrangé geschrieben:
> > > Most, but not all, of the shell I/O tests assign an email address to
> > > the 'owner' shell variable. This variable is never used for anything
> > > so gets reported as a dead assignment by shellcheck. The same is also
> > > not done for the python I/O tests, though some include owner= in a
> > > comment.
> > > 
> > > Mostly the 'owner=' variable seems to be an alternative to expressing
> > > an "Author: NAME <EMAIL>" comment, but without the NAME. While they
> > > could be converted to Author comments, this does not have a benefit
> > > over using Git history and are not widely used in QEMU source code.
> > > Git records activity over time so is more representative than the
> > > initial author. Meanwhile the MAINTAINERS file, also expresses a
> > > notion of ownership over the maint of files.
> > > 
> > > Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> > 
> > Ok, why not. I don't think I ever looked at the line to figure out who
> > to contact.
> 
> Maybe you didn't had to because these iotests already reached code
> perfection :)

Maybe. Or maybe it is just because 'git blame' gives more accurate
information anyway. :-)

Kevin