Re: [PATCH] drm/xe/vm: Do not dma_fence_put zero fences in err_out path

[Matthew Brost <matthew.brost@intel.com>]

On Wed, Sep 30, 2026 at 04:56:06AM +0800, Jonathan Cavitt wrote:
> It is not necessary to iterate over and dma_fence_put current_fence
> fences in the err_out path of ops_execute because current_fences cannot
> be non-zero when jumping to that section of code.
> 
> Caught by static analysis.
> 
> Fixes: f5708e761ed6 ("drm/xe: Add CPU bind layer")

No fixes required, as not yet pulled and also isn't a functional issue.

I'll drop when merging.

> Signed-off-by: Jonathan Cavitt <jonathan.cavitt@intel.com>
> Cc: Matthew Brost <matthew.brost@intel.com>

Reviewed-by: Matthew Brost <matthew.brost@intel.com>

> Cc: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>
> Cc: Shuicheng Lin <shuicheng.lin@intel.com>
> Cc: Maarten Lankhorst <dev@lankhorst.se>
> ---
>  drivers/gpu/drm/xe/xe_vm.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_vm.c b/drivers/gpu/drm/xe/xe_vm.c
> index 425c678f4480..f159970bd34e 100644
> --- a/drivers/gpu/drm/xe/xe_vm.c
> +++ b/drivers/gpu/drm/xe/xe_vm.c
> @@ -3575,8 +3575,6 @@ static struct dma_fence *ops_execute(struct xe_vm *vm,
>  
>  err_out:
>  	xe_pt_update_ops_abort(xe, vops);
> -	while (current_fence)
> -		dma_fence_put(fences[--current_fence]);
>  	kfree(fences);
>  	kfree(cf);
>  
> -- 
> 2.43.0
>