All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/xe/vm: Do not dma_fence_put zero fences in err_out path
@ 2026-09-29 20:56 Jonathan Cavitt
  2026-09-29 21:00 ` Matthew Brost
                   ` (3 more replies)
  0 siblings, 4 replies; 6+ messages in thread
From: Jonathan Cavitt @ 2026-09-29 20:56 UTC (permalink / raw)
  To: intel-xe
  Cc: alex.zuo, jonathan.cavitt, matthew.brost, himal.prasad.ghimiray,
	shuicheng.lin, dev

It is not necessary to iterate over and dma_fence_put current_fence
fences in the err_out path of ops_execute because current_fences cannot
be non-zero when jumping to that section of code.

Caught by static analysis.

Fixes: f5708e761ed6 ("drm/xe: Add CPU bind layer")
Signed-off-by: Jonathan Cavitt <jonathan.cavitt@intel.com>
Cc: Matthew Brost <matthew.brost@intel.com>
Cc: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>
Cc: Shuicheng Lin <shuicheng.lin@intel.com>
Cc: Maarten Lankhorst <dev@lankhorst.se>
---
 drivers/gpu/drm/xe/xe_vm.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_vm.c b/drivers/gpu/drm/xe/xe_vm.c
index 425c678f4480..f159970bd34e 100644
--- a/drivers/gpu/drm/xe/xe_vm.c
+++ b/drivers/gpu/drm/xe/xe_vm.c
@@ -3575,8 +3575,6 @@ static struct dma_fence *ops_execute(struct xe_vm *vm,
 
 err_out:
 	xe_pt_update_ops_abort(xe, vops);
-	while (current_fence)
-		dma_fence_put(fences[--current_fence]);
 	kfree(fences);
 	kfree(cf);
 
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2026-09-30  4:27 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-29 20:56 [PATCH] drm/xe/vm: Do not dma_fence_put zero fences in err_out path Jonathan Cavitt
2026-09-29 21:00 ` Matthew Brost
2026-09-29 21:07   ` Cavitt, Jonathan
2026-09-29 21:38 ` ✓ CI.KUnit: success for " Patchwork
2026-09-29 23:29 ` ✗ Xe.CI.BAT: failure " Patchwork
2026-09-30  4:27 ` ✗ Xe.CI.FULL: " Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.