Re: [PATCH] odrm/panthor: fix immortalis condition

Re: [PATCH] odrm/panthor: fix immortalis condition

[Liviu Dudau]

On Tue, Oct 13, 2026 at 11:31:50AM +0200, Erik Faye-Lund wrote:
> Exactly 10 cores is also valid for an Immortalis configuration,
> according to the public documentation:
> 
> https://support.arm.com/compute-ip/immortalis-g715
> 
> So let's report this G715 with 10 cores as Immortalis as well, as long
> as it supports the ray-intersection feature. This matches what we do for
> more recent GPUs as well.
> 
> Fixes: 3b1dc21d6d80 ("drm/panthor: Add support for Mali-Gx15 family of GPUs")

Reviewed-by: Liviu Dudau <liviu.dudau@arm.com>

Best regards,
Liviu

> ---
>  drivers/gpu/drm/panthor/panthor_hw.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/panthor/panthor_hw.c b/drivers/gpu/drm/panthor/panthor_hw.c
> index 7e315708ca7c..ea1e222ef121 100644
> --- a/drivers/gpu/drm/panthor/panthor_hw.c
> +++ b/drivers/gpu/drm/panthor/panthor_hw.c
> @@ -136,7 +136,7 @@ static char *get_gpu_model_name(struct panthor_device *ptdev)
>  	case GPU_PROD_ID_MAKE(10, 7):
>  		return "Mali-G610";
>  	case GPU_PROD_ID_MAKE(11, 2):
> -		if (shader_core_count > 10 && ray_intersection)
> +		if (shader_core_count >= 10 && ray_intersection)
>  			return "Mali-G715-Immortalis";
>  		else if (shader_core_count >= 7)
>  			return "Mali-G715";
> -- 
> 2.47.3
> 

-- 
====================
| I would like to |
| fix the world,  |
| but they're not |
| giving me the   |
 \ source code!  /
  ---------------
    ¯\_(ツ)_/¯

Re: [PATCH] odrm/panthor: fix immortalis condition

[Maxime Ripard]

[-- Attachment #1: Type: text/plain, Size: 599 bytes --]

Hi,

There's a typo in the patch title (odrm vs drm)

On Tue, Oct 13, 2026 at 11:31:50AM +0200, Erik Faye-Lund wrote:
> Exactly 10 cores is also valid for an Immortalis configuration,
> according to the public documentation:
> 
> https://support.arm.com/compute-ip/immortalis-g715
> 
> So let's report this G715 with 10 cores as Immortalis as well, as long
> as it supports the ray-intersection feature. This matches what we do for
> more recent GPUs as well.
> 
> Fixes: 3b1dc21d6d80 ("drm/panthor: Add support for Mali-Gx15 family of GPUs")

And you're missing your SoB

Maxime

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 273 bytes --]

Re: [PATCH] odrm/panthor: fix immortalis condition

[Erik Faye-Lund]

On Tue, 2026-10-13 at 11:47 +0200, Maxime Ripard wrote:
> Hi,
> 
> There's a typo in the patch title (odrm vs drm)
> 
> On Tue, Oct 13, 2026 at 11:31:50AM +0200, Erik Faye-Lund wrote:
> > Exactly 10 cores is also valid for an Immortalis configuration,
> > according to the public documentation:
> > 
> > https://support.arm.com/compute-ip/immortalis-g715
> > 
> > So let's report this G715 with 10 cores as Immortalis as well, as
> > long
> > as it supports the ray-intersection feature. This matches what we
> > do for
> > more recent GPUs as well.
> > 
> > Fixes: 3b1dc21d6d80 ("drm/panthor: Add support for Mali-Gx15 family
> > of GPUs")
> 
> And you're missing your SoB
> 
> Maxime

My appologies, I intentionally left it out locally while verifying
internal approvals for sending it out, and forgot to apply before
sending. Here's the SoB line, in case anyone wants to add it while
applying the patch. If not, I can resend.

Signed-off-by: Erik Faye-Lund <erik.faye-lund@arm.com>

Re: [PATCH] odrm/panthor: fix immortalis condition

[Boris Brezillon]

On Tue, 13 Oct 2026 11:31:50 +0200
Erik Faye-Lund <erik.faye-lund@arm.com> wrote:

s/odrm/drm/ in the subject :D.

> Exactly 10 cores is also valid for an Immortalis configuration,
> according to the public documentation:
> 
> https://support.arm.com/compute-ip/immortalis-g715
> 
> So let's report this G715 with 10 cores as Immortalis as well, as long
> as it supports the ray-intersection feature. This matches what we do for
> more recent GPUs as well.
> 
> Fixes: 3b1dc21d6d80 ("drm/panthor: Add support for Mali-Gx15 family of GPUs")

With the SoB added and the typo fixed, this is

Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>

> ---
>  drivers/gpu/drm/panthor/panthor_hw.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/panthor/panthor_hw.c b/drivers/gpu/drm/panthor/panthor_hw.c
> index 7e315708ca7c..ea1e222ef121 100644
> --- a/drivers/gpu/drm/panthor/panthor_hw.c
> +++ b/drivers/gpu/drm/panthor/panthor_hw.c
> @@ -136,7 +136,7 @@ static char *get_gpu_model_name(struct panthor_device *ptdev)
>  	case GPU_PROD_ID_MAKE(10, 7):
>  		return "Mali-G610";
>  	case GPU_PROD_ID_MAKE(11, 2):
> -		if (shader_core_count > 10 && ray_intersection)
> +		if (shader_core_count >= 10 && ray_intersection)
>  			return "Mali-G715-Immortalis";
>  		else if (shader_core_count >= 7)
>  			return "Mali-G715";