Re: [Buildroot] [PATCH 1/1] package/tcf-agent: bump to version 1.11.0

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello,

Thanks for your patch, sorry for the delay in getting back to you. See
below for some comments.

On Tue, Jun 16, 2026 at 09:35:37AM -1000, Evgueni Tarassov wrote:
> Signed-off-by: Eugene Tarassov <eugene@largest.net>

Your commit log is empty, but the commit does more than bumping the
version, could you add some details are about the changes being done
(why is the patch removed, RISC-V support added, etc.).

> ---
>  ...tcf-services-tcf_elf.c-fix-x86-build.patch | 60 -------------------
>  package/tcf-agent/Config.in                   |  4 +-
>  package/tcf-agent/tcf-agent.hash              |  2 +-
>  package/tcf-agent/tcf-agent.mk                |  6 +-
>  4 files changed, 6 insertions(+), 66 deletions(-)
>  delete mode 100644 package/tcf-agent/0001-agent-tcf-services-tcf_elf.c-fix-x86-build.patch
> 
> diff --git a/package/tcf-agent/0001-agent-tcf-services-tcf_elf.c-fix-x86-build.patch b/package/tcf-agent/0001-agent-tcf-services-tcf_elf.c-fix-x86-build.patch
> deleted file mode 100644
> index 5f08fa485e..0000000000
> --- a/package/tcf-agent/0001-agent-tcf-services-tcf_elf.c-fix-x86-build.patch
> +++ /dev/null
> @@ -1,60 +0,0 @@
> -From 0a847ca035113540ee44d17f364bf4701fe78355 Mon Sep 17 00:00:00 2001
> -From: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> -Date: Fri, 1 Mar 2024 22:31:05 +0100
> -Subject: [PATCH] agent/tcf/services/tcf_elf.c: fix x86 build
> -
> -Fix the following x86 build failure raised since version 1.8.0 and
> -https://gitlab.eclipse.org/eclipse/tcf/tcf.agent/-/commit/8df5540c53b862d516ac25f908c2fff4a547b4a6:
> -
> -/home/buildroot/autobuild/run/instance-1/output-1/build/tcf-agent-1.8.0/agent/tcf/services/tcf_elf.c: In function 'unpack_elf_symbol_info':
> -/home/buildroot/autobuild/run/instance-1/output-1/build/tcf-agent-1.8.0/agent/tcf/services/tcf_elf.c:2079:27: error: 'STT_ARM_16BIT' undeclared (first use in this function)
> - 2079 |         if (info->type == STT_ARM_16BIT) {
> -      |                           ^~~~~~~~~~~~~
> -/home/buildroot/autobuild/run/instance-1/output-1/build/tcf-agent-1.8.0/agent/tcf/services/tcf_elf.c:2079:27: note: each undeclared identifier is reported only once for each function it appears in
> -/home/buildroot/autobuild/run/instance-1/output-1/build/tcf-agent-1.8.0/agent/tcf/services/tcf_elf.c: In function 'create_symbol_addr_search_index':
> -/home/buildroot/autobuild/run/instance-1/output-1/build/tcf-agent-1.8.0/agent/tcf/services/tcf_elf.c:2228:78: error: 'STT_ARM_16BIT' undeclared (first use in this function)
> - 2228 |                     if (type == STT_FUNC || type == STT_ARM_TFUNC || type == STT_ARM_16BIT) {
> -      |                                                                              ^~~~~~~~~~~~~
> -
> -Fixes:
> - - http://autobuild.buildroot.org/results/8388acf59689ed7e621bdf158483e3df1cf9bef7
> -
> -Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> -Upstream: https://gitlab.eclipse.org/eclipse/tcf/tcf.agent/-/merge_requests/1

This merge request doesn't seem to have been merged, so why is patch
removed?

> diff --git a/package/tcf-agent/Config.in b/package/tcf-agent/Config.in
> index a016871e6d..7281e62377 100644
> --- a/package/tcf-agent/Config.in
> +++ b/package/tcf-agent/Config.in
> @@ -27,9 +27,9 @@ config BR2_PACKAGE_TCF_AGENT_ARCH
>  	default "i686"       if BR2_i386 && BR2_ARCH="i686"
>  	default "i386"       if BR2_i386 && !BR2_ARCH="i686"
>  	default "x86_64"     if BR2_x86_64
> -	default "powerpc"    if BR2_powerpc || BR2_powerpc64 || \
> -		BR2_powerpc64le
> +	default "powerpc"    if BR2_powerpc || BR2_powerpc64 || BR2_powerpc64le

That seems like an unrelated/unneeded change?

>  	default "microblaze" if BR2_microblaze || BR2_microblazeel
> +	default "riscv64"    if BR2_riscv && BR2_RISCV_64

Could you have a look at those minor comments and submit a v2?

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot