All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] package/tcf-agent: bump to version 1.11.0
@ 2026-06-16 19:35 Evgueni Tarassov
  2026-10-13  8:28 ` Thomas Petazzoni via buildroot
  0 siblings, 1 reply; 2+ messages in thread
From: Evgueni Tarassov @ 2026-06-16 19:35 UTC (permalink / raw)
  To: buildroot; +Cc: nolange79

Signed-off-by: Eugene Tarassov <eugene@largest.net>
---
 ...tcf-services-tcf_elf.c-fix-x86-build.patch | 60 -------------------
 package/tcf-agent/Config.in                   |  4 +-
 package/tcf-agent/tcf-agent.hash              |  2 +-
 package/tcf-agent/tcf-agent.mk                |  6 +-
 4 files changed, 6 insertions(+), 66 deletions(-)
 delete mode 100644 package/tcf-agent/0001-agent-tcf-services-tcf_elf.c-fix-x86-build.patch

diff --git a/package/tcf-agent/0001-agent-tcf-services-tcf_elf.c-fix-x86-build.patch b/package/tcf-agent/0001-agent-tcf-services-tcf_elf.c-fix-x86-build.patch
deleted file mode 100644
index 5f08fa485e..0000000000
--- a/package/tcf-agent/0001-agent-tcf-services-tcf_elf.c-fix-x86-build.patch
+++ /dev/null
@@ -1,60 +0,0 @@
-From 0a847ca035113540ee44d17f364bf4701fe78355 Mon Sep 17 00:00:00 2001
-From: Fabrice Fontaine <fontaine.fabrice@gmail.com>
-Date: Fri, 1 Mar 2024 22:31:05 +0100
-Subject: [PATCH] agent/tcf/services/tcf_elf.c: fix x86 build
-
-Fix the following x86 build failure raised since version 1.8.0 and
-https://gitlab.eclipse.org/eclipse/tcf/tcf.agent/-/commit/8df5540c53b862d516ac25f908c2fff4a547b4a6:
-
-/home/buildroot/autobuild/run/instance-1/output-1/build/tcf-agent-1.8.0/agent/tcf/services/tcf_elf.c: In function 'unpack_elf_symbol_info':
-/home/buildroot/autobuild/run/instance-1/output-1/build/tcf-agent-1.8.0/agent/tcf/services/tcf_elf.c:2079:27: error: 'STT_ARM_16BIT' undeclared (first use in this function)
- 2079 |         if (info->type == STT_ARM_16BIT) {
-      |                           ^~~~~~~~~~~~~
-/home/buildroot/autobuild/run/instance-1/output-1/build/tcf-agent-1.8.0/agent/tcf/services/tcf_elf.c:2079:27: note: each undeclared identifier is reported only once for each function it appears in
-/home/buildroot/autobuild/run/instance-1/output-1/build/tcf-agent-1.8.0/agent/tcf/services/tcf_elf.c: In function 'create_symbol_addr_search_index':
-/home/buildroot/autobuild/run/instance-1/output-1/build/tcf-agent-1.8.0/agent/tcf/services/tcf_elf.c:2228:78: error: 'STT_ARM_16BIT' undeclared (first use in this function)
- 2228 |                     if (type == STT_FUNC || type == STT_ARM_TFUNC || type == STT_ARM_16BIT) {
-      |                                                                              ^~~~~~~~~~~~~
-
-Fixes:
- - http://autobuild.buildroot.org/results/8388acf59689ed7e621bdf158483e3df1cf9bef7
-
-Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
-Upstream: https://gitlab.eclipse.org/eclipse/tcf/tcf.agent/-/merge_requests/1
----
- agent/tcf/services/tcf_elf.c | 8 +++++++-
- 1 file changed, 7 insertions(+), 1 deletion(-)
-
-diff --git a/agent/tcf/services/tcf_elf.c b/agent/tcf/services/tcf_elf.c
-index 1b3900ec..b0b948e4 100644
---- a/agent/tcf/services/tcf_elf.c
-+++ b/agent/tcf/services/tcf_elf.c
-@@ -2076,10 +2076,12 @@ void unpack_elf_symbol_info(ELF_Section * sym_sec, U4_T index, ELF_SymbolInfo *
-     }
- 
-     if (file->machine == EM_ARM) {
-+#ifdef STT_ARM_16BIT
-         if (info->type == STT_ARM_16BIT) {
-             info->type = STT_OBJECT;
-             info->type16bit = 1;
-         }
-+#endif
-         if (info->type == STT_ARM_TFUNC) {
-             info->type = STT_FUNC;
-             info->type16bit = 1;
-@@ -2225,7 +2227,11 @@ static void create_symbol_addr_search_index(ELF_Section * sec) {
-                 }
-                 add = add && type != STT_GNU_IFUNC;
-                 if (add && file->machine == EM_ARM) {
--                    if (type == STT_FUNC || type == STT_ARM_TFUNC || type == STT_ARM_16BIT) {
-+                    if (type == STT_FUNC || type == STT_ARM_TFUNC
-+#ifdef STT_ARM_16BIT
-+                     || type == STT_ARM_16BIT
-+#endif
-+                     ) {
-                         addr = addr & ~(U8_T)1;
-                     }
-                 }
--- 
-2.43.0
-
diff --git a/package/tcf-agent/Config.in b/package/tcf-agent/Config.in
index a016871e6d..7281e62377 100644
--- a/package/tcf-agent/Config.in
+++ b/package/tcf-agent/Config.in
@@ -27,9 +27,9 @@ config BR2_PACKAGE_TCF_AGENT_ARCH
 	default "i686"       if BR2_i386 && BR2_ARCH="i686"
 	default "i386"       if BR2_i386 && !BR2_ARCH="i686"
 	default "x86_64"     if BR2_x86_64
-	default "powerpc"    if BR2_powerpc || BR2_powerpc64 || \
-		BR2_powerpc64le
+	default "powerpc"    if BR2_powerpc || BR2_powerpc64 || BR2_powerpc64le
 	default "microblaze" if BR2_microblaze || BR2_microblazeel
+	default "riscv64"    if BR2_riscv && BR2_RISCV_64
 
 config BR2_PACKAGE_TCF_AGENT_ARCH_SUPPORTS
 	bool
diff --git a/package/tcf-agent/tcf-agent.hash b/package/tcf-agent/tcf-agent.hash
index 34893d280b..8a790290f1 100644
--- a/package/tcf-agent/tcf-agent.hash
+++ b/package/tcf-agent/tcf-agent.hash
@@ -1,5 +1,5 @@
 # Locally computed:
-sha256  64131790c7d4636d4abff8516d5b4b6329e4d3e691f44dc604e2c30f55edb0dd  org.eclipse.tcf.agent-1.8.0.tar.xz
+sha256  babc9ecc26d0434f4cafbfa1933451a11516ccd590e77e090a84e8253a10fc4c  tcf.agent-1.11.0.tar.gz
 
 # Hash for license files:
 sha256  f82d01b74a513bd3504d08136026a5ac2a7e6ff62ebcde391fa74aa222d11ce0  agent/edl-v10.html
diff --git a/package/tcf-agent/tcf-agent.mk b/package/tcf-agent/tcf-agent.mk
index e90334c783..d95a6fcbae 100644
--- a/package/tcf-agent/tcf-agent.mk
+++ b/package/tcf-agent/tcf-agent.mk
@@ -4,9 +4,9 @@
 #
 ################################################################################
 
-TCF_AGENT_VERSION = 1.8.0
-TCF_AGENT_SOURCE = org.eclipse.tcf.agent-$(TCF_AGENT_VERSION).tar.xz
-TCF_AGENT_SITE = http://git.eclipse.org/c/tcf/org.eclipse.tcf.agent.git/snapshot
+TCF_AGENT_VERSION = 1.11.0
+TCF_AGENT_SOURCE = tcf.agent-$(TCF_AGENT_VERSION).tar.gz
+TCF_AGENT_SITE = https://gitlab.eclipse.org/eclipse/tcf/tcf.agent/-/archive/$(TCF_AGENT_VERSION)
 # see https://wiki.spdx.org/view/Legal_Team/License_List/Licenses_Under_Consideration
 TCF_AGENT_LICENSE = BSD-3-Clause
 TCF_AGENT_LICENSE_FILES = agent/edl-v10.html
-- 
2.51.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 2+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/tcf-agent: bump to version 1.11.0
  2026-06-16 19:35 [Buildroot] [PATCH 1/1] package/tcf-agent: bump to version 1.11.0 Evgueni Tarassov
@ 2026-10-13  8:28 ` Thomas Petazzoni via buildroot
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Petazzoni via buildroot @ 2026-10-13  8:28 UTC (permalink / raw)
  To: Evgueni Tarassov; +Cc: buildroot, nolange79

Hello,

Thanks for your patch, sorry for the delay in getting back to you. See
below for some comments.

On Tue, Jun 16, 2026 at 09:35:37AM -1000, Evgueni Tarassov wrote:
> Signed-off-by: Eugene Tarassov <eugene@largest.net>

Your commit log is empty, but the commit does more than bumping the
version, could you add some details are about the changes being done
(why is the patch removed, RISC-V support added, etc.).

> ---
>  ...tcf-services-tcf_elf.c-fix-x86-build.patch | 60 -------------------
>  package/tcf-agent/Config.in                   |  4 +-
>  package/tcf-agent/tcf-agent.hash              |  2 +-
>  package/tcf-agent/tcf-agent.mk                |  6 +-
>  4 files changed, 6 insertions(+), 66 deletions(-)
>  delete mode 100644 package/tcf-agent/0001-agent-tcf-services-tcf_elf.c-fix-x86-build.patch
> 
> diff --git a/package/tcf-agent/0001-agent-tcf-services-tcf_elf.c-fix-x86-build.patch b/package/tcf-agent/0001-agent-tcf-services-tcf_elf.c-fix-x86-build.patch
> deleted file mode 100644
> index 5f08fa485e..0000000000
> --- a/package/tcf-agent/0001-agent-tcf-services-tcf_elf.c-fix-x86-build.patch
> +++ /dev/null
> @@ -1,60 +0,0 @@
> -From 0a847ca035113540ee44d17f364bf4701fe78355 Mon Sep 17 00:00:00 2001
> -From: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> -Date: Fri, 1 Mar 2024 22:31:05 +0100
> -Subject: [PATCH] agent/tcf/services/tcf_elf.c: fix x86 build
> -
> -Fix the following x86 build failure raised since version 1.8.0 and
> -https://gitlab.eclipse.org/eclipse/tcf/tcf.agent/-/commit/8df5540c53b862d516ac25f908c2fff4a547b4a6:
> -
> -/home/buildroot/autobuild/run/instance-1/output-1/build/tcf-agent-1.8.0/agent/tcf/services/tcf_elf.c: In function 'unpack_elf_symbol_info':
> -/home/buildroot/autobuild/run/instance-1/output-1/build/tcf-agent-1.8.0/agent/tcf/services/tcf_elf.c:2079:27: error: 'STT_ARM_16BIT' undeclared (first use in this function)
> - 2079 |         if (info->type == STT_ARM_16BIT) {
> -      |                           ^~~~~~~~~~~~~
> -/home/buildroot/autobuild/run/instance-1/output-1/build/tcf-agent-1.8.0/agent/tcf/services/tcf_elf.c:2079:27: note: each undeclared identifier is reported only once for each function it appears in
> -/home/buildroot/autobuild/run/instance-1/output-1/build/tcf-agent-1.8.0/agent/tcf/services/tcf_elf.c: In function 'create_symbol_addr_search_index':
> -/home/buildroot/autobuild/run/instance-1/output-1/build/tcf-agent-1.8.0/agent/tcf/services/tcf_elf.c:2228:78: error: 'STT_ARM_16BIT' undeclared (first use in this function)
> - 2228 |                     if (type == STT_FUNC || type == STT_ARM_TFUNC || type == STT_ARM_16BIT) {
> -      |                                                                              ^~~~~~~~~~~~~
> -
> -Fixes:
> - - http://autobuild.buildroot.org/results/8388acf59689ed7e621bdf158483e3df1cf9bef7
> -
> -Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> -Upstream: https://gitlab.eclipse.org/eclipse/tcf/tcf.agent/-/merge_requests/1

This merge request doesn't seem to have been merged, so why is patch
removed?

> diff --git a/package/tcf-agent/Config.in b/package/tcf-agent/Config.in
> index a016871e6d..7281e62377 100644
> --- a/package/tcf-agent/Config.in
> +++ b/package/tcf-agent/Config.in
> @@ -27,9 +27,9 @@ config BR2_PACKAGE_TCF_AGENT_ARCH
>  	default "i686"       if BR2_i386 && BR2_ARCH="i686"
>  	default "i386"       if BR2_i386 && !BR2_ARCH="i686"
>  	default "x86_64"     if BR2_x86_64
> -	default "powerpc"    if BR2_powerpc || BR2_powerpc64 || \
> -		BR2_powerpc64le
> +	default "powerpc"    if BR2_powerpc || BR2_powerpc64 || BR2_powerpc64le

That seems like an unrelated/unneeded change?

>  	default "microblaze" if BR2_microblaze || BR2_microblazeel
> +	default "riscv64"    if BR2_riscv && BR2_RISCV_64

Could you have a look at those minor comments and submit a v2?

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-10-13  8:28 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-16 19:35 [Buildroot] [PATCH 1/1] package/tcf-agent: bump to version 1.11.0 Evgueni Tarassov
2026-10-13  8:28 ` Thomas Petazzoni via buildroot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.