[RFC PATCH] .dir-locals: include QEMU code in PYTHONPATH

[RFC PATCH] .dir-locals: include QEMU code in PYTHONPATH

[Alex Bennée]

When editing python code the linters tools have a hard time with our
imports as they can't be found. To ease this we can expand a
PYTHONPATH in .dir-locals so at least Emacs users can have less
warnings in their editor.

I still get complaints from python-mypy about missing library stubs
that mean it can't do proper type analysis though.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
 .dir-locals.el | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/.dir-locals.el b/.dir-locals.el
index 3ac0cfc6f0d..51871619422 100644
--- a/.dir-locals.el
+++ b/.dir-locals.el
@@ -1,2 +1,8 @@
 ((c-mode . ((c-file-style . "stroustrup")
-	    (indent-tabs-mode . nil))))
+	    (indent-tabs-mode . nil)))
+ (python-mode .
+              ((eval . (when-let* ((root (locate-dominating-file default-directory ".dir-locals.el")))
+                         (setq-local process-environment (copy-sequence process-environment))
+                         (setenv "PYTHONPATH"
+                                 (concat (expand-file-name "python" root) ":"
+                                         (expand-file-name "tests/functional" root))))))))
-- 
2.47.3

Re: [RFC PATCH] .dir-locals: include QEMU code in PYTHONPATH

[Alex Bennée]

Alex Bennée <alex.bennee@linaro.org> writes:

> When editing python code the linters tools have a hard time with our
> imports as they can't be found. To ease this we can expand a
> PYTHONPATH in .dir-locals so at least Emacs users can have less
> warnings in their editor.
>
> I still get complaints from python-mypy about missing library stubs
> that mean it can't do proper type analysis though.

Gentle ping for any fellow Emacers who also hack on the python code.

>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
>  .dir-locals.el | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/.dir-locals.el b/.dir-locals.el
> index 3ac0cfc6f0d..51871619422 100644
> --- a/.dir-locals.el
> +++ b/.dir-locals.el
> @@ -1,2 +1,8 @@
>  ((c-mode . ((c-file-style . "stroustrup")
> -	    (indent-tabs-mode . nil))))
> +	    (indent-tabs-mode . nil)))
> + (python-mode .
> +              ((eval . (when-let* ((root (locate-dominating-file default-directory ".dir-locals.el")))
> +                         (setq-local process-environment (copy-sequence process-environment))
> +                         (setenv "PYTHONPATH"
> +                                 (concat (expand-file-name "python" root) ":"
> +                                         (expand-file-name "tests/functional" root))))))))

-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro

Re: [RFC PATCH] .dir-locals: include QEMU code in PYTHONPATH

[Daniel P. Berrangé]

On Wed, Sep 30, 2026 at 05:30:50PM +0100, Alex Bennée wrote:
> When editing python code the linters tools have a hard time with our
> imports as they can't be found. To ease this we can expand a
> PYTHONPATH in .dir-locals so at least Emacs users can have less
> warnings in their editor.
> 
> I still get complaints from python-mypy about missing library stubs
> that mean it can't do proper type analysis though.
> 
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
>  .dir-locals.el | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com       ~~        https://hachyderm.io/@berrange :|
|: https://libvirt.org          ~~          https://entangle-photo.org :|
|: https://pixelfed.art/berrange   ~~    https://fstop138.berrange.com :|