* [PATCH batadv] batman-adv: mcast: explicitly initialize mcast.want_all_rtr{4,6}_list
@ 2026-10-12 11:10 Sven Eckelmann
2026-10-13 10:47 ` Linus Lüssing
0 siblings, 1 reply; 2+ messages in thread
From: Sven Eckelmann @ 2026-10-12 11:10 UTC (permalink / raw)
To: b.a.t.m.a.n; +Cc: Sven Eckelmann
All mcast.want_*_list are initialized in batadv_mesh_init() - with the
exception of mcast.want_all_rtr4_list + mcast.want_all_rtr6_list. At the
moment, it works because INIT_HLIST_HEAD just initializes it to NULL and
the netdev private data is already set to 0 before being passed to
.ndo_init.
For consistency purposes, also initialize mcast.want_all_rtr4_list +
mcast.want_all_rtr6_list explicitly.
Signed-off-by: Sven Eckelmann <sven@narfation.org>
---
net/batman-adv/main.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/net/batman-adv/main.c b/net/batman-adv/main.c
index 6c54a8d4..e7f9677b 100644
--- a/net/batman-adv/main.c
+++ b/net/batman-adv/main.c
@@ -216,6 +216,8 @@ int batadv_mesh_init(struct net_device *mesh_iface)
INIT_HLIST_HEAD(&bat_priv->mcast.want_all_unsnoopables_list);
INIT_HLIST_HEAD(&bat_priv->mcast.want_all_ipv4_list);
INIT_HLIST_HEAD(&bat_priv->mcast.want_all_ipv6_list);
+ INIT_HLIST_HEAD(&bat_priv->mcast.want_all_rtr4_list);
+ INIT_HLIST_HEAD(&bat_priv->mcast.want_all_rtr6_list);
#endif
INIT_LIST_HEAD(&bat_priv->tt.changes_list);
INIT_HLIST_HEAD(&bat_priv->tt.req_list);
---
base-commit: 0eaac0f4187bc9b69b41d90998fd7b93ab07e53e
change-id: 20261012-mcast_list_init-4b31c7ed35e7
Best regards,
--
Sven Eckelmann <sven@narfation.org>
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH batadv] batman-adv: mcast: explicitly initialize mcast.want_all_rtr{4,6}_list
2026-10-12 11:10 [PATCH batadv] batman-adv: mcast: explicitly initialize mcast.want_all_rtr{4,6}_list Sven Eckelmann
@ 2026-10-13 10:47 ` Linus Lüssing
0 siblings, 0 replies; 2+ messages in thread
From: Linus Lüssing @ 2026-10-13 10:47 UTC (permalink / raw)
To: Sven Eckelmann; +Cc: b.a.t.m.a.n
On Mon, Oct 12, 2026 at 01:10:57PM +0200, Sven Eckelmann wrote:
> All mcast.want_*_list are initialized in batadv_mesh_init() - with the
> exception of mcast.want_all_rtr4_list + mcast.want_all_rtr6_list. At the
> moment, it works because INIT_HLIST_HEAD just initializes it to NULL and
> the netdev private data is already set to 0 before being passed to
> .ndo_init.
>
> For consistency purposes, also initialize mcast.want_all_rtr4_list +
> mcast.want_all_rtr6_list explicitly.
>
> Signed-off-by: Sven Eckelmann <sven@narfation.org>
> ---
Acked-by: Linus Lüssing <linus.luessing@c0d3.blue>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-10-13 10:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-10-12 11:10 [PATCH batadv] batman-adv: mcast: explicitly initialize mcast.want_all_rtr{4,6}_list Sven Eckelmann
2026-10-13 10:47 ` Linus Lüssing
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.