[PATCH] media: imx-jpeg: propagate encoder command errors

[PATCH] media: imx-jpeg: propagate encoder command errors

[Avi Weiss]

mxc_jpeg_encoder_cmd() returns success when
v4l2_m2m_ioctl_encoder_cmd() fails. When an encoder command is issued
while the mem2mem context is draining, the helper returns -EBUSY,
but userspace sees success.

Return the helper error, as mxc_jpeg_decoder_cmd() already does.
No obvious reason to clobber the error here.

Fixes: 4911c5acf935 ("media: imx-jpeg: Implement drain using v4l2-mem2mem helpers")
Signed-off-by: Avi Weiss <thnkslprpt@gmail.com>
---
 drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c b/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c
index e17085935435..5e466ea65a92 100644
--- a/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c
+++ b/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c
@@ -1726,7 +1726,7 @@ static int mxc_jpeg_encoder_cmd(struct file *file, void *priv,
 	ret = v4l2_m2m_ioctl_encoder_cmd(file, fh, cmd);
 	spin_unlock_irqrestore(&ctx->mxc_jpeg->hw_lock, flags);
 	if (ret < 0)
-		return 0;
+		return ret;
 
 	if (cmd->cmd == V4L2_ENC_CMD_STOP &&
 	    v4l2_m2m_has_stopped(fh->m2m_ctx))

base-commit: d7e7bca7169873b46e857c025c10f3336c1258d8
-- 
2.43.0

Re: [PATCH] media: imx-jpeg: propagate encoder command errors

[Frank Li]

On Mon, Oct 12, 2026 at 05:18:24PM +0300, Avi Weiss wrote:
> [You don't often get email from thnkslprpt@gmail.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>
> mxc_jpeg_encoder_cmd() returns success when
> v4l2_m2m_ioctl_encoder_cmd() fails. When an encoder command is issued
> while the mem2mem context is draining, the helper returns -EBUSY,
> but userspace sees success.
>
> Return the helper error, as mxc_jpeg_decoder_cmd() already does.
> No obvious reason to clobber the error here.
>
> Fixes: 4911c5acf935 ("media: imx-jpeg: Implement drain using v4l2-mem2mem helpers")
> Signed-off-by: Avi Weiss <thnkslprpt@gmail.com>
> ---

Reviewed-by: Frank Li <Frank.Li@nxp.com>

>  drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c b/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c
> index e17085935435..5e466ea65a92 100644
> --- a/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c
> +++ b/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c
> @@ -1726,7 +1726,7 @@ static int mxc_jpeg_encoder_cmd(struct file *file, void *priv,
>         ret = v4l2_m2m_ioctl_encoder_cmd(file, fh, cmd);
>         spin_unlock_irqrestore(&ctx->mxc_jpeg->hw_lock, flags);
>         if (ret < 0)
> -               return 0;
> +               return ret;
>
>         if (cmd->cmd == V4L2_ENC_CMD_STOP &&
>             v4l2_m2m_has_stopped(fh->m2m_ctx))
>
> base-commit: d7e7bca7169873b46e857c025c10f3336c1258d8
> --
> 2.43.0
>
>

RE: [EXT] [PATCH] media: imx-jpeg: propagate encoder command errors

[Ming Qian]

NXP Confidential
>-----Original Message-----
>From: Avi Weiss <thnkslprpt@gmail.com>
>Sent: Monday, October 12, 2026 10:18 PM
>To: Mirela Rabulea <mirela.rabulea@nxp.com>; linux-media@vger.kernel.org
>Cc: Ming Qian <ming.qian@nxp.com>; Hans Verkuil <hverkuil@kernel.org>;
>Mauro Carvalho Chehab <mchehab@kernel.org>; imx@lists.linux.dev; Avi
>Weiss <thnkslprpt@gmail.com>
>Subject: [EXT] [PATCH] media: imx-jpeg: propagate encoder command errors
>
>[You don't often get email from thnkslprpt@gmail.com. Learn why this is
>important at https://aka.ms/LearnAboutSenderIdentification ]
>
>Caution: This is an external email. Please take care when clicking links or
>opening attachments. When in doubt, report the message using the 'Report
>this email' button
>
>
>mxc_jpeg_encoder_cmd() returns success when
>v4l2_m2m_ioctl_encoder_cmd() fails. When an encoder command is issued
>while the mem2mem context is draining, the helper returns -EBUSY, but
>userspace sees success.
>
>Return the helper error, as mxc_jpeg_decoder_cmd() already does.
>No obvious reason to clobber the error here.
>
>Fixes: 4911c5acf935 ("media: imx-jpeg: Implement drain using v4l2-mem2mem
>helpers")
>Signed-off-by: Avi Weiss <thnkslprpt@gmail.com>

Reviewed-by: Ming Qian <ming.qian@oss.nxp.com>

>---
> drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c
>b/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c
>index e17085935435..5e466ea65a92 100644
>--- a/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c
>+++ b/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c
>@@ -1726,7 +1726,7 @@ static int mxc_jpeg_encoder_cmd(struct file *file,
>void *priv,
>        ret = v4l2_m2m_ioctl_encoder_cmd(file, fh, cmd);
>        spin_unlock_irqrestore(&ctx->mxc_jpeg->hw_lock, flags);
>        if (ret < 0)
>-               return 0;
>+               return ret;
>
>        if (cmd->cmd == V4L2_ENC_CMD_STOP &&
>            v4l2_m2m_has_stopped(fh->m2m_ctx))
>
>base-commit: d7e7bca7169873b46e857c025c10f3336c1258d8
>--
>2.43.0

Re: [EXT] [PATCH] media: imx-jpeg: propagate encoder command errors

[Frank Li]

On Tue, Oct 13, 2026 at 02:01:21AM +0000, Ming Qian wrote:
>
>
>
> NXP Confidential

Avoid use "NXP Confidential" for public mail list.

Frank