From: Eric Blake <eblake@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: qemu-devel@nongnu.org,
"Pierrick Bouvier" <pierrick.bouvier@oss.qualcomm.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
akalenyu@redhat.com, "Kevin Wolf" <kwolf@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Fam Zheng" <fam@euphon.net>,
"Paolo Bonzini" <pbonzini@redhat.com>,
qemu-block@nongnu.org, "Hanna Reitz" <hreitz@redhat.com>,
"Benjamin Marzinski" <bmarzins@redhat.com>
Subject: Re: [PATCH v2 8/8] scsi: use REGISTER AND IGNORE EXISTING KEY for robustness
Date: Tue, 13 Oct 2026 15:05:08 -0500 [thread overview]
Message-ID: <as6O1TAEUOAf7iJF@redhat.com> (raw)
In-Reply-To: <20261013181752.1299456-9-stefanha@redhat.com>
On Tue, Oct 13, 2026 at 02:17:52PM -0400, Stefan Hajnoczi wrote:
> The regular REGISTER service action fails with RESERVATION CONFLICT when
> the I_T nexus already has a key registered. While we don't expect a key
> to be registered, it is fragile to rely on this. If there is a key
> registered for some reason, live migration will fail when the
> destination hits the RESERVATION CONFLICT error.
>
> Use REGISTER AND IGNORE EXISTING KEY so that the command is likely to
> succeed.
>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
> hw/scsi/scsi-generic.c | 12 +++++++-----
> 1 file changed, 7 insertions(+), 5 deletions(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc.
Virtualization: qemu.org | libguestfs.org
prev parent reply other threads:[~2026-10-13 20:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-13 18:17 [PATCH v2 0/8] scsi: clean up persistent reservation state after migration Stefan Hajnoczi
2026-10-13 18:17 ` [PATCH v2 1/8] pr-manager-helper: fix sense buffer overflow Stefan Hajnoczi
2026-10-13 18:17 ` [PATCH v2 2/8] scsi: increase sense buffer size in scsi_SG_IO() Stefan Hajnoczi
2026-10-13 18:17 ` [PATCH v2 3/8] hw/scsi-disk: move MIG_EVENT_FAILED into a new function Stefan Hajnoczi
2026-10-13 19:16 ` Eric Blake
2026-10-13 18:17 ` [PATCH v2 4/8] qemu-pr-helper: add PR_HELPER_CLEANUP for live migration Stefan Hajnoczi
2026-10-13 19:47 ` Eric Blake
2026-10-13 19:47 ` Paolo Bonzini
2026-10-13 18:17 ` [PATCH v2 5/8] pr-manager-helper: add PR_HELPER_CLEANUP command support Stefan Hajnoczi
2026-10-13 19:49 ` Eric Blake
2026-10-13 18:17 ` [PATCH v2 6/8] file-posix: forward PR_HELPER_CLEANUP commands to pr-manager Stefan Hajnoczi
2026-10-13 19:51 ` Eric Blake
2026-10-13 18:17 ` [PATCH v2 7/8] scsi: clean up persistent reservation state after migration Stefan Hajnoczi
2026-10-13 20:04 ` Eric Blake
2026-10-13 18:17 ` [PATCH v2 8/8] scsi: use REGISTER AND IGNORE EXISTING KEY for robustness Stefan Hajnoczi
2026-10-13 20:05 ` Eric Blake [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=as6O1TAEUOAf7iJF@redhat.com \
--to=eblake@redhat.com \
--cc=akalenyu@redhat.com \
--cc=berrange@redhat.com \
--cc=bmarzins@redhat.com \
--cc=fam@euphon.net \
--cc=hreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=pierrick.bouvier@oss.qualcomm.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.