Re: [PATCH v16 1/6] phy: core: add notifier infrastructure

[Vinod Koul <vkoul@kernel.org>]

Hello Sebastian,

On 24-09-26, 19:25, Sebastian Reichel wrote:
> Some PHY devices with multiple ports (e.g. USB3 and DP) require a reset
> if the configuration changes or cable orientation changes. This is a
> problem, as the consumer device will run into undefined behavior.
> 
> With the new PHY notifier API introduced in this patch, the consumer
> driver can hook into reset events coming from a PHY device to handle the
> PHY going down gracefully.
> 
> Note that this uses -ENOSYS instead of the more sensible -ENOTSUP for
> the stub functions when GENERIC_PHY is disabled to stay consistent with
> the existing ones.

I dont think this series has the usage of this.

I think I am still not convinced why a phy should notify as I dont feel
we have any mechanism to notifying. Checking status and letting people
know if not really a notification mechanism... Maybe add a status call
instead?

-- 
~Vinod

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip