[Buildroot] [PATCH 1/2] package/setserial: CPE ID for setserial

[Buildroot] [PATCH 1/2] package/setserial: CPE ID for setserial

[Bjørn Damstedt Rasmussen]

This allows setserial to be checked for CVEs.

Signed-off-by: Bjørn Damstedt Rasmussen <contact@bearware.dk>
---
 package/setserial/setserial.mk | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/package/setserial/setserial.mk b/package/setserial/setserial.mk
index 9beee349c8..bba8dfdb88 100644
--- a/package/setserial/setserial.mk
+++ b/package/setserial/setserial.mk
@@ -10,6 +10,9 @@ SETSERIAL_SITE = https://snapshot.debian.org/archive/debian/20250307T084701Z/poo
 SETSERIAL_EXTRA_DOWNLOADS = setserial_$(SETSERIAL_VERSION)-57.debian.tar.xz
 SETSERIAL_LICENSE = GPL-2.0
 SETSERIAL_LICENSE_FILES = debian/copyright
+SETSERIAL_CPE_ID_VENDOR = setserial_project
+SETSERIAL_CPE_ID_PRODUCT = setserial
+
 # make all also builds setserial.cat which needs nroff
 SETSERIAL_MAKE_OPTS = setserial
 
-- 
2.53.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 2/2] package/openjdk: CPE ID for openjdk

[Bjørn Damstedt Rasmussen]

This allows OpenJDK to checked for CVEs.

The automatically generated OPENJDK_CPE_ID_VERSION cannot be used
because OPENJDK_VERSION includes a '+', e.g. "25.0.2+10". NVD will not
accept a version number with '+'.

Signed-off-by: Bjørn Damstedt Rasmussen <contact@bearware.dk>
---
 package/openjdk/openjdk.mk | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/package/openjdk/openjdk.mk b/package/openjdk/openjdk.mk
index fbc860019c..10e0f76ad7 100644
--- a/package/openjdk/openjdk.mk
+++ b/package/openjdk/openjdk.mk
@@ -17,6 +17,12 @@ OPENJDK_VERSION_MAJOR = 17
 OPENJDK_VERSION_MINOR = 0.18
 OPENJDK_VERSION_BUILD = 8
 endif
+
+OPENJDK_CPE_ID_VENDOR = oracle
+OPENJDK_CPE_ID_PRODUCT = openjdk
+# Override automatic CPE ID because '+' in $(OPENJDK_VERSION) is an invalid for CPE check
+OPENJDK_CPE_ID_VERSION = $(OPENJDK_VERSION_MAJOR).$(OPENJDK_VERSION_MINOR)
+
 OPENJDK_VERSION = $(OPENJDK_VERSION_MAJOR).$(OPENJDK_VERSION_MINOR)+$(OPENJDK_VERSION_BUILD)
 OPENJDK_SITE = $(call github,openjdk,jdk$(OPENJDK_VERSION_MAJOR)u,jdk-$(OPENJDK_VERSION))
 
-- 
2.53.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/2] package/setserial: CPE ID for setserial

[Thomas Petazzoni via buildroot]

Hello Bjørn,

On Fri, Oct 02, 2026 at 10:29:34PM +0200, Bjørn Damstedt Rasmussen wrote:
> This allows setserial to be checked for CVEs.
> 
> Signed-off-by: Bjørn Damstedt Rasmussen <contact@bearware.dk>

Thanks a lot for your two patches. Could you provide in each commit
message some evidence that the added CPE vendor/product information is
correct?

> diff --git a/package/setserial/setserial.mk b/package/setserial/setserial.mk
> index 9beee349c8..bba8dfdb88 100644
> --- a/package/setserial/setserial.mk
> +++ b/package/setserial/setserial.mk
> @@ -10,6 +10,9 @@ SETSERIAL_SITE = https://snapshot.debian.org/archive/debian/20250307T084701Z/poo
>  SETSERIAL_EXTRA_DOWNLOADS = setserial_$(SETSERIAL_VERSION)-57.debian.tar.xz
>  SETSERIAL_LICENSE = GPL-2.0
>  SETSERIAL_LICENSE_FILES = debian/copyright
> +SETSERIAL_CPE_ID_VENDOR = setserial_project
> +SETSERIAL_CPE_ID_PRODUCT = setserial

These are already the default values for those variables, so how does
this help?

If it's all a matter of telling Buildroot that the CPE identification
information has been checked, then:

SETSERIAL_CPE_ID_VALID = YES

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 2/2] package/openjdk: CPE ID for openjdk

[Thomas Petazzoni via buildroot]

Hello,

On Fri, Oct 02, 2026 at 10:29:35PM +0200, Bjørn Damstedt Rasmussen wrote:
> This allows OpenJDK to checked for CVEs.
> 
> The automatically generated OPENJDK_CPE_ID_VERSION cannot be used
> because OPENJDK_VERSION includes a '+', e.g. "25.0.2+10". NVD will not
> accept a version number with '+'.

Could you add some evidence in the commit message that these are the
correct CPE identifierS?

> +OPENJDK_CPE_ID_VENDOR = oracle
> +OPENJDK_CPE_ID_PRODUCT = openjdk

This line is not needed, as it's already the default.

> +# Override automatic CPE ID because '+' in $(OPENJDK_VERSION) is an invalid for CPE check
> +OPENJDK_CPE_ID_VERSION = $(OPENJDK_VERSION_MAJOR).$(OPENJDK_VERSION_MINOR)

Also, should the same information be added to the openjdk-bin package?

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 2/2] package/openjdk: CPE ID for openjdk

[Bjørn Damstedt Rasmussen]

The CPE ID on version 21.0.2 in NVD:
https://nvd.nist.gov/products/cpe/search/results?keyword=cpe:2.3:a:oracle:openjdk:21.0.2:*:*:*:*:*:*:*

The automatically generated OPENJDK_CPE_ID_VERSION cannot be used
because OPENJDK_VERSION includes a '+', e.g. "21.0.2+10". NVD will not
accept a version number with '+'.

Signed-off-by: Bjørn Damstedt Rasmussen <contact@bearware.dk>
---
 package/openjdk/openjdk.mk | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/package/openjdk/openjdk.mk b/package/openjdk/openjdk.mk
index fbc860019c..95efe2ba19 100644
--- a/package/openjdk/openjdk.mk
+++ b/package/openjdk/openjdk.mk
@@ -17,6 +17,13 @@ OPENJDK_VERSION_MAJOR = 17
 OPENJDK_VERSION_MINOR = 0.18
 OPENJDK_VERSION_BUILD = 8
 endif
+
+OPENJDK_CPE_ID_VENDOR = oracle
+OPENJDK_CPE_ID_VALID = YES
+
+# Override automatic CPE ID because '+' in $(OPENJDK_VERSION) is not alphanumeric or ._-
+OPENJDK_CPE_ID_VERSION = $(OPENJDK_VERSION_MAJOR).$(OPENJDK_VERSION_MINOR)
+
 OPENJDK_VERSION = $(OPENJDK_VERSION_MAJOR).$(OPENJDK_VERSION_MINOR)+$(OPENJDK_VERSION_BUILD)
 OPENJDK_SITE = $(call github,openjdk,jdk$(OPENJDK_VERSION_MAJOR)u,jdk-$(OPENJDK_VERSION))
 
-- 
2.53.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 2/2] package/openjdk: CPE ID for openjdk

[Thomas Petazzoni via buildroot]

Hello Bjørn,

On Sat, Oct 03, 2026 at 07:36:57PM +0200, Bjørn Damstedt Rasmussen wrote:
> The CPE ID on version 21.0.2 in NVD:
> https://nvd.nist.gov/products/cpe/search/results?keyword=cpe:2.3:a:oracle:openjdk:21.0.2:*:*:*:*:*:*:*
> 
> The automatically generated OPENJDK_CPE_ID_VERSION cannot be used
> because OPENJDK_VERSION includes a '+', e.g. "21.0.2+10". NVD will not
> accept a version number with '+'.
> 
> Signed-off-by: Bjørn Damstedt Rasmussen <contact@bearware.dk>
> ---
>  package/openjdk/openjdk.mk | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/package/openjdk/openjdk.mk b/package/openjdk/openjdk.mk
> index fbc860019c..95efe2ba19 100644
> --- a/package/openjdk/openjdk.mk
> +++ b/package/openjdk/openjdk.mk
> @@ -17,6 +17,13 @@ OPENJDK_VERSION_MAJOR = 17
>  OPENJDK_VERSION_MINOR = 0.18
>  OPENJDK_VERSION_BUILD = 8
>  endif
> +
> +OPENJDK_CPE_ID_VENDOR = oracle
> +OPENJDK_CPE_ID_VALID = YES
> +
> +# Override automatic CPE ID because '+' in $(OPENJDK_VERSION) is not alphanumeric or ._-
> +OPENJDK_CPE_ID_VERSION = $(OPENJDK_VERSION_MAJOR).$(OPENJDK_VERSION_MINOR)
> +
>  OPENJDK_VERSION = $(OPENJDK_VERSION_MAJOR).$(OPENJDK_VERSION_MINOR)+$(OPENJDK_VERSION_BUILD)
>  OPENJDK_SITE = $(call github,openjdk,jdk$(OPENJDK_VERSION_MAJOR)u,jdk-$(OPENJDK_VERSION))

Thanks for the v2! However this was causing some check-package
warnings, for valid reasons:

WARNING: package/openjdk/openjdk.mk:25: expecting package version to be set before CPE_ID_VERSION
WARNING: package/openjdk/openjdk.mk:22: 'YES' is implied when a non-default CPE_ID field is specified: OPENJDK_CPE_ID_VALID = YES (https://nightly.buildroot.org/#cpe-id)

<pkg>_CPE_ID_VALID = YES is only useful when no other CPE_ID_*
variable is set. As soon as you set CPE_ID_VENDOR, CPE_ID_PRODUCT,
CPE_ID_VERSION, etc. we assume that someone has checked the CPE
identifier, and therefore we assume that the CPE identifier is valid
(and we set CPE_ID_VALID = YES). Therefore, setting CPE_ID_VALID = YES
is redundant in your patch.

For the CPE_ID_VERSION calculation, for consistency we like to see it
defined after the package version.

I fixed that up when applying. Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 2/2] package/openjdk: CPE ID for openjdk

[Thomas Perale via buildroot]

In reply of:
> The CPE ID on version 21.0.2 in NVD:
> https://nvd.nist.gov/products/cpe/search/results?keyword=cpe:2.3:a:oracle:openjdk:21.0.2:*:*:*:*:*:*:*
> 
> The automatically generated OPENJDK_CPE_ID_VERSION cannot be used
> because OPENJDK_VERSION includes a '+', e.g. "21.0.2+10". NVD will not
> accept a version number with '+'.
> 
> Signed-off-by: Bjørn Damstedt Rasmussen <contact@bearware.dk>

Applied to 2025.02.x & 2026.08.x. Thanks

> ---
>  package/openjdk/openjdk.mk | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/package/openjdk/openjdk.mk b/package/openjdk/openjdk.mk
> index fbc860019c..95efe2ba19 100644
> --- a/package/openjdk/openjdk.mk
> +++ b/package/openjdk/openjdk.mk
> @@ -17,6 +17,13 @@ OPENJDK_VERSION_MAJOR = 17
>  OPENJDK_VERSION_MINOR = 0.18
>  OPENJDK_VERSION_BUILD = 8
>  endif
> +
> +OPENJDK_CPE_ID_VENDOR = oracle
> +OPENJDK_CPE_ID_VALID = YES
> +
> +# Override automatic CPE ID because '+' in $(OPENJDK_VERSION) is not alphanumeric or ._-
> +OPENJDK_CPE_ID_VERSION = $(OPENJDK_VERSION_MAJOR).$(OPENJDK_VERSION_MINOR)
> +
>  OPENJDK_VERSION = $(OPENJDK_VERSION_MAJOR).$(OPENJDK_VERSION_MINOR)+$(OPENJDK_VERSION_BUILD)
>  OPENJDK_SITE = $(call github,openjdk,jdk$(OPENJDK_VERSION_MAJOR)u,jdk-$(OPENJDK_VERSION))
>  
> -- 
> 2.53.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot