From: Jarkko Sakkinen <jarkko@kernel.org>
To: keyrings@vger.kernel.org
Cc: Jann Horn <jannh@google.com>,
linux-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org,
David Howells <dhowells@redhat.com>,
Paul Moore <paul@paul-moore.com>,
James Morris <jmorris@namei.org>,
"Serge E. Hallyn" <serge@hallyn.com>
Subject: Re: [RFC PATCH 0/2] keys: Address lookup_user_key() mutability
Date: Sun, 4 Oct 2026 20:54:06 +0300 [thread overview]
Message-ID: <asKSvjz2YLZhFI4t@kernel.org> (raw)
In-Reply-To: <20260924055521.1981957-1-jarkko@kernel.org>
On Thu, Sep 24, 2026 at 08:55:16AM +0300, Jarkko Sakkinen wrote:
> The main objective in these patches is to remove to unneeded mutability
> from key look ups. It does harm and brings no value so it is pretty obvious
> to me that addressing this harmful behaviour is what we should do.
>
> I based the first patch on what Jann suggested in [1]. Nothing too clever here
> and I'm ofc open for further suggestions.
>
> [1] https://lore.kernel.org/keyrings/CAG48ez0XjVSR=M--UBauTm8sJuc+ZbhKzaPa3a6wrSVHyoKevw@mail.gmail.com/
>
> Jarkko Sakkinen (2):
> keys: Return user session keyring on lookup
> keys: Reject keyring creation with overridden credentials
>
> Documentation/security/keys/core.rst | 7 ++-
> security/keys/process_keys.c | 65 +++++++++++++++-------------
> 2 files changed, 40 insertions(+), 32 deletions(-)
>
> --
> 2.47.3
>
So.. should I move forward to with non-RFC v2?
Note that some tags (e.g., Fixes) are missing simply because this is RFC.
Br, Jarkko
next prev parent reply other threads:[~2026-10-04 17:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-24 5:55 [RFC PATCH 0/2] keys: Address lookup_user_key() mutability Jarkko Sakkinen
2026-09-24 5:55 ` [RFC PATCH 1/2] keys: Return user session keyring on lookup Jarkko Sakkinen
2026-09-24 6:01 ` sashiko-bot
2026-09-24 5:55 ` [RFC PATCH 2/2] keys: Reject keyring creation with overridden credentials Jarkko Sakkinen
2026-09-24 6:03 ` sashiko-bot
2026-10-04 17:54 ` Jarkko Sakkinen [this message]
2026-10-05 13:09 ` [RFC PATCH 0/2] keys: Address lookup_user_key() mutability Serge E. Hallyn
2026-10-05 18:46 ` Jarkko Sakkinen
2026-10-06 18:52 ` Serge Hallyn (AMD)
2026-10-08 14:26 ` Jarkko Sakkinen
2026-10-08 15:25 ` Serge E. Hallyn
2026-10-08 20:00 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=asKSvjz2YLZhFI4t@kernel.org \
--to=jarkko@kernel.org \
--cc=dhowells@redhat.com \
--cc=jannh@google.com \
--cc=jmorris@namei.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=paul@paul-moore.com \
--cc=serge@hallyn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.