* [PATCH] fs/iomap: document ret parameter of iomap_iter_continue
@ 2026-10-06 15:40 Muhammad Mahdi Amirpour
2026-10-07 13:08 ` Christoph Hellwig
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Muhammad Mahdi Amirpour @ 2026-10-06 15:40 UTC (permalink / raw)
To: Christian Brauner
Cc: Darrick J . Wong, linux-xfs, linux-fsdevel, linux-kernel,
Muhammad Mahdi Amirpour
Document the ret parameter of iomap_iter_continue to avoid a
kernel-doc warning.
Signed-off-by: Muhammad Mahdi Amirpour <ampr.mhd@gmail.com>
---
fs/iomap/iter.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/fs/iomap/iter.c b/fs/iomap/iter.c
index c445a38b6..fd8791c49 100644
--- a/fs/iomap/iter.c
+++ b/fs/iomap/iter.c
@@ -51,6 +51,7 @@ static inline void iomap_iter_done(struct iomap_iter *iter)
* @iter: iteration structure
* @iomap: the mapping that was just processed
* @srcmap: the source mapping that was just processed
+ * @ret: return value from the previous mapping's ->end() callback
*
* Helper normally called via iomap_iter_next(). Called after the previous
* mapping has been finished to determine whether there is more of the file
--
2.55.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] fs/iomap: document ret parameter of iomap_iter_continue
2026-10-06 15:40 [PATCH] fs/iomap: document ret parameter of iomap_iter_continue Muhammad Mahdi Amirpour
@ 2026-10-07 13:08 ` Christoph Hellwig
2026-10-07 16:31 ` Jeremy Bingham
2026-10-12 14:25 ` Christian Brauner
2 siblings, 0 replies; 4+ messages in thread
From: Christoph Hellwig @ 2026-10-07 13:08 UTC (permalink / raw)
To: Muhammad Mahdi Amirpour
Cc: Christian Brauner, Darrick J . Wong, linux-xfs, linux-fsdevel,
linux-kernel
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] fs/iomap: document ret parameter of iomap_iter_continue
2026-10-06 15:40 [PATCH] fs/iomap: document ret parameter of iomap_iter_continue Muhammad Mahdi Amirpour
2026-10-07 13:08 ` Christoph Hellwig
@ 2026-10-07 16:31 ` Jeremy Bingham
2026-10-12 14:25 ` Christian Brauner
2 siblings, 0 replies; 4+ messages in thread
From: Jeremy Bingham @ 2026-10-07 16:31 UTC (permalink / raw)
To: ampr.mhd; +Cc: brauner, djwong, linux-fsdevel, linux-kernel, Jeremy Bingham
It's a useful documentation only change, and documenting what ret does
there seems useful. For whatever it's worth,
Reviewed-by: Jeremy Bingham <jbingham@gmail.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] fs/iomap: document ret parameter of iomap_iter_continue
2026-10-06 15:40 [PATCH] fs/iomap: document ret parameter of iomap_iter_continue Muhammad Mahdi Amirpour
2026-10-07 13:08 ` Christoph Hellwig
2026-10-07 16:31 ` Jeremy Bingham
@ 2026-10-12 14:25 ` Christian Brauner
2 siblings, 0 replies; 4+ messages in thread
From: Christian Brauner @ 2026-10-12 14:25 UTC (permalink / raw)
To: Muhammad Mahdi Amirpour
Cc: Darrick J . Wong, linux-xfs, linux-fsdevel, linux-kernel
On Tue, 06 Oct 2026 19:10:05 +0330, Muhammad Mahdi Amirpour wrote:
> Document the ret parameter of iomap_iter_continue to avoid a
> kernel-doc warning.
Applied to the vfs-7.4.iomap branch of the vfs/vfs.git tree.
Patches in the vfs-7.4.iomap branch should appear in linux-next soon.
Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.
It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.
Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs-7.4.iomap
[1/1] fs/iomap: document ret parameter of iomap_iter_continue
https://git.kernel.org/vfs/vfs/c/92e2f4295403
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-10-12 14:25 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-10-06 15:40 [PATCH] fs/iomap: document ret parameter of iomap_iter_continue Muhammad Mahdi Amirpour
2026-10-07 13:08 ` Christoph Hellwig
2026-10-07 16:31 ` Jeremy Bingham
2026-10-12 14:25 ` Christian Brauner
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.