Re: [PATCH v2 3/3] iotests/migrate-bitmaps-postcopy-test: add a bitmap on a second node

[Eric Blake <eblake@redhat.com>]

On Tue, Oct 06, 2026 at 07:07:38PM +0200, Denis V. Lunev wrote:
> From: Denis V. Lunev <den@openvz.org>
> 
> All bitmaps in the test live on drive0, so the source never switches
> nodes after setup and the destination never resolves a node name from
> the postcopy listen thread. Add a second drive with one bitmap and check
> that it arrives intact.
> 
> Signed-off-by: Denis V. Lunev <den@openvz.org>
> Tested-by: Eric Blake <eblake@redhat.com>
> Reviewed-by: Eric Blake <eblake@redhat.com>
> Cc: Peter Xu <peterx@redhat.com>
> Cc: Fabiano Rosas <farosas@suse.de>
> Cc: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
> ---
>  .../tests/migrate-bitmaps-postcopy-test       | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)

While playing with this patch series, I sent SIGINT mid-test, and then
all subsequent runs failed...

>      def setUp(self):
>          os.mkfifo(fifo)

because fifo was not cleanly removed on the preceeding run, but mkfifo
wasn't expecting it to already exist.  I'm squashing in this fix, even
though it was a pre-existing issue:

diff --git i/tests/qemu-iotests/tests/migrate-bitmaps-postcopy-test w/tests/qemu-iotests/tests/migrate-bitmaps-postcopy-test
index b2b37ada4b2..817a9216e58 100755
--- i/tests/qemu-iotests/tests/migrate-bitmaps-postcopy-test
+++ w/tests/qemu-iotests/tests/migrate-bitmaps-postcopy-test
@@ -100,6 +100,8 @@ class TestDirtyBitmapPostcopyMigration(iotests.QMPTestCase):
         os.remove(fifo)

     def setUp(self):
+        if os.path.exists(fifo):
+            os.remove(fifo)
         os.mkfifo(fifo)
         qemu_img('create', '-f', iotests.imgfmt, disk_a, size)
         qemu_img('create', '-f', iotests.imgfmt, disk_b, size)


-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.
Virtualization:  qemu.org | libguestfs.org