Re: [PATCH v2 1/3] migration: add QEMU_COUNTED_STRING_SIZE for counted string buffers

[Eric Blake <eblake@redhat.com>]

On Tue, Oct 06, 2026 at 07:07:36PM +0200, Denis V. Lunev wrote:
> From: Denis V. Lunev <den@openvz.org>
> 
> A counted string carries its length in one byte, so the buffer that
> qemu_get_counted_string() fills must hold 256 bytes. The dirty bitmap
> load state spells that size as a bare 256 for both of its alias buffers.
> Name it next to the qemu_get_counted_string() prototype and use it there,
> in the length assert of qemu_put_counted_string() and in DBMLoadState.
> 
> Suggested-by: Eric Blake <eblake@redhat.com>
> Signed-off-by: Denis V. Lunev <den@openvz.org>
> Cc: Peter Xu <peterx@redhat.com>
> Cc: Fabiano Rosas <farosas@suse.de>
> Cc: Eric Blake <eblake@redhat.com>
> Cc: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
> Cc: qemu-stable@nongnu.org
> ---
>  include/migration/qemu-file-types.h | 6 +++++-
>  migration/block-dirty-bitmap.c      | 4 ++--
>  migration/qemu-file.c               | 5 +++--
>  3 files changed, 10 insertions(+), 5 deletions(-)

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.
Virtualization:  qemu.org | libguestfs.org