* [PATCH] PCI: layerscape: async probe by default
@ 2026-09-28 13:48 ` Vincent Jardin via B4 Relay
0 siblings, 0 replies; 5+ messages in thread
From: Vincent Jardin @ 2026-09-28 13:48 UTC (permalink / raw)
To: Minghuan Lian, Mingkai Hu, Roy Zang, Lorenzo Pieralisi,
Krzysztof Wilczyński, Manivannan Sadhasivam, Rob Herring,
Bjorn Helgaas, Ioana Ciornei, Vladimir Oltean
Cc: linuxppc-dev, linux-pci, linux-arm-kernel, imx, linux-kernel,
Vincent Jardin
dw_pcie_wait_for_link() polls for up to
PCIE_LINK_WAIT_MAX_RETRIES x PCIE_LINK_WAIT_SLEEP_MS (10 x 90 ms)
per controller.
The controllers are probed one after the other, so, it leads to slow
boot time.
On an LX2160A board with 4 enabled controllers and no link on any
of them, ls_pcie_driver_init took almost 4s.
Probing the 4 in parallel allows to have it down to 1s.
The controllers are independent, other DWC based drivers are already
using async probing such as qcom, imx6, s32g, rcar-gen4 or stm32.
Signed-off-by: Vincent Jardin <vjardin@free.fr>
---
drivers/pci/controller/dwc/pci-layerscape.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/pci/controller/dwc/pci-layerscape.c b/drivers/pci/controller/dwc/pci-layerscape.c
index 14d6ac4fc53f..7f37a0537159 100644
--- a/drivers/pci/controller/dwc/pci-layerscape.c
+++ b/drivers/pci/controller/dwc/pci-layerscape.c
@@ -419,6 +419,7 @@ static struct platform_driver ls_pcie_driver = {
.of_match_table = ls_pcie_of_match,
.suppress_bind_attrs = true,
.pm = &ls_pcie_pm_ops,
+ .probe_type = PROBE_PREFER_ASYNCHRONOUS,
},
};
module_platform_driver(ls_pcie_driver);
---
base-commit: 94e8d4e94266bb9737a5963810a3f9365cb2f39d
change-id: 20260928-for-upstream-pci-layerscape-async-probe-084cae5d0907
Best regards,
--
Vincent Jardin <vjardin@free.fr>
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH] PCI: layerscape: async probe by default
@ 2026-09-28 13:48 ` Vincent Jardin via B4 Relay
0 siblings, 0 replies; 5+ messages in thread
From: Vincent Jardin via B4 Relay @ 2026-09-28 13:48 UTC (permalink / raw)
To: Minghuan Lian, Mingkai Hu, Roy Zang, Lorenzo Pieralisi,
Krzysztof Wilczyński, Manivannan Sadhasivam, Rob Herring,
Bjorn Helgaas, Ioana Ciornei, Vladimir Oltean
Cc: linuxppc-dev, linux-pci, linux-arm-kernel, imx, linux-kernel,
Vincent Jardin
From: Vincent Jardin <vjardin@free.fr>
dw_pcie_wait_for_link() polls for up to
PCIE_LINK_WAIT_MAX_RETRIES x PCIE_LINK_WAIT_SLEEP_MS (10 x 90 ms)
per controller.
The controllers are probed one after the other, so, it leads to slow
boot time.
On an LX2160A board with 4 enabled controllers and no link on any
of them, ls_pcie_driver_init took almost 4s.
Probing the 4 in parallel allows to have it down to 1s.
The controllers are independent, other DWC based drivers are already
using async probing such as qcom, imx6, s32g, rcar-gen4 or stm32.
Signed-off-by: Vincent Jardin <vjardin@free.fr>
---
drivers/pci/controller/dwc/pci-layerscape.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/pci/controller/dwc/pci-layerscape.c b/drivers/pci/controller/dwc/pci-layerscape.c
index 14d6ac4fc53f..7f37a0537159 100644
--- a/drivers/pci/controller/dwc/pci-layerscape.c
+++ b/drivers/pci/controller/dwc/pci-layerscape.c
@@ -419,6 +419,7 @@ static struct platform_driver ls_pcie_driver = {
.of_match_table = ls_pcie_of_match,
.suppress_bind_attrs = true,
.pm = &ls_pcie_pm_ops,
+ .probe_type = PROBE_PREFER_ASYNCHRONOUS,
},
};
module_platform_driver(ls_pcie_driver);
---
base-commit: 94e8d4e94266bb9737a5963810a3f9365cb2f39d
change-id: 20260928-for-upstream-pci-layerscape-async-probe-084cae5d0907
Best regards,
--
Vincent Jardin <vjardin@free.fr>
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] PCI: layerscape: async probe by default
2026-09-28 13:48 ` Vincent Jardin via B4 Relay
(?)
@ 2026-09-28 13:55 ` sashiko-bot
-1 siblings, 0 replies; 5+ messages in thread
From: sashiko-bot @ 2026-09-28 13:55 UTC (permalink / raw)
To: Vincent Jardin; +Cc: linux-pci, Frank.Li, imx
> From: Vincent Jardin <vjardin@free.fr>
>
> dw_pcie_wait_for_link() polls for up to
> PCIE_LINK_WAIT_MAX_RETRIES x PCIE_LINK_WAIT_SLEEP_MS (10 x 90 ms)
> per controller.
>
> The controllers are probed one after the other, so, it leads to slow
> boot time.
>
> On an LX2160A board with 4 enabled controllers and no link on any
> of them, ls_pcie_driver_init took almost 4s.
>
> Probing the 4 in parallel allows to have it down to 1s.
>
> The controllers are independent, other DWC based drivers are already
> using async probing such as qcom, imx6, s32g, rcar-gen4 or stm32.
>
> Signed-off-by: Vincent Jardin <vjardin@free.fr>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260928-for-upstream-pci-layerscape-async-probe-v1-1-76412d887baa@free.fr?part=1
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] PCI: layerscape: async probe by default
2026-09-28 13:48 ` Vincent Jardin via B4 Relay
(?)
(?)
@ 2026-09-28 16:14 ` Frank Li
2026-10-07 17:38 ` Vincent Jardin
-1 siblings, 1 reply; 5+ messages in thread
From: Frank Li @ 2026-09-28 16:14 UTC (permalink / raw)
To: vjardin
Cc: Minghuan Lian, Mingkai Hu, Roy Zang, Lorenzo Pieralisi,
Krzysztof Wilczyński, Manivannan Sadhasivam, Rob Herring,
Bjorn Helgaas, Ioana Ciornei, Vladimir Oltean, linuxppc-dev,
linux-pci, linux-arm-kernel, imx, linux-kernel
On Mon, Sep 28, 2026 at 03:48:09PM +0200, Vincent Jardin via B4 Relay wrote:
> From: Vincent Jardin <vjardin@free.fr>
>
> dw_pcie_wait_for_link() polls for up to
> PCIE_LINK_WAIT_MAX_RETRIES x PCIE_LINK_WAIT_SLEEP_MS (10 x 90 ms)
> per controller.
>
> The controllers are probed one after the other, so, it leads to slow
> boot time.
>
> On an LX2160A board with 4 enabled controllers and no link on any
> of them, ls_pcie_driver_init took almost 4s.
>
> Probing the 4 in parallel allows to have it down to 1s.
>
> The controllers are independent, other DWC based drivers are already
> using async probing such as qcom, imx6, s32g, rcar-gen4 or stm32.
>
> Signed-off-by: Vincent Jardin <vjardin@free.fr>
> ---
Reviewed-by: Frank Li <Frank.Li@nxp.com>
> drivers/pci/controller/dwc/pci-layerscape.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pci/controller/dwc/pci-layerscape.c b/drivers/pci/controller/dwc/pci-layerscape.c
> index 14d6ac4fc53f..7f37a0537159 100644
> --- a/drivers/pci/controller/dwc/pci-layerscape.c
> +++ b/drivers/pci/controller/dwc/pci-layerscape.c
> @@ -419,6 +419,7 @@ static struct platform_driver ls_pcie_driver = {
> .of_match_table = ls_pcie_of_match,
> .suppress_bind_attrs = true,
> .pm = &ls_pcie_pm_ops,
> + .probe_type = PROBE_PREFER_ASYNCHRONOUS,
> },
> };
> module_platform_driver(ls_pcie_driver);
>
> ---
> base-commit: 94e8d4e94266bb9737a5963810a3f9365cb2f39d
> change-id: 20260928-for-upstream-pci-layerscape-async-probe-084cae5d0907
>
> Best regards,
> --
> Vincent Jardin <vjardin@free.fr>
>
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] PCI: layerscape: async probe by default
2026-09-28 16:14 ` Frank Li
@ 2026-10-07 17:38 ` Vincent Jardin
0 siblings, 0 replies; 5+ messages in thread
From: Vincent Jardin @ 2026-10-07 17:38 UTC (permalink / raw)
To: Manivannan Sadhasivam, Lorenzo Pieralisi,
Krzysztof Wilczy´nski, Bjorn Helgaas
Cc: Minghuan Lian, Mingkai Hu, Roy Zang, Rob Herring, Frank Li,
Ioana Ciornei, Vladimir Oltean, linuxppc-dev, linux-pci,
linux-arm-kernel, imx, linux-kernel
Hi,
A gentle ping on this one lin paatch: is there anything else you'd need from me
to have it applied for v7.4 ?
It has the Frank Li's Reviewed-by, Sashiko found no issue, and it still
applies cleanly on the current pci/next from today.
https://patchwork.kernel.org/project/linux-pci/patch/20260928-for-upstream-pci-layerscape-async-probe-v1-1-76412d887baa@free.fr/
Best regards,
Vincent
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2026-10-07 17:39 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-28 13:48 [PATCH] PCI: layerscape: async probe by default Vincent Jardin
2026-09-28 13:48 ` Vincent Jardin via B4 Relay
2026-09-28 13:55 ` sashiko-bot
2026-09-28 16:14 ` Frank Li
2026-10-07 17:38 ` Vincent Jardin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.