All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Input: xpad - add support for 8BitDo Pro 2 Wired Controller for Xbox
@ 2026-09-25  9:24 Bihaan Sen
  2026-09-25  9:29 ` sashiko-bot
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Bihaan Sen @ 2026-09-25  9:24 UTC (permalink / raw)
  To: Dmitry Torokhov; +Cc: linux-input, linux-kernel, Bihaan Sen

The 8BitDo Pro 2 Wired Controller for Xbox is already matched by the
vendor-wide XPAD_XBOXONE_VENDOR(0x2dc8) entry, but a later hardware
revision reports product ID 0x201e, which has no entry in the
xpad_device table. The device therefore binds and functions but is
exposed to userspace as "Generic X-Box pad".

Add the VID/PID pair so the controller is named correctly.

Signed-off-by: Bihaan Sen <stevewholikesthings@gmail.com>
---
 drivers/input/joystick/xpad.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c
index feb8f368f834..e7af88bfb8da 100644
--- a/drivers/input/joystick/xpad.c
+++ b/drivers/input/joystick/xpad.c
@@ -371,6 +371,7 @@ static const struct xpad_device {
 	{ 0x294b, 0x3404, "Snakebyte GAMEPAD RGB X", 0, XTYPE_XBOXONE },
 	{ 0x2993, 0x2001, "TECNO Pocket Go", 0, XTYPE_XBOX360 },
 	{ 0x2dc8, 0x2000, "8BitDo Pro 2 Wired Controller fox Xbox", 0, XTYPE_XBOXONE },
+	{ 0x2dc8, 0x201e, "8BitDo Pro 2 Wired Controller for Xbox", 0, XTYPE_XBOXONE },
 	{ 0x2dc8, 0x200f, "8BitDo Ultimate 3-mode Controller for Xbox", MAP_SHARE_BUTTON, XTYPE_XBOXONE },
 	{ 0x2dc8, 0x3106, "8BitDo Ultimate Wireless / Pro 2 Wired Controller", 0, XTYPE_XBOX360 },
 	{ 0x2dc8, 0x3109, "8BitDo Ultimate Wireless Bluetooth", 0, XTYPE_XBOX360 },
-- 
2.55.0


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] Input: xpad - add support for 8BitDo Pro 2 Wired Controller for Xbox
  2026-09-25  9:24 [PATCH] Input: xpad - add support for 8BitDo Pro 2 Wired Controller for Xbox Bihaan Sen
@ 2026-09-25  9:29 ` sashiko-bot
  2026-09-25 11:17 ` [PATCH v2] " Bihaan Sen
  2026-09-25 11:44 ` [PATCH v3] " Bihaan Sen
  2 siblings, 0 replies; 5+ messages in thread
From: sashiko-bot @ 2026-09-25  9:29 UTC (permalink / raw)
  To: Bihaan Sen; +Cc: dmitry.torokhov, linux-input

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] input: xpad: out-of-order xpad_device array entry
--

commit db3ad191bb5f3c117f65ad725be0401f7c92d4d6
Author: Bihaan Sen <stevewholikesthings@gmail.com>

Input: xpad - add support for 8BitDo Pro 2 Wired Controller for Xbox

This commit adds a new VID/PID pair (0x2dc8/0x201e) to the xpad_device
table for a later hardware revision of the 8BitDo Pro 2 Wired Controller,
ensuring it is named correctly instead of defaulting to "Generic X-Box pad".

> diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c
> index feb8f368f834e..e7af88bfb8da5 100644
> --- a/drivers/input/joystick/xpad.c
> +++ b/drivers/input/joystick/xpad.c
> @@ -371,6 +371,7 @@ static const struct xpad_device {
>  	{ 0x294b, 0x3404, "Snakebyte GAMEPAD RGB X", 0, XTYPE_XBOXONE },
>  	{ 0x2993, 0x2001, "TECNO Pocket Go", 0, XTYPE_XBOX360 },
>  	{ 0x2dc8, 0x2000, "8BitDo Pro 2 Wired Controller fox Xbox", 0, XTYPE_XBOXONE },
> +	{ 0x2dc8, 0x201e, "8BitDo Pro 2 Wired Controller for Xbox", 0, XTYPE_XBOXONE },
>  	{ 0x2dc8, 0x200f, "8BitDo Ultimate 3-mode Controller for Xbox", MAP_SHARE_BUTTON, XTYPE_XBOXONE },

[Severity: Low]
Is this entry slightly out of order? The xpad_device array is typically kept
sorted numerically by Vendor ID and then Product ID. Since the Product ID
0x201e is greater than 0x200f, should this new entry be placed after it
instead?

>  	{ 0x2dc8, 0x3106, "8BitDo Ultimate Wireless / Pro 2 Wired Controller", 0, XTYPE_XBOX360 },
>  	{ 0x2dc8, 0x3109, "8BitDo Ultimate Wireless Bluetooth", 0, XTYPE_XBOX360 },

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260925092439.79904-1-stevewholikesthings@gmail.com?part=1

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH v2] Input: xpad - add support for 8BitDo Pro 2 Wired Controller for Xbox
  2026-09-25  9:24 [PATCH] Input: xpad - add support for 8BitDo Pro 2 Wired Controller for Xbox Bihaan Sen
  2026-09-25  9:29 ` sashiko-bot
@ 2026-09-25 11:17 ` Bihaan Sen
  2026-09-25 11:44 ` [PATCH v3] " Bihaan Sen
  2 siblings, 0 replies; 5+ messages in thread
From: Bihaan Sen @ 2026-09-25 11:17 UTC (permalink / raw)
  To: Dmitry Torokhov; +Cc: linux-input, linux-kernel, Bihaan Sen

The 8BitDo Pro 2 Wired Controller for Xbox is already matched by the
vendor-wide XPAD_XBOXONE_VENDOR(0x2dc8) entry, but a later hardware
revision reports product ID 0x201e, which has no entry in the
xpad_device table. The device therefore binds and functions but is
exposed to userspace as "Generic X-Box pad".

Add the VID/PID pair so the controller is named correctly.

Signed-off-by: Bihaan Sen <stevewholikesthings@gmail.com>
---
v2: move the entry after 0x200f to keep xpad_device sorted by product ID

 drivers/input/joystick/xpad.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c
index feb8f368f834..39e835dab9df 100644
--- a/drivers/input/joystick/xpad.c
+++ b/drivers/input/joystick/xpad.c
@@ -372,6 +372,7 @@ static const struct xpad_device {
 	{ 0x2993, 0x2001, "TECNO Pocket Go", 0, XTYPE_XBOX360 },
 	{ 0x2dc8, 0x2000, "8BitDo Pro 2 Wired Controller fox Xbox", 0, XTYPE_XBOXONE },
 	{ 0x2dc8, 0x200f, "8BitDo Ultimate 3-mode Controller for Xbox", MAP_SHARE_BUTTON, XTYPE_XBOXONE },
+	{ 0x2dc8, 0x201e, "8BitDo Pro 2 Wired Controller for Xbox", 0, XTYPE_XBOXONE },
 	{ 0x2dc8, 0x3106, "8BitDo Ultimate Wireless / Pro 2 Wired Controller", 0, XTYPE_XBOX360 },
 	{ 0x2dc8, 0x3109, "8BitDo Ultimate Wireless Bluetooth", 0, XTYPE_XBOX360 },
 	{ 0x2dc8, 0x310a, "8BitDo Ultimate 2C Wireless Controller", 0, XTYPE_XBOX360 },
-- 
2.55.0


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH v3] Input: xpad - add support for 8BitDo Pro 2 Wired Controller for Xbox
  2026-09-25  9:24 [PATCH] Input: xpad - add support for 8BitDo Pro 2 Wired Controller for Xbox Bihaan Sen
  2026-09-25  9:29 ` sashiko-bot
  2026-09-25 11:17 ` [PATCH v2] " Bihaan Sen
@ 2026-09-25 11:44 ` Bihaan Sen
  2026-10-09 19:21   ` Dmitry Torokhov
  2 siblings, 1 reply; 5+ messages in thread
From: Bihaan Sen @ 2026-09-25 11:44 UTC (permalink / raw)
  To: Dmitry Torokhov; +Cc: linux-input, linux-kernel, Bihaan Sen

The 8BitDo Pro 2 Wired Controller for Xbox is already matched by the
vendor-wide XPAD_XBOXONE_VENDOR(0x2dc8) entry, but a later hardware
revision reports product ID 0x201e, which has no entry in the
xpad_device table. The device therefore binds and functions but is
exposed to userspace as "Generic X-Box pad".

Add the VID/PID pair so the controller is named correctly, and set
MAP_SHARE_BUTTON to expose the share button as KEY_RECORD.

Signed-off-by: Bihaan Sen <stevewholikesthings@gmail.com>
---
v3: also set MAP_SHARE_BUTTON to expose the share button as KEY_RECORD.
v2: move the entry after 0x200f to keep xpad_device sorted by product ID

 drivers/input/joystick/xpad.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c
index feb8f368f834..023b70bddf76 100644
--- a/drivers/input/joystick/xpad.c
+++ b/drivers/input/joystick/xpad.c
@@ -372,6 +372,7 @@ static const struct xpad_device {
 	{ 0x2993, 0x2001, "TECNO Pocket Go", 0, XTYPE_XBOX360 },
 	{ 0x2dc8, 0x2000, "8BitDo Pro 2 Wired Controller fox Xbox", 0, XTYPE_XBOXONE },
 	{ 0x2dc8, 0x200f, "8BitDo Ultimate 3-mode Controller for Xbox", MAP_SHARE_BUTTON, XTYPE_XBOXONE },
+	{ 0x2dc8, 0x201e, "8BitDo Pro 2 Wired Controller for Xbox", MAP_SHARE_BUTTON, XTYPE_XBOXONE },
 	{ 0x2dc8, 0x3106, "8BitDo Ultimate Wireless / Pro 2 Wired Controller", 0, XTYPE_XBOX360 },
 	{ 0x2dc8, 0x3109, "8BitDo Ultimate Wireless Bluetooth", 0, XTYPE_XBOX360 },
 	{ 0x2dc8, 0x310a, "8BitDo Ultimate 2C Wireless Controller", 0, XTYPE_XBOX360 },
-- 
2.55.0


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH v3] Input: xpad - add support for 8BitDo Pro 2 Wired Controller for Xbox
  2026-09-25 11:44 ` [PATCH v3] " Bihaan Sen
@ 2026-10-09 19:21   ` Dmitry Torokhov
  0 siblings, 0 replies; 5+ messages in thread
From: Dmitry Torokhov @ 2026-10-09 19:21 UTC (permalink / raw)
  To: Bihaan Sen; +Cc: linux-input, linux-kernel

On Fri, Sep 25, 2026 at 05:14:38PM +0530, Bihaan Sen wrote:
> The 8BitDo Pro 2 Wired Controller for Xbox is already matched by the
> vendor-wide XPAD_XBOXONE_VENDOR(0x2dc8) entry, but a later hardware
> revision reports product ID 0x201e, which has no entry in the
> xpad_device table. The device therefore binds and functions but is
> exposed to userspace as "Generic X-Box pad".
> 
> Add the VID/PID pair so the controller is named correctly, and set
> MAP_SHARE_BUTTON to expose the share button as KEY_RECORD.
> 
> Signed-off-by: Bihaan Sen <stevewholikesthings@gmail.com>

Applied, thank you.

-- 
Dmitry

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2026-10-09 19:21 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-25  9:24 [PATCH] Input: xpad - add support for 8BitDo Pro 2 Wired Controller for Xbox Bihaan Sen
2026-09-25  9:29 ` sashiko-bot
2026-09-25 11:17 ` [PATCH v2] " Bihaan Sen
2026-09-25 11:44 ` [PATCH v3] " Bihaan Sen
2026-10-09 19:21   ` Dmitry Torokhov

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.