All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] board: sophgo: milkv_duo_256m: fix fdtfile quoting
@ 2026-10-09 14:38 Hiago De Franco
  2026-10-10  7:52 ` Yao Zi
  0 siblings, 1 reply; 2+ messages in thread
From: Hiago De Franco @ 2026-10-09 14:38 UTC (permalink / raw)
  To: Leo Yu-Chi Liang, u-boot, Yao Zi
  Cc: Tom Rini, Tim Ouyang, Zhuxu Ran, Kongyang Liu

CONFIG_DEFAULT_DEVICE_TREE is a quoted string, so the quotes end up in
the environment:

  fdtfile="sg2002-milkv-duo256m".dtb

Use DEFAULT_DEVICE_TREE instead, which the build passes to the
environment preprocessor without the quotes:

  fdtfile=sophgo/sg2002-milkv-duo256m.dtb

Fixes: 98b59e181daa ("board: sophgo: add support for Milk-V Duo 256M")
Signed-off-by: Hiago De Franco <hfranco@baylibre.com>
---
This is a continuation of
https://lore.kernel.org/all/20260930-256m-fixes-v1-0-69546876ff28@baylibre.com/,
as asked by Yao Zi.

Tested on the Milk-V Duo 256M (SG2002).
---
Changes in v2:
- Drop "riscv: cpu: cv1800b: keep U-Boot out of reserved memory". The
  coprocessor reserved-memory nodes are being dropped from the upstream
  Milk-V Duo devicetrees, which makes the workaround unnecessary.
- Link to v1: https://lore.kernel.org/all/20260930-256m-fixes-v1-0-69546876ff28@baylibre.com/

To: Hiago De Franco <hfranco@baylibre.com>
To: Leo Yu-Chi Liang <leo.liang@sifive.com>
To: u-boot@lists.u-boot-project.org
Cc: Tom Rini <trini@konsulko.com>
---
 board/sophgo/milkv_duo_256m/milkv_duo_256m.env | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/board/sophgo/milkv_duo_256m/milkv_duo_256m.env b/board/sophgo/milkv_duo_256m/milkv_duo_256m.env
index 4c1e17b53ca..4c9f53d0811 100644
--- a/board/sophgo/milkv_duo_256m/milkv_duo_256m.env
+++ b/board/sophgo/milkv_duo_256m/milkv_duo_256m.env
@@ -1,5 +1,5 @@
 fdt_addr_r=0x84000000
-fdtfile=CONFIG_DEFAULT_DEVICE_TREE.dtb
+fdtfile=DEFAULT_DEVICE_TREE.dtb
 kernel_addr_r=0x80200000
 kernel_comp_addr_r=0x88000000
 kernel_comp_size=0x4000000

---
base-commit: f8eb3469e1a17c79b047b3fd38ae820e8816a115
change-id: 20260929-256m-fixes-919700ca762f
prerequisite-change-id: 20260702-milkv-duo-upstream-dts-b54aed41fc61:v5
prerequisite-patch-id: b8e6815314b7881a02de0066232864d522c4a26c
prerequisite-patch-id: 0df1fa5db1b2bff402b429809796bad99a517483
prerequisite-patch-id: 49e1e8263cf0a5ba8d63c8b598b6382cde5284b2
prerequisite-patch-id: 86dd30e784f022f0a7bb6fbf125c9699467176d4
prerequisite-patch-id: 49070c05ecf58331ec519a57d1b82f8b2b835a89
prerequisite-patch-id: 6b6881e45cc6de6544aaa4509db21611158f4fa1
prerequisite-patch-id: 7198127d4602eeb14212087ce9bb694d84e71a4c
prerequisite-patch-id: 3a58bd8a061707ff27b8538d4897def3b595dc36
prerequisite-patch-id: 9055ea941b73e35d1e825787d7eca14ffceb8e8b
prerequisite-patch-id: 554c1487e8d596e0099677ca88eee0021b1ffbae

Best regards,
--  
Hiago


^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-10-10  7:53 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-10-09 14:38 [PATCH v2] board: sophgo: milkv_duo_256m: fix fdtfile quoting Hiago De Franco
2026-10-10  7:52 ` Yao Zi

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.