From: Manivannan Sadhasivam <mani@kernel.org>
To: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Wesley Cheng <quic_wcheng@quicinc.com>,
Vinod Koul <vkoul@kernel.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Christian Marangi <ansuelsmth@gmail.com>,
Andy Gross <agross@codeaurora.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-phy@lists.infradead.org
Subject: Re: [PATCH 07/10] phy: qcom-ipq806x-usb: parse the tx-deamp-3_5db property as documented
Date: Mon, 12 Oct 2026 13:50:28 +0530 [thread overview]
Message-ID: <asyYLiGuhLFnyvwJ@debian> (raw)
In-Reply-To: <20260810-msm8974-usb3-v1-7-1a47e1185524@oss.qualcomm.com>
On Mon, Aug 10, 2026 at 02:42:37PM +0300, Dmitry Baryshkov wrote:
> The driver reads the transmit de-emphasis override from
> qcom,tx-deamp_3_5db while the binding documents qcom,tx-deamp-3_5db,
> so a device tree following the binding is silently ignored and the
> default is used instead. No in-tree device tree uses either spelling.
>
> Parse the property under its documented name.
>
> Fixes: ef19b117b834 ("phy: qualcomm: add qcom ipq806x dwc usb phy driver")
> Assisted-by: Claude:claude-fable-5
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
- Mani
--
மணிவண்ணன் சதாசிவம்
WARNING: multiple messages have this Message-ID (diff)
From: Manivannan Sadhasivam <mani@kernel.org>
To: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Wesley Cheng <quic_wcheng@quicinc.com>,
Vinod Koul <vkoul@kernel.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Christian Marangi <ansuelsmth@gmail.com>,
Andy Gross <agross@codeaurora.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-phy@lists.infradead.org
Subject: Re: [PATCH 07/10] phy: qcom-ipq806x-usb: parse the tx-deamp-3_5db property as documented
Date: Mon, 12 Oct 2026 13:50:28 +0530 [thread overview]
Message-ID: <asyYLiGuhLFnyvwJ@debian> (raw)
In-Reply-To: <20260810-msm8974-usb3-v1-7-1a47e1185524@oss.qualcomm.com>
On Mon, Aug 10, 2026 at 02:42:37PM +0300, Dmitry Baryshkov wrote:
> The driver reads the transmit de-emphasis override from
> qcom,tx-deamp_3_5db while the binding documents qcom,tx-deamp-3_5db,
> so a device tree following the binding is silently ignored and the
> default is used instead. No in-tree device tree uses either spelling.
>
> Parse the property under its documented name.
>
> Fixes: ef19b117b834 ("phy: qualcomm: add qcom ipq806x dwc usb phy driver")
> Assisted-by: Claude:claude-fable-5
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
- Mani
--
மணிவண்ணன் சதாசிவம்
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2026-10-12 8:20 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-10 11:42 [PATCH 00/10] ARM: qcom: enable USB3 (DWC3) controller on MSM8974 platform Dmitry Baryshkov
2026-08-10 11:42 ` Dmitry Baryshkov
2026-08-10 11:42 ` [PATCH 01/10] dt-bindings: usb: qcom,snps-dwc3: document the MSM8974 controller Dmitry Baryshkov
2026-08-10 11:42 ` Dmitry Baryshkov
2026-08-20 6:24 ` Krzysztof Kozlowski
2026-08-20 6:24 ` Krzysztof Kozlowski
2026-08-10 11:42 ` [PATCH 02/10] dt-bindings: phy: qcom,ipq806x-usb-phy-hs: document the MSM8974 HS PHY Dmitry Baryshkov
2026-08-10 11:42 ` Dmitry Baryshkov
2026-08-20 6:28 ` Krzysztof Kozlowski
2026-08-20 6:28 ` Krzysztof Kozlowski
2026-08-10 11:42 ` [PATCH 03/10] dt-bindings: phy: qcom,ipq806x-usb-phy-ss: add MSM8974 SS PHY Dmitry Baryshkov
2026-08-10 11:42 ` Dmitry Baryshkov
2026-08-10 11:54 ` sashiko-bot
2026-08-10 11:54 ` sashiko-bot
2026-08-10 13:05 ` Rob Herring (Arm)
2026-08-10 13:05 ` Rob Herring (Arm)
2026-08-20 6:31 ` Krzysztof Kozlowski
2026-08-20 6:31 ` Krzysztof Kozlowski
2026-08-10 11:42 ` [PATCH 04/10] phy: qcom-ipq806x-usb: add MSM8974 HS PHY support Dmitry Baryshkov
2026-08-10 11:42 ` Dmitry Baryshkov
2026-08-10 11:51 ` sashiko-bot
2026-08-10 11:51 ` sashiko-bot
2026-08-18 8:55 ` Konrad Dybcio
2026-08-18 8:55 ` Konrad Dybcio
2026-08-10 11:42 ` [PATCH 05/10] phy: qcom-ipq806x-usb: fix the SS PHY TEST_POWERDOWN bit Dmitry Baryshkov
2026-08-10 11:42 ` Dmitry Baryshkov
2026-08-10 11:53 ` sashiko-bot
2026-08-10 11:53 ` sashiko-bot
2026-08-18 8:57 ` Konrad Dybcio
2026-08-18 8:57 ` Konrad Dybcio
2026-10-12 8:10 ` Manivannan Sadhasivam
2026-10-12 8:10 ` Manivannan Sadhasivam
2026-08-10 11:42 ` [PATCH 06/10] phy: qcom-ipq806x-usb: fix the PHY_PARAM_CTRL1 field masks Dmitry Baryshkov
2026-08-10 11:42 ` Dmitry Baryshkov
2026-08-10 11:57 ` sashiko-bot
2026-08-10 11:57 ` sashiko-bot
2026-08-18 8:59 ` Konrad Dybcio
2026-08-18 8:59 ` Konrad Dybcio
2026-10-12 8:19 ` Manivannan Sadhasivam
2026-10-12 8:19 ` Manivannan Sadhasivam
2026-08-10 11:42 ` [PATCH 07/10] phy: qcom-ipq806x-usb: parse the tx-deamp-3_5db property as documented Dmitry Baryshkov
2026-08-10 11:42 ` Dmitry Baryshkov
2026-08-10 11:49 ` sashiko-bot
2026-08-10 11:49 ` sashiko-bot
2026-08-18 9:00 ` Konrad Dybcio
2026-08-18 9:00 ` Konrad Dybcio
2026-10-12 8:20 ` Manivannan Sadhasivam [this message]
2026-10-12 8:20 ` Manivannan Sadhasivam
2026-08-10 11:42 ` [PATCH 08/10] phy: qcom-ipq806x-usb: support the MSM8974 SS PHY parameters Dmitry Baryshkov
2026-08-10 11:42 ` Dmitry Baryshkov
2026-08-10 11:56 ` sashiko-bot
2026-08-10 11:56 ` sashiko-bot
2026-08-18 9:01 ` Konrad Dybcio
2026-08-18 9:01 ` Konrad Dybcio
2026-10-12 8:22 ` Manivannan Sadhasivam
2026-10-12 8:22 ` Manivannan Sadhasivam
2026-08-10 11:42 ` [PATCH 09/10] ARM: dts: qcom: msm8974: add the USB3 controller and its PHYs Dmitry Baryshkov
2026-08-10 11:42 ` Dmitry Baryshkov
2026-08-10 12:04 ` sashiko-bot
2026-08-10 12:04 ` sashiko-bot
2026-08-18 9:05 ` Konrad Dybcio
2026-08-18 9:05 ` Konrad Dybcio
2026-08-10 11:42 ` [PATCH 10/10] ARM: dts: qcom: apq8074-dragonboard: enable the USB3 host Dmitry Baryshkov
2026-08-10 11:42 ` Dmitry Baryshkov
2026-08-10 12:07 ` sashiko-bot
2026-08-10 12:07 ` sashiko-bot
2026-08-18 9:06 ` Konrad Dybcio
2026-08-18 9:06 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=asyYLiGuhLFnyvwJ@debian \
--to=mani@kernel.org \
--cc=agross@codeaurora.org \
--cc=andersson@kernel.org \
--cc=ansuelsmth@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=gregkh@linuxfoundation.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=quic_wcheng@quicinc.com \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.