From: Manivannan Sadhasivam <mani@kernel.org>
To: george.moussalem@outlook.com
Cc: Vinod Koul <vkoul@kernel.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Praveenkumar I <praveenkumar.i@oss.qualcomm.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Varadarajan Narayanan <varadarajan.narayanan@oss.qualcomm.com>,
Nitheesh Sekar <quic_nsekar@quicinc.com>,
Wesley Cheng <quic_wcheng@quicinc.com>,
Varadarajan Narayanan <quic_varada@quicinc.com>,
linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org,
Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
Stanislaw Pal <kuncy7@gmail.com>
Subject: Re: [PATCH v4 05/13] phy: qualcomm: qcom-uniphy-pcie-usb3-28lp: Refactor init regs table definitions
Date: Mon, 12 Oct 2026 18:10:14 +0530 [thread overview]
Message-ID: <aszVD7ngiPeb9FtA@debian> (raw)
In-Reply-To: <20260908-ipq5018-usb3-v4-5-b789702f0695@outlook.com>
On Tue, Sep 08, 2026 at 01:40:58PM +0400, George Moussalem via B4 Relay wrote:
> From: George Moussalem <george.moussalem@outlook.com>
>
> Refactor the IPQ5018/IPQ5332 UNIPHY PCIe init data by introducing a
> helper macro for register/value entries and converting open-coded struct
> initializers to the compact form.
>
> No functional change intended.
>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> Tested-by: Stanislaw Pal <kuncy7@gmail.com>
> Signed-off-by: George Moussalem <george.moussalem@outlook.com>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
- Mani
--
மணிவண்ணன் சதாசிவம்
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
WARNING: multiple messages have this Message-ID (diff)
From: Manivannan Sadhasivam <mani@kernel.org>
To: george.moussalem@outlook.com
Cc: Vinod Koul <vkoul@kernel.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Praveenkumar I <praveenkumar.i@oss.qualcomm.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Varadarajan Narayanan <varadarajan.narayanan@oss.qualcomm.com>,
Nitheesh Sekar <quic_nsekar@quicinc.com>,
Wesley Cheng <quic_wcheng@quicinc.com>,
Varadarajan Narayanan <quic_varada@quicinc.com>,
linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org,
Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
Stanislaw Pal <kuncy7@gmail.com>
Subject: Re: [PATCH v4 05/13] phy: qualcomm: qcom-uniphy-pcie-usb3-28lp: Refactor init regs table definitions
Date: Mon, 12 Oct 2026 18:10:14 +0530 [thread overview]
Message-ID: <aszVD7ngiPeb9FtA@debian> (raw)
In-Reply-To: <20260908-ipq5018-usb3-v4-5-b789702f0695@outlook.com>
On Tue, Sep 08, 2026 at 01:40:58PM +0400, George Moussalem via B4 Relay wrote:
> From: George Moussalem <george.moussalem@outlook.com>
>
> Refactor the IPQ5018/IPQ5332 UNIPHY PCIe init data by introducing a
> helper macro for register/value entries and converting open-coded struct
> initializers to the compact form.
>
> No functional change intended.
>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> Tested-by: Stanislaw Pal <kuncy7@gmail.com>
> Signed-off-by: George Moussalem <george.moussalem@outlook.com>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
- Mani
--
மணிவண்ணன் சதாசிவம்
next prev parent reply other threads:[~2026-10-12 12:40 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-08 9:40 [PATCH v4 00/13] Enable USB3 for Qualcomm IPQ5018 George Moussalem
2026-09-08 9:40 ` George Moussalem via B4 Relay
2026-09-08 9:40 ` George Moussalem via B4 Relay
2026-09-08 9:40 ` [PATCH v4 01/13] dt-bindings: phy: qcom,ipq5332-uniphy-pcie: Document the IPQ5018 USB3 PHY George Moussalem
2026-09-08 9:40 ` George Moussalem via B4 Relay
2026-09-08 9:40 ` George Moussalem via B4 Relay
2026-09-08 9:40 ` [PATCH v4 02/13] phy: qualcomm: qcom-uniphy-pcie-28lp: Convert to PCIe/USB3 combo PHY driver George Moussalem
2026-09-08 9:40 ` George Moussalem via B4 Relay
2026-09-08 9:40 ` George Moussalem via B4 Relay
2026-10-12 12:37 ` Manivannan Sadhasivam
2026-10-12 12:37 ` Manivannan Sadhasivam
2026-09-08 9:40 ` [PATCH v4 03/13] phy: qualcomm: qcom-uniphy-pcie-usb3-28lp: Remove unused of_device.h header file George Moussalem
2026-09-08 9:40 ` George Moussalem via B4 Relay
2026-09-08 9:40 ` George Moussalem via B4 Relay
2026-10-12 12:38 ` Manivannan Sadhasivam
2026-10-12 12:38 ` Manivannan Sadhasivam
2026-09-08 9:40 ` [PATCH v4 04/13] phy: qualcomm: qcom-uniphy-pcie-usb3-28lp: Drop unused phy_to_dw_phy macro George Moussalem
2026-09-08 9:40 ` George Moussalem via B4 Relay
2026-09-08 9:40 ` George Moussalem via B4 Relay
2026-10-12 12:39 ` Manivannan Sadhasivam
2026-10-12 12:39 ` Manivannan Sadhasivam
2026-09-08 9:40 ` [PATCH v4 05/13] phy: qualcomm: qcom-uniphy-pcie-usb3-28lp: Refactor init regs table definitions George Moussalem
2026-09-08 9:40 ` George Moussalem via B4 Relay
2026-09-08 9:40 ` George Moussalem via B4 Relay
2026-10-12 12:40 ` Manivannan Sadhasivam [this message]
2026-10-12 12:40 ` Manivannan Sadhasivam
2026-09-08 9:40 ` [PATCH v4 06/13] phy: qualcomm: qcom-uniphy-pcie-usb3-28lp: Use bulk reset_control API George Moussalem
2026-09-08 9:40 ` George Moussalem via B4 Relay
2026-09-08 9:40 ` George Moussalem via B4 Relay
2026-09-08 9:41 ` [PATCH v4 07/13] phy: qualcomm: qcom-uniphy-pcie-usb3-28lp: Assert reset on clock enable failure George Moussalem
2026-09-08 9:41 ` George Moussalem via B4 Relay
2026-09-08 9:41 ` George Moussalem via B4 Relay
2026-10-12 12:41 ` Manivannan Sadhasivam
2026-10-12 12:41 ` Manivannan Sadhasivam
2026-09-08 9:41 ` [PATCH v4 08/13] phy: qualcomm: qcom-uniphy-pcie-usb3-28lp: Add support for USB3 PHY on IPQ5018 George Moussalem
2026-09-08 9:41 ` George Moussalem via B4 Relay
2026-09-08 9:41 ` George Moussalem via B4 Relay
2026-10-12 12:48 ` Manivannan Sadhasivam
2026-10-12 12:48 ` Manivannan Sadhasivam
2026-09-08 9:41 ` [PATCH v4 09/13] arm64: dts: qcom: ipq5018: Add USB Super-Speed PHY node George Moussalem
2026-09-08 9:41 ` George Moussalem via B4 Relay
2026-09-08 9:41 ` George Moussalem via B4 Relay
2026-09-08 9:41 ` [PATCH v4 10/13] dt-bindings: usb: qcom,snps-dwc3: Add clocks for USB3 on Qualcomm IPQ5018 George Moussalem
2026-09-08 9:41 ` George Moussalem via B4 Relay
2026-09-08 9:41 ` George Moussalem via B4 Relay
2026-09-08 9:41 ` [PATCH v4 11/13] arm64: dts: qcom: ipq5018: Add clocks required for USB3 support George Moussalem
2026-09-08 9:41 ` George Moussalem via B4 Relay
2026-09-08 9:41 ` George Moussalem via B4 Relay
2026-09-08 9:41 ` [PATCH v4 12/13] arm64: dts: qcom: ipq5018: Add Super-Speed UNIPHY to USB node George Moussalem
2026-09-08 9:41 ` George Moussalem via B4 Relay
2026-09-08 9:41 ` George Moussalem via B4 Relay
2026-09-08 9:41 ` [PATCH v4 13/13] arm64: dts: qcom: ipq5018-rdp432-c2: Enable USB Super-Speed PHY George Moussalem
2026-09-08 9:41 ` George Moussalem via B4 Relay
2026-09-08 9:41 ` George Moussalem via B4 Relay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aszVD7ngiPeb9FtA@debian \
--to=mani@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=george.moussalem@outlook.com \
--cc=gregkh@linuxfoundation.org \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=kuncy7@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=p.zabel@pengutronix.de \
--cc=praveenkumar.i@oss.qualcomm.com \
--cc=quic_nsekar@quicinc.com \
--cc=quic_varada@quicinc.com \
--cc=quic_wcheng@quicinc.com \
--cc=robh@kernel.org \
--cc=varadarajan.narayanan@oss.qualcomm.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.